beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Limit HTMLProgressElement.max to positive values

Browse source 
Previously, 0 was returned if `HTMLProgressElement.max` was set to a
negative value.
This commit is contained in:
Tim Ledbetter 2024-08-19 07:11:01 +01:00 committed by Andreas Kling
parent a94bf9bd09
commit 353e3e75dc
Notes: github-actions[bot] 2024-08-19 07:03:11 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/353e3e75dcf
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1118
3 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/HTML/HTMLProgressElement-set-attributes.txt
View file

@ -2,6 +2,7 @@ value attribute initial value: 0
max attribute initial value: 1
value attribute after setting value attribute to -1: 0
max attribute after setting max attribute to -1: 1
max attribute after setting max attribute to 0: 1
value attribute after setting value attribute to 50: 1
value attribute after setting max attribute to 100: 50
max attribute after setting max attribute to 100: 100

2
Tests/LibWeb/Text/input/HTML/HTMLProgressElement-set-attributes.html
View file

@ -9,6 +9,8 @@
println(`value attribute after setting value attribute to -1: ${progressElement.value}`);
progressElement.max = -1;
println(`max attribute after setting max attribute to -1: ${progressElement.max}`);
progressElement.max = 0;
println(`max attribute after setting max attribute to 0: ${progressElement.max}`);
progressElement.value = 50;
println(`value attribute after setting value attribute to 50: ${progressElement.value}`);
progressElement.max = 100;

3
Userland/Libraries/LibWeb/HTML/HTMLProgressElement.cpp
View file

@ -64,7 +64,8 @@ double HTMLProgressElement::max() const
{
if (auto max_string = get_attribute(HTML::AttributeNames::max); max_string.has_value()) {
if (auto max = parse_floating_point_number(*max_string); max.has_value())
return AK::max(*max, 0);
if (*max > 0)
return *max;
}
return 1;
}