beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Account for header size when reading MessagePort message payload

Browse source 
Previously, the fact that this wasn't accounted for could lead to a
crash when large messages were received.
This commit is contained in:
Tim Ledbetter 2024-07-30 15:04:32 +01:00 committed by Andreas Kling
parent f735c464d3
commit 34e465a67e
Notes: github-actions[bot] 2024-08-01 09:41:31 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/34e465a67e4
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/906
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/MessagePort.cpp
View file

@ -279,7 +279,7 @@ ErrorOr<MessagePort::ParseDecision> MessagePort::parse_message()
[[fallthrough]];
}
case SocketState::Data: {
if (num_bytes_ready < m_socket_incoming_message_size)
if (num_bytes_ready < HEADER_SIZE + m_socket_incoming_message_size)
return ParseDecision::NotEnoughData;
auto payload = m_buffered_data.span().slice(HEADER_SIZE, m_socket_incoming_message_size);