beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Fix spec typo in inner_navigate_event_firing_algorithm
Some checks are pending
CI / Lagom (false, FUZZ, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
CI / Lagom (false, NO_FUZZ, macos-14, macOS, Clang) (push) Waiting to run
Details
CI / Lagom (false, NO_FUZZ, ubuntu-24.04, Linux, GNU) (push) Waiting to run
Details
CI / Lagom (true, NO_FUZZ, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (macos-14, macOS, macOS-universal2) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source
This commit is contained in:
Shannon Booth 2024-10-14 11:30:43 +13:00 committed by Andreas Kling
parent dc9861174b
commit 329e9ed820
Notes: github-actions[bot] 2024-10-14 18:49:56 +00:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/LadybirdBrowser/ladybird/commit/329e9ed820e
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1780
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibWeb/HTML/Navigation.cpp
View file

@ -983,11 +983,10 @@ bool Navigation::inner_navigate_event_firing_algorithm(
&& destination->same_document()
&& (user_involvement != UserNavigationInvolvement::BrowserUI || relevant_global_object.has_history_action_activation());
// FIXME: Fix spec grammaro, extra 'the -> set'
// 11. If either:
// - navigationType is not "traverse"; or
// - traverseCanBeCanceled is true
// the initialize event's cancelable to true. Otherwise, initialize it to false.
// then initialize event's cancelable to true. Otherwise, initialize it to false.
event_init.cancelable = (navigation_type != Bindings::NavigationType::Traverse) || traverse_can_be_canceled;
// 12. Initialize event's type to "navigate".