beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Stub SVGTextContentElement.getStartPositionOfChar()

Browse source
This commit is contained in:
MacDue 2024-04-01 00:45:54 +01:00 committed by Alexander Kalenik
parent bafb6bd059
commit 329262d54f
Notes: sideshowbarker 2024-07-17 07:19:27 +09:00 
Author: https://github.com/MacDue
Commit: https://github.com/SerenityOS/serenity/commit/329262d54f
Pull-request: https://github.com/SerenityOS/serenity/pull/23793
Reviewed-by: https://github.com/shannonbooth
3 changed files with 14 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/SVG/SVGTextContentElement.cpp
View file

@ -51,10 +51,16 @@ ByteString SVGTextContentElement::text_contents() const
}
// https://svgwg.org/svg2-draft/text.html#__svg__SVGTextContentElement__getNumberOfChars
WebIDL::ExceptionOr<int> SVGTextContentElement::get_number_of_chars() const
WebIDL::ExceptionOr<WebIDL::Long> SVGTextContentElement::get_number_of_chars() const
{
auto chars = TRY_OR_THROW_OOM(vm(), utf8_to_utf16(text_contents()));
return static_cast<int>(chars.size());
return static_cast<WebIDL::Long>(chars.size());
}
JS::NonnullGCPtr<Geometry::DOMPoint> SVGTextContentElement::get_start_position_of_char(WebIDL::UnsignedLong charnum)
{
dbgln("(STUBBED) SVGTextContentElement::get_start_position_of_char(charnum={}). Called on: {}", charnum, debug_description());
return Geometry::DOMPoint::from_point(vm(), Geometry::DOMPointInit {});
}
}

6
Userland/Libraries/LibWeb/SVG/SVGTextContentElement.h
View file

@ -6,9 +6,11 @@
#pragma once
#include <LibWeb/Geometry/DOMPoint.h>
#include <LibWeb/SVG/AttributeParser.h>
#include <LibWeb/SVG/SVGGraphicsElement.h>
#include <LibWeb/WebIDL/ExceptionOr.h>
#include <LibWeb/WebIDL/Types.h>
namespace Web::SVG {
@ -17,12 +19,14 @@ class SVGTextContentElement : public SVGGraphicsElement {
WEB_PLATFORM_OBJECT(SVGTextContentElement, SVGGraphicsElement);
public:
WebIDL::ExceptionOr<int> get_number_of_chars() const;
WebIDL::ExceptionOr<WebIDL::Long> get_number_of_chars() const;
Optional<TextAnchor> text_anchor() const;
ByteString text_contents() const;
JS::NonnullGCPtr<Geometry::DOMPoint> get_start_position_of_char(WebIDL::UnsignedLong charnum);
protected:
SVGTextContentElement(DOM::Document&, DOM::QualifiedName);

2
Userland/Libraries/LibWeb/SVG/SVGTextContentElement.idl
View file

@ -15,7 +15,7 @@ interface SVGTextContentElement : SVGGraphicsElement {
long getNumberOfChars();
// FIXME: float getComputedTextLength();
// FIXME: float getSubStringLength(unsigned long charnum, unsigned long nchars);
// FIXME: DOMPoint getStartPositionOfChar(unsigned long charnum);
DOMPoint getStartPositionOfChar(unsigned long charnum);
// FIXME: DOMPoint getEndPositionOfChar(unsigned long charnum);
// FIXME: DOMRect getExtentOfChar(unsigned long charnum);
// FIXME: float getRotationOfChar(unsigned long charnum);