beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Documentation+Toolchain: Don't try to build CMake from source

Browse source 
This build step is a bit excessive. Let's require people to have an
up-to-date CMake from their system package manager instead.
This commit is contained in:
Andrew Kaster 2024-07-13 14:47:06 -06:00 committed by Andreas Kling
parent 182f83d456
commit 31eec0a145
Notes: sideshowbarker 2024-07-17 21:16:31 +09:00 
Author: https://github.com/ADKaster
Commit: https://github.com/LadybirdBrowser/ladybird/commit/31eec0a145
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/618
Reviewed-by: https://github.com/awesomekling
4 changed files with 1 additions and 90 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Documentation/BuildInstructionsLadybird.md
View file

@ -15,7 +15,7 @@ NOTE: In all of the below lists of packages, the Qt6 multimedia package is not n
```bash
sudo apt install autoconf autoconf-archive automake build-essential git cmake libavcodec-dev libgl1-mesa-dev nasm \
ninja-build qt6-base-dev qt6-tools-dev-tools qt6-multimedia-dev qt6-wayland ccache fonts-liberation2 \
zip unzip curl tar libssl-dev
zip unzip curl tar
```
#### CMake 3.25 or newer:

6
Meta/CMake/cmake-version.cmake
View file

@ -1,6 +0,0 @@
# Note: Update this alongside Toolchain/BuildCMake.sh
set(version_ok 0)
if (CMAKE_VERSION VERSION_GREATER_EQUAL 3.25.1)
set(version_ok 1)
endif()
execute_process(COMMAND "${CMAKE_COMMAND}" -E echo "${version_ok}")

9
Meta/ladybird.sh
View file

@ -153,20 +153,11 @@ delete_target() {
[ ! -d "$BUILD_DIR" ] || rm -rf "$BUILD_DIR"
}
build_cmake() {
echo "CMake version too old: build_cmake"
( cd "$LADYBIRD_SOURCE_DIR/Toolchain" && ./BuildCMake.sh )
}
build_vcpkg() {
( cd "$LADYBIRD_SOURCE_DIR/Toolchain" && ./BuildVcpkg.sh )
}
ensure_toolchain() {
if [ "$(cmake -P "$LADYBIRD_SOURCE_DIR"/Meta/CMake/cmake-version.cmake)" -ne 1 ]; then
build_cmake
fi
build_vcpkg
}

74
Toolchain/BuildCMake.sh
View file

@ -1,74 +0,0 @@
#!/usr/bin/env bash
# This script builds the CMake build system
set -e
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
# shellcheck source=/dev/null
. "${DIR}/../Meta/shell_include.sh"
exit_if_running_as_root "Do not run BuildCMake.sh as root, parts of your Toolchain directory will become root-owned"
PREFIX_DIR="$DIR/Local/cmake"
BUILD_DIR="$DIR/Build/cmake"
TARBALLS_DIR="$DIR/Tarballs"
NPROC=$(get_number_of_processing_units)
[ -z "$MAKEJOBS" ] && MAKEJOBS=${NPROC}
check_sha() {
if [ $# -ne 2 ]; then
error "Usage: check_sha FILE EXPECTED_HASH"
return 1
fi
FILE="${1}"
EXPECTED_HASH="${2}"
SYSTEM_NAME="$(uname -s)"
if [ "$SYSTEM_NAME" = "Darwin" ]; then
SEEN_HASH="$(shasum -a 256 "${FILE}" | cut -d " " -f 1)"
else
SEEN_HASH="$(sha256sum "${FILE}" | cut -d " " -f 1)"
fi
test "${EXPECTED_HASH}" = "${SEEN_HASH}"
}
# Note: Update this alongside the cmake port, and Meta/CMake/cmake-version.cmake if the build requires this version of cmake.
CMAKE_VERSION=3.26.4
CMAKE_ARCHIVE_SHA256=313b6880c291bd4fe31c0aa51d6e62659282a521e695f30d5cc0d25abbd5c208
CMAKE_ARCHIVE=cmake-${CMAKE_VERSION}.tar.gz
CMAKE_ARCHIVE_URL=https://github.com/Kitware/CMake/releases/download/v${CMAKE_VERSION}/${CMAKE_ARCHIVE}
mkdir -p "$DIR"/Tarballs
pushd "$DIR"/Tarballs
if [ ! -e "${CMAKE_ARCHIVE}" ]; then
echo "Downloading CMake from ${CMAKE_ARCHIVE_URL}..."
curl "${CMAKE_ARCHIVE_URL}" -L -o "${CMAKE_ARCHIVE}"
else
echo "${CMAKE_ARCHIVE} already exists, not downloading archive"
fi
if ! check_sha "${CMAKE_ARCHIVE}" "${CMAKE_ARCHIVE_SHA256}"; then
echo "CMake archive SHA256 sum mismatch, please run script again"
rm -f "${CMAKE_ARCHIVE}"
exit 1
fi
if [ ! -d "cmake-${CMAKE_VERSION}" ]; then
echo "Extracting ${CMAKE_ARCHIVE}..."
tar -xf "${CMAKE_ARCHIVE}"
else
echo "cmake-${CMAKE_VERSION} already exists, not extracting archive"
fi
popd
mkdir -p "${PREFIX_DIR}"
mkdir -p "${BUILD_DIR}"
pushd "${BUILD_DIR}"
"${TARBALLS_DIR}"/cmake-"${CMAKE_VERSION}"/bootstrap --generator="Ninja" --prefix="${PREFIX_DIR}" --parallel="${MAKEJOBS}"
ninja -j "${MAKEJOBS}"
ninja install
popd