beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Ladybird: Remove unused JS console methods

Browse source 
Note that the real implementations of these functions are:
    notify_server_did_output_js_console_message
    notify_server_did_get_js_console_messages

Which have the same method bodies as these unused variants.
This commit is contained in:
Timothy Flynn 2023-05-17 10:00:57 -04:00 committed by Andreas Kling
parent d8b14da380
commit 31d7565cf3
Notes: sideshowbarker 2024-07-17 21:16:31 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/31d7565cf3
Pull-request: https://github.com/SerenityOS/serenity/pull/18893
2 changed files with 0 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
Ladybird/WebContentView.cpp
View file

@ -473,18 +473,6 @@ void WebContentView::update_viewport_rect()
request_repaint(); request_repaint();
} }
void WebContentView::did_output_js_console_message(i32 message_index)
{
if (m_console_widget)
m_console_widget->notify_about_new_console_message(message_index);
}
void WebContentView::did_get_js_console_messages(i32 start_index, Vector<DeprecatedString> message_types, Vector<DeprecatedString> messages)
{
if (m_console_widget)
m_console_widget->handle_console_messages(start_index, message_types, messages);
}
void WebContentView::ensure_js_console_widget() void WebContentView::ensure_js_console_widget()
{ {
if (!m_console_widget) { if (!m_console_widget) {

3
Ladybird/WebContentView.h
View file

@ -91,9 +91,6 @@ public:
virtual void focusOutEvent(QFocusEvent*) override; virtual void focusOutEvent(QFocusEvent*) override;
virtual bool event(QEvent*) override; virtual bool event(QEvent*) override;
void did_output_js_console_message(i32 message_index);
void did_get_js_console_messages(i32 start_index, Vector<DeprecatedString> message_types, Vector<DeprecatedString> messages);
void show_js_console(); void show_js_console();
enum class InspectorTarget { enum class InspectorTarget {