beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 23:50:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWebView+WebContent: Remove unused did_get_dom_node_properties IPC

Browse source 
This is never invoked. The functionality it provides is implemented by
the return value of the `inspect_dom_node` IPC.
This commit is contained in:
Timothy Flynn 2023-11-23 19:12:38 -05:00 committed by Andreas Kling
parent fcaa994d4e
commit 30e96749de
Notes: sideshowbarker 2024-07-17 18:08:55 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/30e96749de
Pull-request: https://github.com/SerenityOS/serenity/pull/22038
5 changed files with 0 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Userland/Applications/Browser/Tab.cpp
View file

@ -580,10 +580,6 @@ Tab::Tab(BrowserWindow& window)
m_dom_inspector_widget->set_dom_json(dom_tree);
};
view().on_received_dom_node_properties = [this](auto node_id, auto& specified, auto& computed, auto& custom_properties, auto& node_box_sizing, auto& aria_properties_state) {
m_dom_inspector_widget->set_dom_node_properties_json({ node_id }, specified, computed, custom_properties, node_box_sizing, aria_properties_state);
};
view().on_received_accessibility_tree = [this](auto& accessibility_tree) {
if (m_dom_inspector_widget)
m_dom_inspector_widget->set_accessibility_json(accessibility_tree);

1
Userland/Libraries/LibWebView/ViewImplementation.h
View file

@ -141,7 +141,6 @@ public:
Function<void()> on_request_dismiss_dialog;
Function<void(const AK::URL&, DeprecatedString const&)> on_received_source;
Function<void(DeprecatedString const&)> on_received_dom_tree;
Function<void(i32 node_id, DeprecatedString const& computed_style, DeprecatedString const& resolved_style, DeprecatedString const& custom_properties, DeprecatedString const& node_box_sizing, DeprecatedString const& aria_properties_state)> on_received_dom_node_properties;
Function<void(DeprecatedString const&)> on_received_accessibility_tree;
Function<void(i32 message_id)> on_received_console_message;
Function<void(i32 start_index, Vector<DeprecatedString> const& message_types, Vector<DeprecatedString> const& messages)> on_received_console_messages;

6
Userland/Libraries/LibWebView/WebContentClient.cpp
View file

@ -208,12 +208,6 @@ void WebContentClient::did_get_dom_tree(DeprecatedString const& dom_tree)
m_view.on_received_dom_tree(dom_tree);
}
void WebContentClient::did_get_dom_node_properties(i32 node_id, DeprecatedString const& computed_style, DeprecatedString const& resolved_style, DeprecatedString const& custom_properties, DeprecatedString const& node_box_sizing, DeprecatedString const& aria_properties_state)
{
if (m_view.on_received_dom_node_properties)
m_view.on_received_dom_node_properties(node_id, computed_style, resolved_style, custom_properties, node_box_sizing, aria_properties_state);
}
void WebContentClient::did_get_accessibility_tree(DeprecatedString const& accessibility_tree)
{
if (m_view.on_received_accessibility_tree)

1
Userland/Libraries/LibWebView/WebContentClient.h
View file

@ -55,7 +55,6 @@ private:
virtual void did_request_media_context_menu(Gfx::IntPoint, DeprecatedString const&, unsigned, Web::Page::MediaContextMenu const&) override;
virtual void did_get_source(AK::URL const&, DeprecatedString const&) override;
virtual void did_get_dom_tree(DeprecatedString const&) override;
virtual void did_get_dom_node_properties(i32 node_id, DeprecatedString const& computed_style, DeprecatedString const& resolved_style, DeprecatedString const& custom_properties, DeprecatedString const& node_box_sizing, DeprecatedString const& aria_properties_stae) override;
virtual void did_get_accessibility_tree(DeprecatedString const&) override;
virtual void did_output_js_console_message(i32 message_index) override;
virtual void did_get_js_console_messages(i32 start_index, Vector<DeprecatedString> const& message_types, Vector<DeprecatedString> const& messages) override;

1
Userland/Services/WebContent/WebContentClient.ipc
View file

@ -41,7 +41,6 @@ endpoint WebContentClient
did_request_dismiss_dialog() =|
did_get_source(URL url, DeprecatedString source) =|
did_get_dom_tree(DeprecatedString dom_tree) =|
did_get_dom_node_properties(i32 node_id, DeprecatedString computed_style, DeprecatedString resolved_style, DeprecatedString custom_properties, DeprecatedString node_box_sizing_json, DeprecatedString aria_properties_state) =|
did_get_accessibility_tree(DeprecatedString accessibility_tree) =|
did_change_favicon(Gfx::ShareableBitmap favicon) =|
did_request_all_cookies(URL url) => (Vector<Web::Cookie::Cookie> cookies)