beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 23:50:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Port Element::get_attribute_value from DeprecatedFlyString

Browse source
This commit is contained in:
Shannon Booth 2023-11-07 00:29:19 +13:00 committed by Andreas Kling
parent 3f13a50a20
commit 2f009d983b
Notes: sideshowbarker 2024-07-17 22:41:14 +09:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/SerenityOS/serenity/commit/2f009d983b
Pull-request: https://github.com/SerenityOS/serenity/pull/21828
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -155,7 +155,7 @@ DeprecatedString Element::deprecated_get_attribute(StringView name) const
}
// https://dom.spec.whatwg.org/#concept-element-attributes-get-value
DeprecatedString Element::get_attribute_value(StringView local_name, DeprecatedFlyString const& namespace_) const
DeprecatedString Element::get_attribute_value(FlyString const& local_name, Optional<FlyString> const& namespace_) const
{
// 1. Let attr be the result of getting an attribute given namespace, localName, and element.
auto const* attribute = m_attributes->get_attribute_ns(namespace_, local_name);

2
Userland/Libraries/LibWeb/DOM/Element.h
View file

@ -103,7 +103,7 @@ public:
// FIXME: This should be taking a 'FlyString const&' / 'Optional<FlyString> const&'
Optional<String> get_attribute(StringView name) const;
DeprecatedString deprecated_get_attribute(StringView name) const;
DeprecatedString get_attribute_value(StringView local_name, DeprecatedFlyString const& namespace_ = {}) const;
DeprecatedString get_attribute_value(FlyString const& local_name, Optional<FlyString> const& namespace_ = {}) const;
WebIDL::ExceptionOr<void> set_attribute(FlyString const& name, String const& value);