beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 17:40:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Return correct selection_rect when the node is at the end

Browse source 
When the selection state of the node is SelectionState::End, the end
position of the selection within the fragment is not properly
calculated, because it forgets to subtract m_start from index_in_node,
unlike SelectionState::StartAndEnd. This resulted in a wrong selection
shadow being painted when the node is at the end of the selection.

This change resolves #5880.
This commit is contained in:
Tetsui Ohkubo 2021-08-11 22:30:38 +09:00 committed by Andreas Kling
parent c27abaabc4
commit 2edf4b7f61
Notes: sideshowbarker 2024-07-18 05:39:49 +09:00 
Author: https://github.com/peryaudo
Commit: https://github.com/SerenityOS/serenity/commit/2edf4b7f616
Pull-request: https://github.com/SerenityOS/serenity/pull/9340
Issue: https://github.com/SerenityOS/serenity/issues/5880
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/Layout/LineBoxFragment.cpp
View file

@ -137,7 +137,7 @@ Gfx::FloatRect LineBoxFragment::selection_rect(const Gfx::Font& font) const
return {};
auto selection_start_in_this_fragment = 0;
auto selection_end_in_this_fragment = min(selection.end().index_in_node, m_length);
auto selection_end_in_this_fragment = min(selection.end().index_in_node - m_start, m_length);
auto pixel_distance_to_first_selected_character = font.width(text.substring_view(0, selection_start_in_this_fragment));
auto pixel_width_of_selection = font.width(text.substring_view(selection_start_in_this_fragment, selection_end_in_this_fragment - selection_start_in_this_fragment)) + 1;