beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Everywhere: Fix format-vulnerabilities

Browse source 
Command used:
grep -Pirn '(out|warn)ln\((?!["\)]|format,|stderr,|stdout,|output, ")' \
     AK Kernel/ Tests/ Userland/
(Plus some manual reviewing.)

Let's pick ArgsParser as an example:
    outln(file, m_general_help);
This will fail at runtime if the general help happens to contain braces.

Even if this transformation turns out to be unnecessary in a place or
two, this way the code is "more obviously" correct.
This commit is contained in:
Ben Wiederhake 2021-09-09 17:06:15 +02:00 committed by Linus Groh
parent 7dfecbee44
commit 2e4ec891da
Notes: sideshowbarker 2024-07-18 04:16:34 +09:00 
Author: https://github.com/BenWiederhake
Commit: https://github.com/SerenityOS/serenity/commit/2e4ec891dad
Pull-request: https://github.com/SerenityOS/serenity/pull/9961
Reviewed-by: https://github.com/linusg ✅
4 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Tests/LibSQL/TestSqlStatementExecution.cpp
View file

@ -24,7 +24,7 @@ RefPtr<SQL::SQLResult> execute(NonnullRefPtr<SQL::Database> database, String con
auto statement = parser.next_statement();
EXPECT(!parser.has_errors());
if (parser.has_errors()) {
outln(parser.errors()[0].to_string());
outln("{}", parser.errors()[0].to_string());
}
SQL::AST::ExecutionContext context { database };
auto result = statement->execute(context);

2
Userland/Libraries/LibCore/ArgsParser.cpp
View file

@ -201,7 +201,7 @@ void ArgsParser::print_usage(FILE* file, const char* argv0)
if (m_general_help != nullptr && m_general_help[0] != '\0') {
outln(file, "\nDescription:");
outln(file, m_general_help);
outln(file, "{}", m_general_help);
}
if (!m_options.is_empty())

2
Userland/Utilities/mktemp.cpp
View file

@ -110,7 +110,7 @@ int main(int argc, char** argv)
return 1;
}
outln(final_path);
outln("{}", final_path);
free(final_path);
return 0;
}

2
Userland/Utilities/sql.cpp
View file

@ -191,7 +191,7 @@ int main()
sql_client->on_next_result = [&](int, Vector<String> const& row) {
StringBuilder builder;
builder.join(", ", row);
outln(builder.build());
outln("{}", builder.build());
};
sql_client->on_results_exhausted = [&](int, int total_rows) {