beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

AK: Reimplement all_of in terms of find_if

Browse source 
Problem:
- Now that a generic free-function form of `find_if` is implemented
  the code in `all_of` is redundant.

Solution:
- Follow the "don't repeat yourself" mantra and make the code DRY by
  implementing `all_of` in terms of `find_if`.
- One tricky part is that since captures are not permitted in
  `constexpr` lambdas, the lambda created to negate the predicate
  needs to be created by a function which does not capture and takes
  the predicate at run-time instead. This allows `all_of` to continue
  to work in a `constexpr` context.
This commit is contained in:
Lenny Maiorani 2021-06-24 10:24:13 -06:00 committed by Ali Mohammad Pur
parent 497a9afaaf
commit 2cf4781d14
Notes: sideshowbarker 2024-07-18 08:24:49 +09:00 
Author: https://github.com/ldm5180
Commit: https://github.com/SerenityOS/serenity/commit/2cf4781d147
Pull-request: https://github.com/SerenityOS/serenity/pull/8972
Reviewed-by: https://github.com/alimpfard
1 changed files with 6 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
AK/AllOf.h
View file

@ -7,6 +7,7 @@
#pragma once
#include <AK/Concepts.h>
#include <AK/Find.h>
#include <AK/Iterator.h>
namespace AK {
@ -17,22 +18,16 @@ constexpr bool all_of(
TEndIterator const& end,
auto const& predicate)
{
for (auto iter = begin; iter != end; ++iter) {
if (!predicate(*iter)) {
return false;
}
}
return true;
constexpr auto negated_predicate = [](auto const& pred) {
return [&](auto const& elem) { return !pred(elem); };
};
return !(find_if(begin, end, negated_predicate(predicate)) != end);
}
template<IterableContainer Container>
constexpr bool all_of(Container&& container, auto const& predicate)
{
for (auto&& entry : container) {
if (!predicate(entry))
return false;
}
return true;
return all_of(container.begin(), container.end(), predicate);
}
}