beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 00:50:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

AK+LibIDL: Put IDL dbgln statement behind a debug flag

Browse source 
This is a bit spammy now that we are performing some overload resolution
at build time. The fallback to an interface has generally worked fine on
the types it warns about (BufferSource, Module, etc.) so let's not warn
about it for every build.
This commit is contained in:
Timothy Flynn 2023-11-15 07:12:06 -05:00 committed by Andreas Kling
parent e1092aed3c
commit 2c1bbf5a99
Notes: sideshowbarker 2024-07-17 03:35:16 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/2c1bbf5a99
Pull-request: https://github.com/SerenityOS/serenity/pull/21944
4 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
AK/Debug.h.in
View file

@ -210,6 +210,10 @@
# cmakedefine01 ICO_DEBUG
#endif
#ifndef IDL_DEBUG
# cmakedefine01 IDL_DEBUG
#endif
#ifndef ILBM_DEBUG
# cmakedefine01 ILBM_DEBUG
#endif

1
Meta/CMake/all_the_debug_macros.cmake
View file

@ -73,6 +73,7 @@ set(HTTPJOB_DEBUG ON)
set(HUNKS_DEBUG ON)
set(ICMP_DEBUG ON)
set(ICO_DEBUG ON)
set(IDL_DEBUG ON)
set(ILBM_DEBUG ON)
set(IMAGE_DECODER_DEBUG ON)
set(IMAGE_LOADER_DEBUG ON)

1
Meta/gn/secondary/AK/BUILD.gn
View file

@ -288,6 +288,7 @@ write_cmake_config("ak_debug_gen") {
"HTTPJOB_DEBUG=",
"HUNKS_DEBUG=",
"ICO_DEBUG=",
"IDL_DEBUG=",
"ILBM_DEBUG=",
"IMAGE_DECODER_DEBUG=",
"IMAGE_LOADER_DEBUG=",

3
Userland/Libraries/LibIDL/Types.cpp
View file

@ -5,6 +5,7 @@
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <AK/Debug.h>
#include <LibIDL/Types.h>
namespace IDL {
@ -175,7 +176,7 @@ bool Type::is_distinguishable_from(IDL::Interface const& interface, IDL::Type co
return DistinguishabilityCategory::SequenceLike;
// FIXME: For lack of a better way of determining if something is an interface type, this just assumes anything we don't recognise is one.
dbgln("Unable to determine category for type named '{}', assuming it's an interface type.", type.name());
dbgln_if(IDL_DEBUG, "Unable to determine category for type named '{}', assuming it's an interface type.", type.name());
return DistinguishabilityCategory::InterfaceLike;
};