beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

HackStudio: Use Web::PageView::load_html() for the documentation popup

Browse source 
Also simplify the way we change the background color a little bit.
This commit is contained in:
Andreas Kling 2020-06-21 21:53:10 +02:00
parent 1f97897b40
commit 2ba9e9b9c9
Notes: sideshowbarker 2024-07-19 05:27:49 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/2ba9e9b9c98
1 changed files with 4 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
DevTools/HackStudio/Editor.cpp
View file

@ -41,7 +41,6 @@
#include <LibWeb/DOM/HTMLHeadElement.h>
#include <LibWeb/DOM/Text.h>
#include <LibWeb/PageView.h>
#include <LibWeb/Parser/HTMLParser.h>
// #define EDITOR_DEBUG
@ -173,22 +172,12 @@ void Editor::show_documentation_tooltip_if_available(const String& hovered_token
auto html_text = man_document->render_to_html();
auto html_document = Web::parse_html_document(html_text);
if (!html_document) {
dbg() << "failed to parse HTML";
return;
m_documentation_page_view->load_html(html_text, {});
if (auto* document = m_documentation_page_view->document()) {
const_cast<Web::HTMLElement*>(document->body())->set_attribute(Web::HTML::AttributeNames::style, "background-color: #dac7b5;");
}
// FIXME: LibWeb needs a friendlier DOM manipulation API. Something like innerHTML :^)
auto style_element = create_element(*html_document, "style");
style_element->append_child(adopt(*new Web::Text(*html_document, "body { background-color: #dac7b5; }")));
// FIXME: This const_cast should not be necessary.
auto* head_element = const_cast<Web::HTMLHeadElement*>(html_document->head());
ASSERT(head_element);
head_element->append_child(style_element);
m_documentation_page_view->set_document(html_document);
m_documentation_tooltip_window->move_to(screen_location.translated(4, 4));
m_documentation_tooltip_window->show();