beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

AK: Fix off-by-one in Vector::prepend(Vector&&).

Browse source 
Caught by valgrind's uninitialized access checks on the Vector unit test.
Yay for finding bugs with valgrind on the unit tests! :^)
This commit is contained in:
Andreas Kling 2019-07-21 12:51:54 +02:00
parent 20c6edc976
commit 29a62558c4
Notes: sideshowbarker 2024-07-19 13:06:22 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/29a62558c4f
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
AK/Vector.h
View file

@ -362,7 +362,7 @@ public:
auto other_size = other.size();
grow_capacity(size() + other_size);
for (int i = size() + other_size - 1; i > other.size(); --i) {
for (int i = size() + other_size - 1; i >= other.size(); --i) {
new (slot(i)) T(move(at(i - other_size)));
at(i - other_size).~T();
}