From 28927d6a0f0a4179b8f8063a2b55429e394a4455 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Sun, 9 Jun 2024 22:07:42 -0400 Subject: [PATCH] CI: Release only arm64 JS artifacts on macOS for now Turns out vcpkg does not yet support Universal binaries. While they are working on it, lets produce arm64 binaries only for now to unblock the pipeline. --- .github/workflows/serenity-js-artifacts.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/serenity-js-artifacts.yml b/.github/workflows/serenity-js-artifacts.yml index 58588bc882b..dce70d3d94a 100644 --- a/.github/workflows/serenity-js-artifacts.yml +++ b/.github/workflows/serenity-js-artifacts.yml @@ -56,12 +56,14 @@ jobs: env: CCACHE_DIR: ${{ env.SERENITY_CCACHE_DIR }} + # FIXME: Add the following flag back when vcpkg supports Universal binaries: + # -DCMAKE_OSX_ARCHITECTURES="x86_64;arm64" + # + # See: https://github.com/microsoft/vcpkg/discussions/19454 - name: Create build directory macOS run: | - # Note: We are using Apple Clang to create Universal binary cmake --preset CI -B Build \ -DCMAKE_BUILD_TYPE=Release \ - -DCMAKE_OSX_ARCHITECTURES="x86_64;arm64" \ -DCMAKE_OSX_DEPLOYMENT_TARGET="11.0" if: ${{ matrix.os == 'macos-14' }} env: