beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Ladybird: Return a reference to the mach server name

Browse source 
Rather than a copy, return a reference so that it's a bit safer to use
the result as a StringView within the calling scope.
This commit is contained in:
Timothy Flynn 2024-04-22 12:56:02 -04:00 committed by Andrew Kaster
parent c7ef8530bf
commit 278fc8e57f
Notes: sideshowbarker 2024-07-17 04:01:41 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/278fc8e57f
Pull-request: https://github.com/SerenityOS/serenity/pull/24074
Reviewed-by: https://github.com/ADKaster ✅
2 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Ladybird/Utilities.cpp
View file

@ -26,10 +26,14 @@ constexpr auto libexec_path = "libexec"sv;
ByteString s_serenity_resource_root;
Optional<ByteString> s_mach_server_name;
Optional<ByteString> mach_server_name()
Optional<ByteString const&> mach_server_name()
{
return s_mach_server_name;
if (s_mach_server_name.has_value())
return *s_mach_server_name;
return {};
}
void set_mach_server_name(ByteString name)
{
s_mach_server_name = move(name);

2
Ladybird/Utilities.h
View file

@ -17,5 +17,5 @@ ErrorOr<ByteString> application_directory();
ErrorOr<Vector<ByteString>> get_paths_for_helper_process(StringView process_name);
extern ByteString s_serenity_resource_root;
Optional<ByteString> mach_server_name();
Optional<ByteString const&> mach_server_name();
void set_mach_server_name(ByteString name);