beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-24 16:40:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

AK: Pass (Deprecated)FlyString::is_one_of arguments by reference

Browse source 
This avoid unnecessairy reference counting.
This commit is contained in:
Jonne Ransijn 2024-10-27 00:37:14 +02:00 committed by Tim Flynn
parent 7f3269fb02
commit 22a66bb1c2
Notes: github-actions[bot] 2024-10-27 16:03:58 +00:00 
Author: https://github.com/yyny
Commit: https://github.com/LadybirdBrowser/ladybird/commit/22a66bb1c2a
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1987
Reviewed-by: https://github.com/Hendiadyoin1
Reviewed-by: https://github.com/trflynn89
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
AK/DeprecatedFlyString.h
View file

@ -84,7 +84,7 @@ public:
static void did_destroy_impl(Badge<StringImpl>, StringImpl&);
template<typename... Ts>
[[nodiscard]] ALWAYS_INLINE constexpr bool is_one_of(Ts... strings) const
[[nodiscard]] ALWAYS_INLINE constexpr bool is_one_of(Ts&&... strings) const
{
return (... || this->operator==(forward<Ts>(strings)));
}

2
AK/FlyString.h
View file

@ -74,7 +74,7 @@ public:
[[nodiscard]] bool ends_with_bytes(StringView, CaseSensitivity = CaseSensitivity::CaseSensitive) const;
template<typename... Ts>
[[nodiscard]] ALWAYS_INLINE constexpr bool is_one_of(Ts... strings) const
[[nodiscard]] ALWAYS_INLINE constexpr bool is_one_of(Ts&&... strings) const
{
return (... || this->operator==(forward<Ts>(strings)));
}