beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-27 01:50:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

GLabel: Make set_icon() take a GraphicsBitmap*.

Browse source 
Taking a RefPtr<GraphicsBitmap>&& was just making things unnecessarily
complicated for clients, and didn't actually improve anything.
This commit is contained in:
Andreas Kling 2019-07-11 15:52:15 +02:00
parent 992272761c
commit 22528d8db3
Notes: sideshowbarker 2024-07-19 13:19:46 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/22528d8db34
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibGUI/GLabel.cpp
View file

@ -17,9 +17,9 @@ GLabel::~GLabel()
{ {
} }
void GLabel::set_icon(RefPtr<GraphicsBitmap>&& icon) void GLabel::set_icon(GraphicsBitmap* icon)
{ {
m_icon = move(icon); m_icon = icon;
} }
void GLabel::set_text(const StringView& text) void GLabel::set_text(const StringView& text)

2
Libraries/LibGUI/GLabel.h
View file

@ -14,7 +14,7 @@ public:
String text() const { return m_text; } String text() const { return m_text; }
void set_text(const StringView&); void set_text(const StringView&);
void set_icon(RefPtr<GraphicsBitmap>&&); void set_icon(GraphicsBitmap*);
const GraphicsBitmap* icon() const { return m_icon.ptr(); } const GraphicsBitmap* icon() const { return m_icon.ptr(); }
GraphicsBitmap* icon() { return m_icon.ptr(); } GraphicsBitmap* icon() { return m_icon.ptr(); }