beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb/CSS: Require that tag-name simple selectors go first

Browse source 
This fixes 1 subtest.
This commit is contained in:
Sam Atkins 2024-11-08 20:14:46 +00:00 committed by Andreas Kling
parent a0403ac427
commit 219346011b
Notes: github-actions[bot] 2024-11-09 13:30:31 +00:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/LadybirdBrowser/ladybird/commit/219346011b5
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2240
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Tests/LibWeb/Text/expected/wpt-import/css/css-nesting/parsing.txt
View file

@ -6,8 +6,7 @@ Rerun
Found 32 tests
31 Pass
1 Fail
32 Pass
Details
Result Test Name MessagePass .foo { & { color: green; }}
Pass .foo { &.bar { color: green; }}
@ -26,7 +25,7 @@ Pass .foo { &:is(.bar, .baz) { color: green; }}
Pass .foo { :is(.bar, &.baz) { color: green; }}
Pass .foo { &:is(.bar, &.baz) { color: green; }}
Pass .foo { div& { color: green; }}
Fail INVALID: .foo { &div { color: green; }}
Pass INVALID: .foo { &div { color: green; }}
Pass .foo { .class& { color: green; }}
Pass .foo { &.class { color: green; }}
Pass .foo { [attr]& { color: green; }}

4
Userland/Libraries/LibWeb/CSS/Parser/SelectorParsing.cpp
View file

@ -127,6 +127,10 @@ Parser::ParseErrorOr<Optional<Selector::CompoundSelector>> Parser::parse_compoun
auto component = TRY(parse_simple_selector(tokens));
if (!component.has_value())
break;
if (component->type == Selector::SimpleSelector::Type::TagName && !simple_selectors.is_empty()) {
// Tag-name selectors can only go at the beginning of a compound selector.
return ParseError::SyntaxError;
}
simple_selectors.append(component.release_value());
}