beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 01:20:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

JSSpecCompiler: Rename SpecFunction to SpecificationFunction

Browse source 
Over time, I converged on not abbreviating "specification". But this
class (and SpecParsingStep) predated the decision.
This commit is contained in:
Dan Klishch 2024-03-07 23:29:43 -05:00 committed by Andrew Kaster
parent 7ea2138b6c
commit 211d20d389
Notes: sideshowbarker 2024-07-17 02:55:44 +09:00 
Author: https://github.com/DanShaders
Commit: https://github.com/SerenityOS/serenity/commit/211d20d389
Pull-request: https://github.com/SerenityOS/serenity/pull/23522
Reviewed-by: https://github.com/ADKaster ✅
5 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Meta/Lagom/Tools/CodeGenerators/JSSpecCompiler/CMakeLists.txt
View file

@ -15,9 +15,9 @@ set(SOURCES
Parser/AlgorithmStepList.cpp
Parser/CppASTConverter.cpp
Parser/Lexer.cpp
Parser/SpecFunction.cpp
Parser/Specification.cpp
Parser/SpecificationClause.cpp
Parser/SpecificationFunction.cpp
Parser/SpecificationParsingContext.cpp
Parser/SpecParsingStep.cpp
Parser/TextParser.cpp

2
Meta/Lagom/Tools/CodeGenerators/JSSpecCompiler/Forward.h
View file

@ -65,7 +65,7 @@ class SpecificationParsingContext;
class AlgorithmStep;
class AlgorithmStepList;
class Algorithm;
class SpecFunction;
class SpecificationFunction;
class SpecificationClause;
class Specification;

4
Meta/Lagom/Tools/CodeGenerators/JSSpecCompiler/Parser/SpecParser.h
View file

@ -132,9 +132,9 @@ private:
Vector<NonnullOwnPtr<SpecificationClause>> m_subclauses;
};
class SpecFunction : public SpecificationClause {
class SpecificationFunction : public SpecificationClause {
public:
SpecFunction(SpecificationClause&& clause)
SpecificationFunction(SpecificationClause&& clause)
: SpecificationClause(move(clause))
{
}

2
Meta/Lagom/Tools/CodeGenerators/JSSpecCompiler/Parser/SpecificationClause.cpp
View file

@ -25,7 +25,7 @@ NonnullOwnPtr<SpecificationClause> SpecificationClause::create(SpecificationPars
result = make<SpecificationClause>(move(specification_clause));
},
[&](OneOf<ClauseHeader::AbstractOperation, ClauseHeader::Accessor, ClauseHeader::Method> auto const&) {
result = make<SpecFunction>(move(specification_clause));
result = make<SpecificationFunction>(move(specification_clause));
});
if (!result->post_initialize(element))

4
Meta/Lagom/Tools/CodeGenerators/JSSpecCompiler/Parser/SpecFunction.cpp → Meta/Lagom/Tools/CodeGenerators/JSSpecCompiler/Parser/SpecificationFunction.cpp
View file

@ -10,7 +10,7 @@
namespace JSSpecCompiler {
bool SpecFunction::post_initialize(XML::Node const* element)
bool SpecificationFunction::post_initialize(XML::Node const* element)
{
VERIFY(element->as_element().name == tag_emu_clause);
@ -84,7 +84,7 @@ bool SpecFunction::post_initialize(XML::Node const* element)
}
}
void SpecFunction::do_collect(TranslationUnitRef translation_unit)
void SpecificationFunction::do_collect(TranslationUnitRef translation_unit)
{
translation_unit->adopt_function(make_ref_counted<FunctionDefinition>(m_name, m_algorithm.tree(), move(m_arguments)));
}