beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 23:50:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Browser: Set the console's interpreter when a tab's document changes

Browse source 
Previously, once a console was opened for a tab, its interpreter
would never change, leaving it with a stale interpreter. Now, when
the tab's HtmlView loads a new document, the console will receive
that document's interpreter.
This commit is contained in:
FalseHonesty 2020-05-23 13:03:31 -04:00 committed by Andreas Kling
parent 51e79a2bbc
commit 20df82c983
Notes: sideshowbarker 2024-07-19 06:11:39 +09:00 
Author: https://github.com/FalseHonesty
Commit: https://github.com/SerenityOS/serenity/commit/20df82c9830
Pull-request: https://github.com/SerenityOS/serenity/pull/2349
Reviewed-by: https://github.com/Dexesttp
Reviewed-by: https://github.com/linusg
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Applications/Browser/Tab.cpp
View file

@ -206,6 +206,13 @@ Tab::Tab()
on_favicon_change(icon);
};
m_html_widget->on_set_document = [this](auto* document) {
if (document && m_console_window) {
auto* console_widget = static_cast<ConsoleWidget*>(m_console_window->main_widget());
console_widget->set_interpreter(document->interpreter().make_weak_ptr());
}
};
auto focus_location_box_action = GUI::Action::create(
"Focus location box", { Mod_Ctrl, Key_L }, [this](auto&) {
m_location_box->select_all();