beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 23:50:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Use Element::id() when deciding whether to update SVG use trees

Browse source
This commit is contained in:
Andreas Kling 2023-11-02 15:01:06 +01:00
parent 65787fffe4
commit 204c46f097
Notes: sideshowbarker 2024-07-16 22:17:03 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/204c46f097
Pull-request: https://github.com/SerenityOS/serenity/pull/21746
Reviewed-by: https://github.com/AtkinsSJ ✅
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/SVG/SVGElement.cpp
View file

@ -61,7 +61,7 @@ void SVGElement::update_use_elements_that_reference_this()
// If this element is in a shadow root, it already represents a clone and is not itself referenced.
|| is<DOM::ShadowRoot>(this->root())
// If this does not have an id it cannot be referenced, no point in searching the entire DOM tree.
|| !this->has_attribute(HTML::AttributeNames::id)
|| !id().has_value()
// An unconnected node cannot have valid references.
// This also prevents searches for elements that are in the process of being constructed - as clones.
|| !this->is_connected()
@ -87,7 +87,7 @@ void SVGElement::removed_from(Node* parent)
void SVGElement::remove_from_use_element_that_reference_this()
{
if (is<SVGUseElement>(this) || !this->has_attribute(HTML::AttributeNames::id)) {
if (is<SVGUseElement>(this) || !id().has_value()) {
return;
}