beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Meta: Run all lint checks and report failures together

Browse source 
Problem:
- The first lint check that fails results in all subsequent checks not
  being run.

Solution:
- Run all the lint checks aggregating the number of failures.
- Return a non-0 exit code if any have failed.
This commit is contained in:
Lenny Maiorani 2020-12-24 10:13:24 -07:00 committed by Andreas Kling
parent 200c7572b7
commit 1db5276c05
Notes: sideshowbarker 2024-07-19 00:37:54 +09:00 
Author: https://github.com/ldm5180
Commit: https://github.com/SerenityOS/serenity/commit/1db5276c051
Pull-request: https://github.com/SerenityOS/serenity/pull/4525
1 changed files with 25 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
Meta/lint-ci.sh
View file

@ -5,20 +5,39 @@ set -e
script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P)
cd "${script_path}/.." || exit 1
RED='\033[0;31m'
GREEN='\033[0;32m'
NC='\033[0m' # No Color
FAILURES=0
set +e
for cmd in \
Meta/check-ak-test-files.sh \
Meta/check-debug-flags.sh \
Meta/check-style.sh \
Meta/lint-executable-resources.sh \
Meta/lint-ipc-ids.sh \
Meta/lint-shell-scripts.sh ; do
echo "Running $cmd"
"$cmd"
echo "$cmd successful"
Meta/lint-shell-scripts.sh; do
echo "Running $cmd... "
if $cmd; then
echo -e "[${GREEN}OK${NC}]: ${cmd}"
else
echo -e "[${RED}FAIL${NC}]: ${cmd}"
((FAILURES+=1))
fi
done
echo "Running Meta/lint-clang-format.sh"
Meta/lint-clang-format.sh --overwrite-inplace && git diff --exit-code
echo "Meta/lint-clang-format.sh successful"
if Meta/lint-clang-format.sh --overwrite-inplace && git diff --exit-code; then
echo -e "[${GREEN}OK${NC}]: Meta/lint-clang-format.sh"
else
echo -e "[${RED}FAIL${NC}]: Meta/lint-clang-format.sh"
((FAILURES+=1))
fi
echo "(Not running lint-missing-resources.sh due to high false-positive rate.)"
echo "(Also look out for check-symbols.sh, which can only be executed after the build!)"
exit ${FAILURES}