beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 09:30:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibJS: Add the Object.prototype.__lookup{Getter, Setter}__ methods

Browse source 
These are a part of the Annex B extension of the specification.
This commit is contained in:
Idan Horowitz 2021-06-17 14:15:14 +03:00 committed by Linus Groh
parent f98c0ca528
commit 1cf5663e38
Notes: sideshowbarker 2024-07-18 12:08:11 +09:00 
Author: https://github.com/IdanHo
Commit: https://github.com/SerenityOS/serenity/commit/1cf5663e38f
Pull-request: https://github.com/SerenityOS/serenity/pull/8110
Reviewed-by: https://github.com/linusg
3 changed files with 56 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h
View file

@ -15,6 +15,8 @@ namespace JS {
P(__proto__) \
P(__defineGetter__) \
P(__defineSetter__) \
P(__lookupGetter__) \
P(__lookupSetter__) \
P(BYTES_PER_ELEMENT) \
P(BigInt) \
P(Boolean) \

52
Userland/Libraries/LibJS/Runtime/ObjectPrototype.cpp
View file

@ -40,6 +40,8 @@ void ObjectPrototype::initialize(GlobalObject& global_object)
// Annex B
define_native_function(vm.names.__defineGetter__, define_getter, 2, attr);
define_native_function(vm.names.__defineSetter__, define_setter, 2, attr);
define_native_function(vm.names.__lookupGetter__, lookup_getter, 1, attr);
define_native_function(vm.names.__lookupSetter__, lookup_setter, 1, attr);
define_native_accessor(vm.names.__proto__, proto_getter, proto_setter, Attribute::Configurable);
}
@ -214,6 +216,56 @@ JS_DEFINE_NATIVE_FUNCTION(ObjectPrototype::define_setter)
return js_undefined();
}
// B.2.2.4 Object.prototype.__lookupGetter__ ( P ), https://tc39.es/ecma262/#sec-object.prototype.__lookupGetter__
JS_DEFINE_NATIVE_FUNCTION(ObjectPrototype::lookup_getter)
{
auto object = vm.this_value(global_object).to_object(global_object);
if (vm.exception())
return {};
auto key = vm.argument(0).to_property_key(global_object);
if (vm.exception())
return {};
while (object) {
auto desc = object->get_own_property_descriptor(key);
if (vm.exception())
return {};
if (desc.has_value())
return desc->getter ?: js_undefined();
object = object->prototype();
if (vm.exception())
return {};
}
return js_undefined();
}
// B.2.2.5 Object.prototype.__lookupSetter__ ( P ), https://tc39.es/ecma262/#sec-object.prototype.__lookupSetter__
JS_DEFINE_NATIVE_FUNCTION(ObjectPrototype::lookup_setter)
{
auto* object = vm.this_value(global_object).to_object(global_object);
if (vm.exception())
return {};
auto key = vm.argument(0).to_property_key(global_object);
if (vm.exception())
return {};
while (object) {
auto desc = object->get_own_property_descriptor(key);
if (vm.exception())
return {};
if (desc.has_value())
return desc->setter ?: js_undefined();
object = object->prototype();
if (vm.exception())
return {};
}
return js_undefined();
}
// B.2.2.1.1 get Object.prototype.__proto__, https://tc39.es/ecma262/#sec-get-object.prototype.__proto__
JS_DEFINE_NATIVE_FUNCTION(ObjectPrototype::proto_getter)
{

2
Userland/Libraries/LibJS/Runtime/ObjectPrototype.h
View file

@ -29,6 +29,8 @@ private:
JS_DECLARE_NATIVE_FUNCTION(is_prototype_of);
JS_DECLARE_NATIVE_FUNCTION(define_getter);
JS_DECLARE_NATIVE_FUNCTION(define_setter);
JS_DECLARE_NATIVE_FUNCTION(lookup_getter);
JS_DECLARE_NATIVE_FUNCTION(lookup_setter);
JS_DECLARE_NATIVE_FUNCTION(proto_getter);
JS_DECLARE_NATIVE_FUNCTION(proto_setter);
};