beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 09:30:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Remove unneeded iteration filter on LiveNodeList

Browse source 
Since all items of the subtree are Nodes, the "of type" condition was
always true. This triggers a warning on Lagom builds.
This commit is contained in:
DexesTTP 2022-04-03 00:48:37 +02:00 committed by Linus Groh
parent 56d018f6b5
commit 1af7bfb3a6
Notes: sideshowbarker 2024-07-17 11:14:46 +09:00 
Author: https://github.com/Dexesttp
Commit: https://github.com/SerenityOS/serenity/commit/1af7bfb3a6
Pull-request: https://github.com/SerenityOS/serenity/pull/13922
Reviewed-by: https://github.com/krkk
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/DOM/LiveNodeList.cpp
View file

@ -18,7 +18,7 @@ LiveNodeList::LiveNodeList(Node& root, Function<bool(Node const&)> filter)
NonnullRefPtrVector<Node> LiveNodeList::collection() const
{
NonnullRefPtrVector<Node> nodes;
m_root->for_each_in_inclusive_subtree_of_type<Node>([&](auto& node) {
m_root->for_each_in_inclusive_subtree([&](auto& node) {
if (m_filter(node))
nodes.append(node);