beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 23:50:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibGUI: Add ability to watch file Nodes when traversing them

Browse source 
This makes it possible to also capture changes to files, not just
directories. We only need to watch for metadata changes on files
because child created/deleted is not possible with nodes other than
directories, and deletion will be captured by the file's parent
This commit is contained in:
Adam Harald Jørgensen 2023-10-17 16:29:18 +02:00 committed by Andreas Kling
parent 4d3c06ffe3
commit 1ab318b391
Notes: sideshowbarker 2024-07-17 06:40:35 +09:00 
Author: https://github.com/adamjoer
Commit: https://github.com/SerenityOS/serenity/commit/1ab318b391
Pull-request: https://github.com/SerenityOS/serenity/pull/21502
1 changed files with 19 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
Userland/Libraries/LibGUI/FileSystemModel.cpp
View file

@ -82,7 +82,7 @@ bool FileSystemModel::Node::fetch_data(DeprecatedString const& full_path, bool i
void FileSystemModel::Node::traverse_if_needed()
{
if (!is_directory() || m_has_traversed)
if (m_has_traversed)
return;
m_has_traversed = true;
@ -96,9 +96,24 @@ void FileSystemModel::Node::traverse_if_needed()
return;
}
auto full_path = this->full_path();
if (!is_directory()) {
if (m_model.m_mode != DirectoriesOnly && !m_model.m_file_watcher->is_watching(full_path)) {
// We are not already watching this file, watch it
auto result = m_model.m_file_watcher->add_watch(full_path, Core::FileWatcherEvent::Type::MetadataModified);
if (result.is_error()) {
dbgln("Couldn't watch '{}': {}", full_path, result.error());
} else if (!result.value()) {
dbgln("Couldn't watch '{}', probably already watching", full_path);
}
}
return;
}
total_size = 0;
auto full_path = this->full_path();
Core::DirIterator di(full_path, m_model.should_show_dotfiles() ? Core::DirIterator::SkipParentAndBaseDir : Core::DirIterator::SkipDots);
if (di.has_error()) {
auto error = di.error();
@ -144,7 +159,7 @@ void FileSystemModel::Node::traverse_if_needed()
m_children.extend(move(file_children));
if (!m_model.m_file_watcher->is_watching(full_path)) {
// We are not already watching this file, watch it
// We are not already watching this directory, watch it
auto result = m_model.m_file_watcher->add_watch(full_path,
Core::FileWatcherEvent::Type::MetadataModified
| Core::FileWatcherEvent::Type::ChildCreated
@ -153,7 +168,7 @@ void FileSystemModel::Node::traverse_if_needed()
if (result.is_error()) {
dbgln("Couldn't watch '{}': {}", full_path, result.error());
} else if (result.value() == false) {
} else if (!result.value()) {
dbgln("Couldn't watch '{}', probably already watching", full_path);
}
}