beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibJS: Return specified object from Object.setPrototypeOf()

Browse source 
We were leaking an empty value.
This commit is contained in:
Linus Groh 2020-06-02 11:39:24 +01:00 committed by Andreas Kling
parent a60a5bc70a
commit 1a64bdd80c
Notes: sideshowbarker 2024-07-19 05:53:52 +09:00 
Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/1a64bdd80c8
Pull-request: https://github.com/SerenityOS/serenity/pull/2478
2 changed files with 13 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibJS/Runtime/ObjectConstructor.cpp
View file

@ -103,7 +103,7 @@ Value ObjectConstructor::set_prototype_of(Interpreter& interpreter)
if (interpreter.exception()) if (interpreter.exception())
return {}; return {};
object->set_prototype(&const_cast<Object&>(interpreter.argument(1).as_object())); object->set_prototype(&const_cast<Object&>(interpreter.argument(1).as_object()));
return {}; return object;
} }
Value ObjectConstructor::is_extensible(Interpreter& interpreter) Value ObjectConstructor::is_extensible(Interpreter& interpreter)

12
Libraries/LibJS/Tests/Object.setPrototypeOf.js Normal file
View file

@ -0,0 +1,12 @@
load("test-common.js");
try {
assert(Object.setPrototypeOf.length === 2);
o = {};
assert(Object.setPrototypeOf(o, {}) === o);
console.log("PASS");
} catch (e) {
console.log("FAIL: " + e);
}