beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 00:50:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Kernel/riscv64: Only enable interrupts in trap handler if they were on

Browse source 
Always enabling interrupts is in hindsight obviously a bug, as trapping
code that has interrupts disabled very likely expects that they stay
disabled.
This commit is contained in:
Sönke Holz 2024-02-28 15:54:26 +01:00 committed by Andrew Kaster
parent 6a223c6210
commit 1a312f4265
Notes: sideshowbarker 2024-07-17 06:40:35 +09:00 
Author: https://github.com/spholz
Commit: https://github.com/SerenityOS/serenity/commit/1a312f4265
Pull-request: https://github.com/SerenityOS/serenity/pull/23387
Reviewed-by: https://github.com/ADKaster ✅
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Kernel/Arch/riscv64/Interrupts.cpp
View file

@ -60,7 +60,8 @@ extern "C" void trap_handler(TrapFrame& trap_frame)
// Exception
Processor::current().enter_trap(trap_frame, false);
Processor::enable_interrupts();
if (trap_frame.regs->sstatus.SPIE == 1)
Processor::enable_interrupts();
using enum RISCV64::CSR::SCAUSE;
switch (scause) {