beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

FuzzTar+tar: Advance the stream before continuing

Browse source 
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=53733
This bug was caused by a regression introduced in c88d8a2.
This commit is contained in:
implicitfield 2022-11-25 16:30:45 +02:00 committed by Andreas Kling
parent 73e87d694e
commit 19e6befddc
Notes: sideshowbarker 2024-07-17 11:29:41 +09:00 
Author: https://github.com/implicitfield
Commit: https://github.com/SerenityOS/serenity/commit/19e6befddc
Pull-request: https://github.com/SerenityOS/serenity/pull/16181
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Meta/Lagom/Fuzzers/FuzzTar.cpp
View file

@ -19,8 +19,12 @@ extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size)
while (!tar_stream.finished()) {
auto const& header = tar_stream.header();
if (!header.content_is_like_extended_header())
if (!header.content_is_like_extended_header()) {
if (tar_stream.advance().is_error())
return 0;
else
continue;
}
switch (header.type_flag()) {
case Archive::TarFileType::GlobalExtendedHeader:

2
Userland/Utilities/tar.cpp
View file

@ -124,6 +124,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
VERIFY_NOT_REACHED();
}
TRY(tar_stream.advance());
continue;
}
@ -141,6 +142,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
long_name.append(reinterpret_cast<char*>(buffer.data()), bytes_read);
local_overrides.set("path", long_name.to_string());
TRY(tar_stream.advance());
continue;
}
default: