beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 01:20:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibAccelGfx+LibWeb: Discard painting of commands outside of viewport

Browse source
This commit is contained in:
Aliaksandr Kalenik 2023-11-26 16:29:40 +01:00 committed by Andreas Kling
parent c68a9b2cfe
commit 17fb82d49b
Notes: sideshowbarker 2024-07-17 05:21:12 +09:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/SerenityOS/serenity/commit/17fb82d49b
Pull-request: https://github.com/SerenityOS/serenity/pull/22060
3 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibAccelGfx/Painter.cpp
View file

@ -550,11 +550,13 @@ void Painter::restore()
void Painter::set_clip_rect(Gfx::IntRect rect) void Painter::set_clip_rect(Gfx::IntRect rect)
{ {
state().clip_rect = transform().map(rect);
GL::enable_scissor_test(transform().map(rect)); GL::enable_scissor_test(transform().map(rect));
} }
void Painter::clear_clip_rect() void Painter::clear_clip_rect()
{ {
state().clip_rect = { { 0, 0 }, m_target_canvas->size() };
GL::disable_scissor_test(); GL::disable_scissor_test();
} }
@ -569,6 +571,7 @@ void Painter::set_target_canvas(NonnullRefPtr<Canvas> canvas)
m_target_canvas = canvas; m_target_canvas = canvas;
canvas->bind(); canvas->bind();
GL::set_viewport({ 0, 0, canvas->size().width(), canvas->size().height() }); GL::set_viewport({ 0, 0, canvas->size().width(), canvas->size().height() });
state().clip_rect = { { 0, 0 }, m_target_canvas->size() };
} }
void Painter::flush(Gfx::Bitmap& bitmap) void Painter::flush(Gfx::Bitmap& bitmap)

3
Userland/Libraries/LibAccelGfx/Painter.h
View file

@ -43,6 +43,8 @@ public:
void set_transform(Gfx::AffineTransform const& transform) { state().transform = transform; } void set_transform(Gfx::AffineTransform const& transform) { state().transform = transform; }
void translate(Gfx::FloatPoint translation) { state().transform.translate(translation); } void translate(Gfx::FloatPoint translation) { state().transform.translate(translation); }
Gfx::IntRect const& clip_rect() const { return state().clip_rect; }
void fill_rect(Gfx::FloatRect, Gfx::Color); void fill_rect(Gfx::FloatRect, Gfx::Color);
void fill_rect(Gfx::IntRect, Gfx::Color); void fill_rect(Gfx::IntRect, Gfx::Color);
@ -88,6 +90,7 @@ private:
struct State { struct State {
Gfx::AffineTransform transform; Gfx::AffineTransform transform;
Gfx::IntRect clip_rect;
}; };
[[nodiscard]] State& state() { return m_state_stack.last(); } [[nodiscard]] State& state() { return m_state_stack.last(); }

6
Userland/Libraries/LibWeb/Painting/PaintingCommandExecutorGPU.cpp
View file

@ -306,10 +306,10 @@ CommandResult PaintingCommandExecutorGPU::paint_borders(DevicePixelRect const& b
return CommandResult::Continue; return CommandResult::Continue;
} }
bool PaintingCommandExecutorGPU::would_be_fully_clipped_by_painter(Gfx::IntRect) const bool PaintingCommandExecutorGPU::would_be_fully_clipped_by_painter(Gfx::IntRect rect) const
{ {
// FIXME auto translation = painter().transform().translation().to_type<int>();
return false; return !painter().clip_rect().intersects(rect.translated(translation));
} }
void PaintingCommandExecutorGPU::prepare_glyph_texture(HashMap<Gfx::Font const*, HashTable<u32>> const& unique_glyphs) void PaintingCommandExecutorGPU::prepare_glyph_texture(HashMap<Gfx::Font const*, HashTable<u32>> const& unique_glyphs)