beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibCrypto: Use ARM C Language Extensions (ACLE) for CRC32 intrinsics

Browse source 
The __builtin_arm_* intrinsics don't exist on all ARMv8 systems.
Use the standardized ACLE intrinsics, instead.
This commit is contained in:
Dennis Camera 2024-07-03 20:41:19 +02:00 committed by Daniel Bertalan
parent 61e616c974
commit 176e3ba16a
Notes: sideshowbarker 2024-07-17 05:21:12 +09:00 
Author: https://github.com/sideeffect42 🔰
Commit: https://github.com/LadybirdBrowser/ladybird/commit/176e3ba16a
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/397
Reviewed-by: https://github.com/BertalanD ✅
Reviewed-by: https://github.com/alimpfard ✅
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
Userland/Libraries/LibCrypto/Checksum/CRC32.cpp
View file

@ -10,10 +10,13 @@
#include <AK/Types.h>
#include <LibCrypto/Checksum/CRC32.h>
#ifdef __ARM_ACLE
# include <arm_acle.h>
#endif
namespace Crypto::Checksum {
#if defined(__aarch64__) && defined(__ARM_FEATURE_CRC32)
#if __ARM_ARCH >= 8 && defined(__ARM_FEATURE_CRC32) && defined(__ARM_ACLE)
void CRC32::update(ReadonlyBytes span)
{
// FIXME: Does this require runtime checking on rpi?
@ -23,21 +26,21 @@ void CRC32::update(ReadonlyBytes span)
size_t size = span.size();
while (size > 0 && (reinterpret_cast<FlatPtr>(data) & 7) != 0) {
m_state = __builtin_arm_crc32b(m_state, *data);
m_state = __crc32b(m_state, *data);
++data;
--size;
}
auto* data64 = reinterpret_cast<u64 const*>(data);
while (size >= 8) {
m_state = __builtin_arm_crc32d(m_state, *data64);
m_state = __crc32d(m_state, *data64);
++data64;
size -= 8;
}
data = reinterpret_cast<u8 const*>(data64);
while (size > 0) {
m_state = __builtin_arm_crc32b(m_state, *data);
m_state = __crc32b(m_state, *data);
++data;
--size;
}