LibJS: Implement Intl.Collator.supportedLocalesOf

This commit is contained in:
Timothy Flynn 2021-09-08 13:32:19 -04:00 committed by Linus Groh
parent 5a1eefcc1d
commit 17306078b5
Notes: sideshowbarker 2024-07-17 20:01:17 +09:00
3 changed files with 64 additions and 0 deletions

View file

@ -5,6 +5,7 @@
*/
#include <LibJS/Runtime/AbstractOperations.h>
#include <LibJS/Runtime/Array.h>
#include <LibJS/Runtime/GlobalObject.h>
#include <LibJS/Runtime/Intl/AbstractOperations.h>
#include <LibJS/Runtime/Intl/Collator.h>
@ -145,6 +146,9 @@ void CollatorConstructor::initialize(GlobalObject& global_object)
// 10.2.1 Intl.Collator.prototype, https://tc39.es/ecma402/#sec-intl.collator.prototype
define_direct_property(vm.names.prototype, global_object.intl_collator_prototype(), 0);
define_direct_property(vm.names.length, Value(0), Attribute::Configurable);
u8 attr = Attribute::Writable | Attribute::Configurable;
define_native_function(vm.names.supportedLocalesOf, supported_locales_of, 1, attr);
}
// 10.1.2 Intl.Collator ( [ locales [ , options ] ] ), https://tc39.es/ecma402/#sec-intl.collator
@ -176,4 +180,19 @@ ThrowCompletionOr<Object*> CollatorConstructor::construct(FunctionObject& new_ta
return TRY(initialize_collator(global_object, *collator, locales, options));
}
// 10.2.2 Intl.Collator.supportedLocalesOf ( locales [ , options ] ), https://tc39.es/ecma402/#sec-intl.collator.supportedlocalesof
JS_DEFINE_NATIVE_FUNCTION(CollatorConstructor::supported_locales_of)
{
auto locales = vm.argument(0);
auto options = vm.argument(1);
// 1. Let availableLocales be %Collator%.[[AvailableLocales]].
// 2. Let requestedLocales be ? CanonicalizeLocaleList(locales).
auto requested_locales = TRY(canonicalize_locale_list(global_object, locales));
// 3. Return ? SupportedLocales(availableLocales, requestedLocales, options).
return TRY(supported_locales(global_object, requested_locales, options));
}
}

View file

@ -23,6 +23,8 @@ public:
private:
virtual bool has_constructor() const override { return true; }
JS_DECLARE_NATIVE_FUNCTION(supported_locales_of);
};
}

View file

@ -0,0 +1,43 @@
describe("correct behavior", () => {
test("length is 1", () => {
expect(Intl.Collator.supportedLocalesOf).toHaveLength(1);
});
test("basic functionality", () => {
// prettier-ignore
const values = [
[[], []],
[undefined, []],
["en", ["en"]],
[new Intl.Locale("en"), ["en"]],
[["en"], ["en"]],
[["en", "en-gb", "en-us"], ["en", "en-GB", "en-US"]],
[["en", "de", "fr"], ["en", "de", "fr"]],
[["en-foobar"], ["en-foobar"]],
[["en-foobar-u-abc"], ["en-foobar-u-abc"]],
[["aa", "zz"], []],
[["en", "aa", "zz"], ["en"]],
];
for (const [input, expected] of values) {
expect(Intl.Collator.supportedLocalesOf(input)).toEqual(expected);
// "best fit" (implementation defined) just uses the same implementation as "lookup" at the moment
expect(Intl.Collator.supportedLocalesOf(input, { localeMatcher: "best fit" })).toEqual(
Intl.Collator.supportedLocalesOf(input, { localeMatcher: "lookup" })
);
}
});
});
describe("errors", () => {
test("invalid value for localeMatcher option", () => {
expect(() => {
Intl.Collator.supportedLocalesOf([], { localeMatcher: "foo" });
}).toThrowWithMessage(RangeError, "foo is not a valid value for option localeMatcher");
});
test("invalid language tag", () => {
expect(() => {
Intl.Collator.supportedLocalesOf(["aaaaaaaaa"]);
}).toThrowWithMessage(RangeError, "aaaaaaaaa is not a structurally valid language tag");
});
});