beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-24 00:20:21 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Meta: Make check-debug-flags.sh runnable in Bash 3.2

Browse source 
This change updates the Meta/check-debug-flags.sh script to avoid an
apparent Bach 3.2 parser bug. Specifically, it takes a comment and some
code of a process substitution and moves it into a separate function.

Otherwise, without this change, trying to run the check-debug-flags.sh
script with Bash 3.2 fails with the following error:

line 39: bad substitution: no closing `)' in <(

...apparently because Bash 3.2 chokes on the comment (and doesn’t choke
if the comment is completely removed).

Relates to https://github.com/LadybirdBrowser/ladybird/issues/283
This commit is contained in:
sideshowbarker 2024-07-16 18:51:33 +09:00 committed by Andrew Kaster
parent 570814a31e
commit 15d67f0da2
Notes: sideshowbarker 2024-07-17 10:16:43 +09:00 
Author: https://github.com/sideshowbarker
Commit: https://github.com/LadybirdBrowser/ladybird/commit/15d67f0da2
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/659
Reviewed-by: https://github.com/ADKaster ✅
1 changed files with 18 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
Meta/check-debug-flags.sh
View file

@ -7,6 +7,23 @@ cd "${script_path}/.."
MISSING_FLAGS=n
find_all_source_files () {
# We're in the middle of a pre-commit run, so we should only check the files that have
# actually changed. The reason is that "git ls-files | grep" on the entire repo takes
# about 100ms. That is perfectly fine during a CI run, but becomes noticeable during a
# pre-commit hook. It is unnecessary to check the entire repository on every single
# commit, so we save some time here.
#
# And see https://github.com/LadybirdBrowser/ladybird/issues/283; the reason this is
# pulled out into separate function is, Bash 3.2 apparently has a parser bug which
# makes it choke on the above comment if it's in the process substitution below.
for file in "$@"; do
if [[ ("${file}" =~ \.cpp || "${file}" =~ \.h || "${file}" =~ \.in) ]]; then
echo "$file"
fi
done
}
# Check whether all_the_debug_macros.cmake sets all the flags used in C++ code.
while IFS= read -r FLAG; do
# We intentionally don't check for commented-out lines,
@ -22,16 +39,7 @@ done < <(
'*.h' \
'*.in'
else
# We're in the middle of a pre-commit run, so we should only check the files that have
# actually changed. The reason is that "git ls-files | grep" on the entire repo takes
# about 100ms. That is perfectly fine during a CI run, but becomes noticeable during a
# pre-commit hook. It is unnecessary to check the entire repository on every single
# commit, so we save some time here.
for file in "$@"; do
if [[ ("${file}" =~ \.cpp || "${file}" =~ \.h || "${file}" =~ \.in) ]]; then
echo "$file"
fi
done
find_all_source_files "$@"
fi \
| xargs grep -E '(_DEBUG|DEBUG_)' \
| sed -re 's,^.*[^a-zA-Z0-9_]([a-zA-Z0-9_]*DEBUG[a-zA-Z0-9_]*).*$,\1,' \