beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibJS: Fix off-by-one error in SyntaxHighlighter

Browse source 
This changes the JS syntax highlighter to conform to the now-fixed
rendering of syntax highlighting spans in GUI::TextEditor.
This commit is contained in:
Max Wipfli 2021-06-03 23:55:16 +02:00 committed by Ali Mohammad Pur
parent a819f98956
commit 106ad6ba09
Notes: sideshowbarker 2024-07-18 16:53:28 +09:00 
Author: https://github.com/MaxWipfli
Commit: https://github.com/SerenityOS/serenity/commit/106ad6ba094
Pull-request: https://github.com/SerenityOS/serenity/pull/7768
Issue: https://github.com/SerenityOS/serenity/issues/7349
Reviewed-by: https://github.com/alimpfard
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibJS/SyntaxHighlighter.cpp
View file

@ -72,7 +72,7 @@ void SyntaxHighlighter::rehighlight(const Palette& palette)
return;
start = position;
for (size_t i = 0; i < str.length() - 1; ++i)
for (size_t i = 0; i < str.length(); ++i)
advance_position(str[i]);
GUI::TextDocumentSpan span;
@ -85,7 +85,6 @@ void SyntaxHighlighter::rehighlight(const Palette& palette)
span.is_skippable = is_trivia;
span.data = reinterpret_cast<void*>(static_cast<size_t>(type));
spans.append(span);
advance_position(str[str.length() - 1]);
dbgln_if(SYNTAX_HIGHLIGHTING_DEBUG, "{}{} @ '{}' {}:{} - {}:{}",
token.name(),