beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 01:20:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Kernel: Make Process::dump_perfcore OOM-fallible using KString

Browse source
This commit is contained in:
Idan Horowitz 2022-01-12 23:21:08 +02:00 committed by Brian Gianforcaro
parent 010a37f997
commit 0fc25273e4
Notes: sideshowbarker 2024-07-17 21:01:33 +09:00 
Author: https://github.com/IdanHo
Commit: https://github.com/SerenityOS/serenity/commit/0fc25273e49
Pull-request: https://github.com/SerenityOS/serenity/pull/11848
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/bgianfo ✅
2 changed files with 15 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

37
Kernel/Process.cpp
View file

@ -519,53 +519,42 @@ ErrorOr<void> Process::dump_core()
return coredump->write();
}
bool Process::dump_perfcore()
ErrorOr<void> Process::dump_perfcore()
{
VERIFY(is_dumpable());
VERIFY(m_perf_event_buffer);
dbgln("Generating perfcore for pid: {}", pid().value());
// Try to generate a filename which isn't already used.
auto base_filename = String::formatted("{}_{}", name(), pid().value());
auto perfcore_filename = String::formatted("{}.profile", base_filename);
auto base_filename = TRY(KString::formatted("{}_{}", name(), pid().value()));
auto perfcore_filename = TRY(KString::formatted("{}.profile", base_filename));
RefPtr<OpenFileDescription> description;
for (size_t attempt = 1; attempt <= 10; ++attempt) {
auto description_or_error = VirtualFileSystem::the().open(perfcore_filename, O_CREAT | O_EXCL, 0400, current_directory(), UidAndGid { 0, 0 });
auto description_or_error = VirtualFileSystem::the().open(perfcore_filename->view(), O_CREAT | O_EXCL, 0400, current_directory(), UidAndGid { 0, 0 });
if (!description_or_error.is_error()) {
description = description_or_error.release_value();
break;
}
perfcore_filename = String::formatted("{}.{}.profile", base_filename, attempt);
perfcore_filename = TRY(KString::formatted("{}.{}.profile", base_filename, attempt));
}
if (!description) {
dbgln("Failed to generate perfcore for pid {}: Could not generate filename for the perfcore file.", pid().value());
return false;
return EEXIST;
}
auto builder_or_error = KBufferBuilder::try_create();
if (builder_or_error.is_error()) {
dbgln("Failed to generate perfcore for pid {}: Could not allocate KBufferBuilder.", pid());
return false;
}
auto builder = builder_or_error.release_value();
if (m_perf_event_buffer->to_json(builder).is_error()) {
dbgln("Failed to generate perfcore for pid {}: Could not serialize performance events to JSON.", pid().value());
return false;
}
auto builder = TRY(KBufferBuilder::try_create());
TRY(m_perf_event_buffer->to_json(builder));
auto json = builder.build();
if (!json) {
dbgln("Failed to generate perfcore for pid {}: Could not allocate buffer.", pid().value());
return false;
return ENOMEM;
}
auto json_buffer = UserOrKernelBuffer::for_kernel_buffer(json->data());
if (description->write(json_buffer, json->size()).is_error()) {
dbgln("Failed to generate perfcore for pid {}: Could not write to perfcore file.", pid().value());
return false;
}
TRY(description->write(json_buffer, json->size()));
dbgln("Wrote perfcore for pid {} to {}", pid().value(), perfcore_filename);
return true;
return {};
}
void Process::finalize()
@ -585,7 +574,9 @@ void Process::finalize()
}
}
if (m_perf_event_buffer) {
dump_perfcore();
auto result = dump_perfcore();
if (result.is_error())
critical_dmesgln("Failed to write perfcore: {}", result.error());
TimeManagement::the().disable_profile_timer();
}
}

2
Kernel/Process.h
View file

@ -528,7 +528,7 @@ private:
void kill_threads_except_self();
void kill_all_threads();
ErrorOr<void> dump_core();
bool dump_perfcore();
ErrorOr<void> dump_perfcore();
bool create_perf_events_buffer_if_needed();
void delete_perf_events_buffer();