beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Don't crash when determining slot element auto directionality

Browse source
This commit is contained in:
Tim Ledbetter 2024-09-10 18:26:56 +01:00 committed by Tim Flynn
parent 1b74104c17
commit 0de3145071
Notes: github-actions[bot] 2024-09-10 19:59:53 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/0de31450715
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1364
3 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/HTML/dir-slot-auto-directionality.txt Normal file
View file

@ -0,0 +1 @@
Slot directionality: ltr

14
Tests/LibWeb/Text/input/HTML/dir-slot-auto-directionality.html Normal file
View file

@ -0,0 +1,14 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<div id="root">
<span></span>
</div>
<script>
const root = document.getElementById("root");
test(() => {
const shadowTree = `<slot dir="auto"></slot>`;
const shadow = document.querySelector("#root").attachShadow({mode: "open"});
shadow.innerHTML = shadowTree;
println(`Slot directionality: ${getComputedStyle(shadow.querySelector("slot")).direction}`);
});
</script>

2
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -2643,7 +2643,7 @@ Optional<Element::Directionality> Element::auto_directionality() const
VERIFY(child->is_element());
// 2. Set childDirection to the auto directionality of child.
child_direction = static_cast<HTML::HTMLElement const&>(*this).auto_directionality();
child_direction = static_cast<HTML::HTMLElement const&>(*child).auto_directionality();
}
// 4. If childDirection is not null, then return childDirection.