beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-23 08:00:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Don't assume response object isn't null in fetch abort algorithm

Browse source 
The callee that we're passing it to expects a GCPtr anyway, so there's
no need to explicitly dereference this.

Fixes a crash when loading https://spotify.com/
This commit is contained in:
Andreas Kling 2023-05-21 15:08:57 +02:00
parent f9803a7319
commit 0d82cc8a67
Notes: sideshowbarker 2024-07-17 09:49:33 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/0d82cc8a67
Pull-request: https://github.com/SerenityOS/serenity/pull/18959
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/Fetch/FetchMethod.cpp
View file

@ -143,7 +143,7 @@ JS::NonnullGCPtr<JS::Promise> fetch(JS::VM& vm, RequestInfo const& input, Reques
auto& promise_capability = *promise_capability_handle;
auto& request_object = *request_object_handle;
auto& response_object = *response_object_handle;
JS::GCPtr<Response> response_object = response_object_handle.ptr();
// 1. Set locallyAborted to true.
locally_aborted->set_value(true);