beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibJS: Fix base64 decoder typo
Some checks are pending
CI / Lagom (false, FUZZ, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
CI / Lagom (false, NO_FUZZ, macos-14, macOS, Clang) (push) Waiting to run
Details
CI / Lagom (false, NO_FUZZ, ubuntu-24.04, Linux, GNU) (push) Waiting to run
Details
CI / Lagom (true, NO_FUZZ, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (macos-14, macOS, macOS-universal2) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
As the comments suggest, _ is supposed to be translated into /
but - is translated twice instead
This commit is contained in:
Pavel Shliak 2024-10-22 22:14:40 +04:00 committed by Tim Flynn
parent 84ad36de06
commit 0cc8ba305d
Notes: github-actions[bot] 2024-10-23 23:48:11 +00:00 
Author: https://github.com/shlyakpavel 🔰
Commit: https://github.com/LadybirdBrowser/ladybird/commit/0cc8ba305d6
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1922
Reviewed-by: https://github.com/trflynn89 ✅
2 changed files with 20 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/Uint8Array.cpp
View file

@ -729,7 +729,7 @@ DecodeResult from_base64(VM& vm, StringView string, Alphabet alphabet, LastChunk
ch = '+';
}
// iii. Else if char is "_", then
else if (ch == '-') {
else if (ch == '_') {
// 1. Set char to "/".
ch = '/';
}

19
Userland/Libraries/LibJS/Tests/builtins/TypedArray/Uint8Array.fromBase64.js
View file

@ -108,6 +108,25 @@ describe("correct behavior", () => {
decodeEqual("8J-kkw==", "🤓", options);
decodeEqual("8J-kk2Zvb_CflpY=", "🤓foo🖖", options);
decodeEqual("b2g_", "oh?", options);
});
test("strict mode with base64url alphabet", () => {
const options = { alphabet: "base64url", lastChunkHandling: "strict" };
decodeEqual("", "", options);
decodeEqual("Zg==", "f", options);
decodeEqual("Zm8=", "fo", options);
decodeEqual("Zm9v", "foo", options);
decodeEqual("Zm9vYg==", "foob", options);
decodeEqual("Zm9vYmE=", "fooba", options);
decodeEqual("Zm9vYmFy", "foobar", options);
decodeEqual("8J-kkw==", "🤓", options);
decodeEqual("8J-kk2Zvb_CflpY=", "🤓foo🖖", options);
decodeEqual("b2g_", "oh?", options);
});
test("stop-before-partial lastChunkHandling", () => {