beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Inline apply_backdrop_filter function into paint_backdrop_filter

Browse source 
No need to have a separate file for this small function.
This commit is contained in:
Aliaksandr Kalenik 2024-07-29 16:51:15 +03:00 committed by Alexander Kalenik
parent 8164be7ac8
commit 0bfcf73524
Notes: github-actions[bot] 2024-07-29 15:49:47 +00:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/LadybirdBrowser/ladybird/commit/0bfcf73524d
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/886
5 changed files with 9 additions and 44 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Meta/gn/secondary/Userland/Libraries/LibWeb/Painting/BUILD.gn
View file

@ -17,7 +17,6 @@ source_set("Painting") {
"Command.cpp", "Command.cpp",
"DisplayList.cpp", "DisplayList.cpp",
"DisplayListRecorder.cpp", "DisplayListRecorder.cpp",
"FilterPainting.cpp",
"GradientPainting.cpp", "GradientPainting.cpp",
"ImagePaintable.cpp", "ImagePaintable.cpp",
"InlinePaintable.cpp", "InlinePaintable.cpp",

1
Userland/Libraries/LibWeb/CMakeLists.txt
View file

@ -558,7 +558,6 @@ set(SOURCES
Painting/DisplayListPlayerSkia.cpp Painting/DisplayListPlayerSkia.cpp
Painting/DisplayListRecorder.cpp Painting/DisplayListRecorder.cpp
Painting/GradientPainting.cpp Painting/GradientPainting.cpp
Painting/FilterPainting.cpp
Painting/ImagePaintable.cpp Painting/ImagePaintable.cpp
Painting/InlinePaintable.cpp Painting/InlinePaintable.cpp
Painting/LabelablePaintable.cpp Painting/LabelablePaintable.cpp

21
Userland/Libraries/LibWeb/Painting/FilterPainting.cpp
View file

@ -1,21 +0,0 @@
/*
* Copyright (c) 2022, MacDue <macdue@dueutil.tech>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibWeb/Layout/Node.h>
#include <LibWeb/Painting/BorderRadiusCornerClipper.h>
#include <LibWeb/Painting/FilterPainting.h>
namespace Web::Painting {
void apply_backdrop_filter(PaintContext& context, CSSPixelRect const& backdrop_rect, BorderRadiiData const& border_radii_data, CSS::ResolvedBackdropFilter const& backdrop_filter)
{
auto backdrop_region = context.rounded_device_rect(backdrop_rect);
ScopedCornerRadiusClip corner_clipper { context, backdrop_region, border_radii_data };
context.display_list_recorder().apply_backdrop_filter(backdrop_region.to_type<int>(), border_radii_data, backdrop_filter);
}
}

17
Userland/Libraries/LibWeb/Painting/FilterPainting.h
View file

@ -1,17 +0,0 @@
/*
* Copyright (c) 2022, MacDue <macdue@dueutil.tech>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <LibGfx/Forward.h>
#include <LibWeb/CSS/BackdropFilter.h>
#include <LibWeb/Forward.h>
namespace Web::Painting {
void apply_backdrop_filter(PaintContext&, CSSPixelRect const&, BorderRadiiData const&, CSS::ResolvedBackdropFilter const&);
}

13
Userland/Libraries/LibWeb/Painting/PaintableBox.cpp
View file

@ -16,7 +16,6 @@
#include <LibWeb/Layout/BlockContainer.h> #include <LibWeb/Layout/BlockContainer.h>
#include <LibWeb/Layout/Viewport.h> #include <LibWeb/Layout/Viewport.h>
#include <LibWeb/Painting/BackgroundPainting.h> #include <LibWeb/Painting/BackgroundPainting.h>
#include <LibWeb/Painting/FilterPainting.h>
#include <LibWeb/Painting/PaintableBox.h> #include <LibWeb/Painting/PaintableBox.h>
#include <LibWeb/Painting/SVGPaintable.h> #include <LibWeb/Painting/SVGPaintable.h>
#include <LibWeb/Painting/SVGSVGPaintable.h> #include <LibWeb/Painting/SVGSVGPaintable.h>
@ -438,9 +437,15 @@ void PaintableBox::paint_border(PaintContext& context) const
void PaintableBox::paint_backdrop_filter(PaintContext& context) const void PaintableBox::paint_backdrop_filter(PaintContext& context) const
{ {
auto& backdrop_filter = computed_values().backdrop_filter(); auto const& backdrop_filter = computed_values().backdrop_filter();
if (!backdrop_filter.is_none()) if (backdrop_filter.is_none()) {
apply_backdrop_filter(context, absolute_border_box_rect(), normalized_border_radii_data(), backdrop_filter); return;
}
auto backdrop_region = context.rounded_device_rect(absolute_border_box_rect());
auto border_radii_data = normalized_border_radii_data();
ScopedCornerRadiusClip corner_clipper { context, backdrop_region, border_radii_data };
context.display_list_recorder().apply_backdrop_filter(backdrop_region.to_type<int>(), border_radii_data, backdrop_filter);
} }
void PaintableBox::paint_background(PaintContext& context) const void PaintableBox::paint_background(PaintContext& context) const