beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 09:30:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

PixelPaint: Account for alpha in color distance calculation

Browse source 
This fixes an issue where BucketTool would consider "black"
and "transparent" the same color.
This commit is contained in:
Timothy Slater 2022-08-27 07:50:37 -05:00 committed by Andreas Kling
parent 21ae882cfd
commit 0506f4eef8
Notes: sideshowbarker 2024-07-18 05:37:06 +09:00 
Author: https://github.com/tslater2006
Commit: https://github.com/SerenityOS/serenity/commit/0506f4eef8
Pull-request: https://github.com/SerenityOS/serenity/pull/15074
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Userland/Applications/PixelPaint/Tools/BucketTool.cpp
View file

@ -2,6 +2,7 @@
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2022, Aaron Yoder <aaronjyoder@gmail.com>
* Copyright (c) 2022, the SerenityOS developers.
* Copyright (c) 2022, Timothy Slater <tslater2006@gmail.com>.
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -30,7 +31,8 @@ static float color_distance_squared(Gfx::Color const& lhs, Gfx::Color const& rhs
int a = rhs.red() - lhs.red();
int b = rhs.green() - lhs.green();
int c = rhs.blue() - lhs.blue();
return (a * a + b * b + c * c) / (3.0f * 255.0f * 255.0f);
int d = rhs.alpha() - lhs.alpha();
return (a * a + b * b + c * c + d * d) / (4.0f * 255.0f * 255.0f);
}
static bool can_paint(int x, int y, Gfx::Bitmap& bitmap, Gfx::Color const& target_color, float threshold_normalized_squared)