beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Allow constructing a WebDriver::Error from an OOM AK::Error

Browse source 
This will allow easily surrounding operations that may fail due to OOM
with TRY. Note that we now also have to define a "normal" constructor
for WebDriver::Error in order to add the AK::Error constructor.
This commit is contained in:
Timothy Flynn 2023-03-05 15:26:51 -05:00 committed by Linus Groh
parent a7bb72a3d6
commit 03d0be13e8
Notes: sideshowbarker 2024-07-16 23:23:27 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/03d0be13e8
Pull-request: https://github.com/SerenityOS/serenity/pull/17730
Reviewed-by: https://github.com/linusg
2 changed files with 27 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
Userland/Libraries/LibWeb/WebDriver/Error.cpp
View file

@ -4,6 +4,7 @@
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <AK/Error.h>
#include <AK/Vector.h>
#include <LibWeb/WebDriver/Error.h>
@ -45,17 +46,33 @@ static Vector<ErrorCodeData> const s_error_code_data = {
{ ErrorCode::UnknownError, 500, "unknown error" },
{ ErrorCode::UnknownMethod, 405, "unknown method" },
{ ErrorCode::UnsupportedOperation, 500, "unsupported operation" },
{ ErrorCode::OutOfMemory, 500, "out of memory" },
};
Error Error::from_code(ErrorCode code, DeprecatedString message, Optional<JsonValue> data)
{
auto const& error_code_data = s_error_code_data[to_underlying(code)];
return {
.http_status = error_code_data.http_status,
.error = error_code_data.json_error_code,
.message = move(message),
.data = move(data)
error_code_data.http_status,
error_code_data.json_error_code,
move(message),
move(data)
};
}
Error::Error(AK::Error const& error)
{
VERIFY(error.code() == ENOMEM);
*this = from_code(ErrorCode::OutOfMemory, {}, {});
}
Error::Error(unsigned http_status_, DeprecatedString error_, DeprecatedString message_, Optional<JsonValue> data_)
: http_status(http_status_)
, error(move(error_))
, message(move(message_))
, data(move(data_))
{
}
}

6
Userland/Libraries/LibWeb/WebDriver/Error.h
View file

@ -42,6 +42,9 @@ enum class ErrorCode {
UnknownError,
UnknownMethod,
UnsupportedOperation,
// Non-standard error codes:
OutOfMemory,
};
// https://w3c.github.io/webdriver/#errors
@ -52,6 +55,9 @@ struct Error {
Optional<JsonValue> data;
static Error from_code(ErrorCode, DeprecatedString message, Optional<JsonValue> data = {});
Error(unsigned http_status, DeprecatedString error, DeprecatedString message, Optional<JsonValue> data);
Error(AK::Error const&);
};
}