beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 09:30:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibPDF: Don't rely on a stream's /Length key existing

Browse source 
Some PDFs omit this key apparently, but Firefox opens them fine. Let's
emulate that behavior.
This commit is contained in:
Matthew Olsson 2021-05-10 10:36:37 -07:00 committed by Andreas Kling
parent 2f0a2865f2
commit 03649f85e2
Notes: sideshowbarker 2024-07-18 17:51:30 +09:00 
Author: https://github.com/mattco98
Commit: https://github.com/SerenityOS/serenity/commit/03649f85e27
Pull-request: https://github.com/SerenityOS/serenity/pull/7018
Reviewed-by: https://github.com/alimpfard
Reviewed-by: https://github.com/bcoles
Reviewed-by: https://github.com/tomuta
1 changed files with 28 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
Userland/Libraries/LibPDF/Parser.cpp
View file

@ -617,12 +617,35 @@ NonnullRefPtr<StreamObject> Parser::parse_stream(NonnullRefPtr<DictObject> dict)
m_reader.move_by(6);
consume_eol();
auto length_value = dict->map().get("Length");
VERIFY(length_value.has_value());
auto length = length_value.value();
VERIFY(length.is_int());
ReadonlyBytes bytes;
auto bytes = m_reader.bytes().slice(m_reader.offset(), length.as_int());
auto maybe_length = dict->get("Length");
if (maybe_length.has_value()) {
// The PDF writer has kindly provided us with the direct length of the stream
m_reader.save();
auto length = m_document->resolve_to<int>(maybe_length.value());
m_reader.load();
bytes = m_reader.bytes().slice(m_reader.offset(), length);
m_reader.move_by(length);
consume_whitespace();
} else {
// We have to look for the endstream keyword
auto stream_start = m_reader.offset();
while (true) {
m_reader.move_until([&] { return matches_eol(); });
auto potential_stream_end = m_reader.offset();
consume_eol();
if (!m_reader.matches("endstream"))
continue;
bytes = m_reader.bytes().slice(stream_start, potential_stream_end - stream_start);
break;
}
}
m_reader.move_by(9);
consume_whitespace();
return make_object<StreamObject>(dict, bytes);
}