beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 17:10:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Remove setting length to 0px if it is not definite

Browse source 
If available width (or height) is max-content and width (or height)
value is 100% it should be resolved in infinite px, not 0 px.

Fixes #18639
This commit is contained in:
Aliaksandr Kalenik 2023-05-04 23:39:13 +03:00 committed by Andreas Kling
parent b443c0b80b
commit 0318ac5ce4
Notes: sideshowbarker 2024-07-16 23:23:26 +09:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/SerenityOS/serenity/commit/0318ac5ce4
Pull-request: https://github.com/SerenityOS/serenity/pull/18644
Issue: https://github.com/SerenityOS/serenity/issues/18639
3 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Tests/LibWeb/Layout/expected/block-and-inline/max-width-percentage-100.txt Normal file
View file

@ -0,0 +1,8 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (1,1) content-size 798x0 [BFC] children: not-inline
BlockContainer <body> at (10,10) content-size 138.609375x19.46875 positioned [BFC] children: not-inline
BlockContainer <div> at (11,11) content-size 136.609375x17.46875 children: inline
line 0 width: 136.609375, height: 17.46875, bottom: 17.46875, baseline: 13.53125
frag 0 from TextNode start: 0, length: 18, rect: [11,11 136.609375x17.46875]
"well hello friends"
TextNode <#text>

5
Tests/LibWeb/Layout/input/block-and-inline/max-width-percentage-100.html Normal file
View file

@ -0,0 +1,5 @@
<!doctype html><style>
* { border: 1px solid black; font-family: 'SerenitySans'; }
body { position: absolute; }
div { max-width: 100%; }
</style><body><div>well hello friends

6
Userland/Libraries/LibWeb/Layout/FormattingContext.cpp
View file

@ -1289,9 +1289,6 @@ CSS::Length FormattingContext::calculate_inner_width(Layout::Box const& box, Ava
return width.resolved(box, width_of_containing_block_as_length_for_resolve).resolved(box);
}
if (!available_width.is_definite())
width_of_containing_block_as_length_for_resolve = CSS::Length::make_px(0);
auto& computed_values = box.computed_values();
if (computed_values.box_sizing() == CSS::BoxSizing::BorderBox) {
auto const padding_left = computed_values.padding().left().resolved(box, width_of_containing_block_as_length_for_resolve).resolved(box);
@ -1316,9 +1313,6 @@ CSS::Length FormattingContext::calculate_inner_height(Layout::Box const& box, Av
return height.resolved(box, height_of_containing_block_as_length_for_resolve).resolved(box);
}
if (!available_height.is_definite())
height_of_containing_block_as_length_for_resolve = CSS::Length::make_px(0);
auto& computed_values = box.computed_values();
if (computed_values.box_sizing() == CSS::BoxSizing::BorderBox) {
auto width_of_containing_block = CSS::Length::make_px(containing_block_width_for(box));