beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 00:50:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Whine instead of dying on unexpected box during line layout

Browse source 
Log a FIXME on the debug log, along with a layout tree dump of the box
that we didn't expect to see. This will be annoying (until fixed),
but far less so than crashing the browser.
This commit is contained in:
Andreas Kling 2023-04-13 13:37:19 +02:00 committed by Linus Groh
parent 2555d7a36a
commit 01ca7e0544
Notes: sideshowbarker 2024-07-17 11:34:34 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/01ca7e0544
Pull-request: https://github.com/SerenityOS/serenity/pull/18344
Reviewed-by: https://github.com/linusg ✅
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/Layout/InlineFormattingContext.cpp
View file

@ -123,7 +123,11 @@ void InlineFormattingContext::dimension_box_on_line(Box const& box, LayoutMode l
}
// Any box that has simple flow inside should have generated line box fragments already.
VERIFY(!box.display().is_flow_inside());
if (box.display().is_flow_inside()) {
dbgln("FIXME: InlineFormattingContext::dimension_box_on_line got unexpected box in inline context:");
dump_tree(box);
return;
}
auto const& width_value = box.computed_values().width();
CSSPixels unconstrained_width = 0;