2020-12-02 20:49:31 +00:00
|
|
|
/*
|
2021-10-09 11:31:13 +00:00
|
|
|
* Copyright (c) 2020-2021, Linus Groh <linusg@serenityos.org>
|
2020-12-02 20:49:31 +00:00
|
|
|
*
|
2021-04-22 08:24:48 +00:00
|
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
2020-12-02 20:49:31 +00:00
|
|
|
*/
|
|
|
|
|
|
|
|
#pragma once
|
|
|
|
|
|
|
|
#include <AK/ByteBuffer.h>
|
2021-07-11 12:57:54 +00:00
|
|
|
#include <AK/Function.h>
|
2021-05-17 17:09:31 +00:00
|
|
|
#include <AK/Variant.h>
|
2021-10-09 11:31:13 +00:00
|
|
|
#include <LibJS/Runtime/Completion.h>
|
2021-06-13 22:57:15 +00:00
|
|
|
#include <LibJS/Runtime/GlobalObject.h>
|
2020-12-02 20:49:31 +00:00
|
|
|
#include <LibJS/Runtime/Object.h>
|
|
|
|
|
|
|
|
namespace JS {
|
|
|
|
|
2021-06-16 23:43:24 +00:00
|
|
|
struct ClampedU8 {
|
|
|
|
};
|
|
|
|
|
2021-07-11 12:57:54 +00:00
|
|
|
// 25.1.1 Notation (read-modify-write modification function), https://tc39.es/ecma262/#sec-arraybuffer-notation
|
|
|
|
using ReadWriteModifyFunction = Function<ByteBuffer(ByteBuffer, ByteBuffer)>;
|
|
|
|
|
2020-12-02 20:49:31 +00:00
|
|
|
class ArrayBuffer : public Object {
|
|
|
|
JS_OBJECT(ArrayBuffer, Object);
|
|
|
|
|
|
|
|
public:
|
2022-02-07 12:34:32 +00:00
|
|
|
static ThrowCompletionOr<ArrayBuffer*> create(GlobalObject&, size_t);
|
2021-12-13 22:05:42 +00:00
|
|
|
static ArrayBuffer* create(GlobalObject&, ByteBuffer);
|
2021-05-17 17:09:31 +00:00
|
|
|
static ArrayBuffer* create(GlobalObject&, ByteBuffer*);
|
2020-12-02 20:49:31 +00:00
|
|
|
|
2021-09-05 10:13:15 +00:00
|
|
|
ArrayBuffer(ByteBuffer buffer, Object& prototype);
|
2021-05-17 17:09:31 +00:00
|
|
|
ArrayBuffer(ByteBuffer* buffer, Object& prototype);
|
2022-03-14 16:25:06 +00:00
|
|
|
virtual ~ArrayBuffer() override = default;
|
2020-12-02 20:49:31 +00:00
|
|
|
|
2021-05-17 17:09:31 +00:00
|
|
|
size_t byte_length() const { return buffer_impl().size(); }
|
2022-03-02 16:45:26 +00:00
|
|
|
size_t max_byte_length() const { return m_max_byte_length.value(); } // Will VERIFY() that it has value
|
2021-05-17 17:09:31 +00:00
|
|
|
ByteBuffer& buffer() { return buffer_impl(); }
|
2022-04-01 17:58:27 +00:00
|
|
|
ByteBuffer const& buffer() const { return buffer_impl(); }
|
2020-12-02 20:49:31 +00:00
|
|
|
|
2021-10-09 11:31:13 +00:00
|
|
|
// Used by allocate_array_buffer() to attach the data block after construction
|
|
|
|
void set_buffer(ByteBuffer buffer) { m_buffer = move(buffer); }
|
2022-02-20 04:31:59 +00:00
|
|
|
void set_max_byte_length(size_t max_byte_length) { m_max_byte_length = max_byte_length; }
|
2021-10-09 11:31:13 +00:00
|
|
|
|
2021-06-10 19:44:17 +00:00
|
|
|
Value detach_key() const { return m_detach_key; }
|
2021-06-10 21:59:24 +00:00
|
|
|
void set_detach_key(Value detach_key) { m_detach_key = detach_key; }
|
|
|
|
|
2021-06-10 19:44:17 +00:00
|
|
|
void detach_buffer() { m_buffer = Empty {}; }
|
|
|
|
bool is_detached() const { return m_buffer.has<Empty>(); }
|
|
|
|
|
2022-03-02 16:45:26 +00:00
|
|
|
bool is_resizable_array_buffer() const;
|
|
|
|
|
2021-06-13 22:57:15 +00:00
|
|
|
enum Order {
|
|
|
|
SeqCst,
|
|
|
|
Unordered
|
|
|
|
};
|
|
|
|
template<typename type>
|
|
|
|
Value get_value(size_t byte_index, bool is_typed_array, Order, bool is_little_endian = true);
|
2021-06-13 23:02:53 +00:00
|
|
|
template<typename type>
|
|
|
|
Value set_value(size_t byte_index, Value value, bool is_typed_array, Order, bool is_little_endian = true);
|
2021-07-11 12:57:54 +00:00
|
|
|
template<typename T>
|
|
|
|
Value get_modify_set_value(size_t byte_index, Value value, ReadWriteModifyFunction operation, bool is_little_endian = true);
|
2021-06-13 22:57:15 +00:00
|
|
|
|
2020-12-02 20:49:31 +00:00
|
|
|
private:
|
2021-06-10 21:59:24 +00:00
|
|
|
virtual void visit_edges(Visitor&) override;
|
|
|
|
|
2021-05-17 17:09:31 +00:00
|
|
|
ByteBuffer& buffer_impl()
|
|
|
|
{
|
|
|
|
ByteBuffer* ptr { nullptr };
|
2021-06-10 19:44:17 +00:00
|
|
|
m_buffer.visit([&](Empty) { VERIFY_NOT_REACHED(); }, [&](auto* pointer) { ptr = pointer; }, [&](auto& value) { ptr = &value; });
|
2021-05-17 17:09:31 +00:00
|
|
|
return *ptr;
|
|
|
|
}
|
|
|
|
|
2022-04-01 17:58:27 +00:00
|
|
|
ByteBuffer const& buffer_impl() const { return const_cast<ArrayBuffer*>(this)->buffer_impl(); }
|
2021-05-17 17:09:31 +00:00
|
|
|
|
2021-06-10 19:44:17 +00:00
|
|
|
Variant<Empty, ByteBuffer, ByteBuffer*> m_buffer;
|
|
|
|
// The various detach related members of ArrayBuffer are not used by any ECMA262 functionality,
|
|
|
|
// but are required to be available for the use of various harnesses like the Test262 test runner.
|
|
|
|
Value m_detach_key;
|
2022-02-20 04:31:59 +00:00
|
|
|
Optional<size_t> m_max_byte_length;
|
2020-12-02 20:49:31 +00:00
|
|
|
};
|
|
|
|
|
2022-03-02 16:44:32 +00:00
|
|
|
ThrowCompletionOr<ArrayBuffer*> allocate_array_buffer(GlobalObject&, FunctionObject& constructor, size_t byte_length, Optional<size_t> max_byte_length = {});
|
2022-02-08 19:36:48 +00:00
|
|
|
ThrowCompletionOr<ArrayBuffer*> clone_array_buffer(GlobalObject&, ArrayBuffer& source_buffer, size_t source_byte_offset, size_t source_length, FunctionObject& clone_constructor);
|
2021-10-09 11:31:13 +00:00
|
|
|
|
2021-06-13 22:57:15 +00:00
|
|
|
// 25.1.2.9 RawBytesToNumeric ( type, rawBytes, isLittleEndian ), https://tc39.es/ecma262/#sec-rawbytestonumeric
|
|
|
|
template<typename T>
|
|
|
|
static Value raw_bytes_to_numeric(GlobalObject& global_object, ByteBuffer raw_value, bool is_little_endian)
|
|
|
|
{
|
|
|
|
if (!is_little_endian) {
|
|
|
|
VERIFY(raw_value.size() % 2 == 0);
|
|
|
|
for (size_t i = 0; i < raw_value.size() / 2; ++i)
|
|
|
|
swap(raw_value[i], raw_value[raw_value.size() - 1 - i]);
|
|
|
|
}
|
2021-06-16 23:43:24 +00:00
|
|
|
using UnderlyingBufferDataType = Conditional<IsSame<ClampedU8, T>, u8, T>;
|
|
|
|
if constexpr (IsSame<UnderlyingBufferDataType, float>) {
|
2021-06-13 22:57:15 +00:00
|
|
|
float value;
|
|
|
|
raw_value.span().copy_to({ &value, sizeof(float) });
|
|
|
|
if (isnan(value))
|
|
|
|
return js_nan();
|
|
|
|
return Value(value);
|
|
|
|
}
|
2021-06-16 23:43:24 +00:00
|
|
|
if constexpr (IsSame<UnderlyingBufferDataType, double>) {
|
2021-06-13 22:57:15 +00:00
|
|
|
double value;
|
|
|
|
raw_value.span().copy_to({ &value, sizeof(double) });
|
|
|
|
if (isnan(value))
|
|
|
|
return js_nan();
|
|
|
|
return Value(value);
|
|
|
|
}
|
2021-06-16 23:43:24 +00:00
|
|
|
if constexpr (!IsIntegral<UnderlyingBufferDataType>)
|
2021-06-13 22:57:15 +00:00
|
|
|
VERIFY_NOT_REACHED();
|
2021-06-16 23:43:24 +00:00
|
|
|
UnderlyingBufferDataType int_value = 0;
|
|
|
|
raw_value.span().copy_to({ &int_value, sizeof(UnderlyingBufferDataType) });
|
|
|
|
if constexpr (sizeof(UnderlyingBufferDataType) == 8) {
|
|
|
|
if constexpr (IsSigned<UnderlyingBufferDataType>)
|
2021-06-13 22:57:15 +00:00
|
|
|
return js_bigint(global_object.heap(), Crypto::SignedBigInteger::create_from(int_value));
|
|
|
|
else
|
|
|
|
return js_bigint(global_object.heap(), Crypto::SignedBigInteger { Crypto::UnsignedBigInteger::create_from(int_value) });
|
|
|
|
} else {
|
|
|
|
return Value(int_value);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
LibJS: Rewrite most of Object for spec compliance :^)
This is a huge patch, I know. In hindsight this perhaps could've been
done slightly more incremental, but I started and then fixed everything
until it worked, and here we are. I tried splitting of some completely
unrelated changes into separate commits, however. Anyway.
This is a rewrite of most of Object, and by extension large parts of
Array, Proxy, Reflect, String, TypedArray, and some other things.
What we already had worked fine for about 90% of things, but getting the
last 10% right proved to be increasingly difficult with the current code
that sort of grew organically and is only very loosely based on the
spec - this became especially obvious when we started fixing a large
number of test262 failures.
Key changes include:
- 1:1 matching function names and parameters of all object-related
functions, to avoid ambiguity. Previously we had things like put(),
which the spec doesn't have - as a result it wasn't always clear which
need to be used.
- Better separation between object abstract operations and internal
methods - the former are always the same, the latter can be overridden
(and are therefore virtual). The internal methods (i.e. [[Foo]] in the
spec) are now prefixed with 'internal_' for clarity - again, it was
previously not always clear which AO a certain method represents,
get() could've been both Get and [[Get]] (I don't know which one it
was closer to right now).
Note that some of the old names have been kept until all code relying
on them is updated, but they are now simple wrappers around the
closest matching standard abstract operation.
- Simplifications of the storage layer: functions that write values to
storage are now prefixed with 'storage_' to make their purpose clear,
and as they are not part of the spec they should not contain any steps
specified by it. Much functionality is now covered by the layers above
it and was removed (e.g. handling of accessors, attribute checks).
- PropertyAttributes has been greatly simplified, and is being replaced
by PropertyDescriptor - a concept similar to the current
implementation, but more aligned with the actual spec. See the commit
message of the previous commit where it was introduced for details.
- As a bonus, and since I had to look at the spec a whole lot anyway, I
introduced more inline comments with the exact steps from the spec -
this makes it super easy to verify correctness.
- East-const all the things.
As a result of all of this, things are much more correct but a bit
slower now. Retaining speed wasn't a consideration at all, I have done
no profiling of the new code - there might be low hanging fruits, which
we can then harvest separately.
Special thanks to Idan for helping me with this by tracking down bugs,
updating everything outside of LibJS to work with these changes (LibWeb,
Spreadsheet, HackStudio), as well as providing countless patches to fix
regressions I introduced - there still are very few (we got it down to
5), but we also get many new passing test262 tests in return. :^)
Co-authored-by: Idan Horowitz <idan.horowitz@gmail.com>
2021-07-04 17:14:16 +00:00
|
|
|
// Implementation for 25.1.2.10 GetValueFromBuffer, used in TypedArray<T>::get_value_from_buffer().
|
2021-06-13 22:57:15 +00:00
|
|
|
template<typename T>
|
|
|
|
Value ArrayBuffer::get_value(size_t byte_index, [[maybe_unused]] bool is_typed_array, Order, bool is_little_endian)
|
|
|
|
{
|
|
|
|
auto element_size = sizeof(T);
|
|
|
|
|
|
|
|
// FIXME: Check for shared buffer
|
|
|
|
|
|
|
|
auto raw_value = buffer_impl().slice(byte_index, element_size);
|
|
|
|
return raw_bytes_to_numeric<T>(global_object(), move(raw_value), is_little_endian);
|
|
|
|
}
|
|
|
|
|
2021-06-13 23:02:53 +00:00
|
|
|
// 25.1.2.11 NumericToRawBytes ( type, value, isLittleEndian ), https://tc39.es/ecma262/#sec-numerictorawbytes
|
|
|
|
template<typename T>
|
|
|
|
static ByteBuffer numeric_to_raw_bytes(GlobalObject& global_object, Value value, bool is_little_endian)
|
|
|
|
{
|
2021-10-16 18:56:14 +00:00
|
|
|
VERIFY(value.is_number() || value.is_bigint());
|
2021-06-16 23:43:24 +00:00
|
|
|
using UnderlyingBufferDataType = Conditional<IsSame<ClampedU8, T>, u8, T>;
|
2022-01-20 17:47:39 +00:00
|
|
|
ByteBuffer raw_bytes = ByteBuffer::create_uninitialized(sizeof(UnderlyingBufferDataType)).release_value_but_fixme_should_propagate_errors(); // FIXME: Handle possible OOM situation.
|
2021-06-13 23:02:53 +00:00
|
|
|
auto flip_if_needed = [&]() {
|
|
|
|
if (is_little_endian)
|
|
|
|
return;
|
2021-06-16 23:43:24 +00:00
|
|
|
VERIFY(sizeof(UnderlyingBufferDataType) % 2 == 0);
|
|
|
|
for (size_t i = 0; i < sizeof(UnderlyingBufferDataType) / 2; ++i)
|
|
|
|
swap(raw_bytes[i], raw_bytes[sizeof(UnderlyingBufferDataType) - 1 - i]);
|
2021-06-13 23:02:53 +00:00
|
|
|
};
|
2021-06-16 23:43:24 +00:00
|
|
|
if constexpr (IsSame<UnderlyingBufferDataType, float>) {
|
2021-10-16 19:11:08 +00:00
|
|
|
float raw_value = MUST(value.to_double(global_object));
|
2021-06-13 23:02:53 +00:00
|
|
|
ReadonlyBytes { &raw_value, sizeof(float) }.copy_to(raw_bytes);
|
|
|
|
flip_if_needed();
|
|
|
|
return raw_bytes;
|
|
|
|
}
|
2021-06-16 23:43:24 +00:00
|
|
|
if constexpr (IsSame<UnderlyingBufferDataType, double>) {
|
2021-10-16 19:11:08 +00:00
|
|
|
double raw_value = MUST(value.to_double(global_object));
|
2021-06-13 23:02:53 +00:00
|
|
|
ReadonlyBytes { &raw_value, sizeof(double) }.copy_to(raw_bytes);
|
|
|
|
flip_if_needed();
|
|
|
|
return raw_bytes;
|
|
|
|
}
|
2021-06-16 23:43:24 +00:00
|
|
|
if constexpr (!IsIntegral<UnderlyingBufferDataType>)
|
2021-06-13 23:02:53 +00:00
|
|
|
VERIFY_NOT_REACHED();
|
2021-06-16 23:43:24 +00:00
|
|
|
if constexpr (sizeof(UnderlyingBufferDataType) == 8) {
|
|
|
|
UnderlyingBufferDataType int_value;
|
|
|
|
|
|
|
|
if constexpr (IsSigned<UnderlyingBufferDataType>)
|
2021-10-16 18:56:14 +00:00
|
|
|
int_value = MUST(value.to_bigint_int64(global_object));
|
2021-06-16 23:43:24 +00:00
|
|
|
else
|
2021-10-16 19:01:10 +00:00
|
|
|
int_value = MUST(value.to_bigint_uint64(global_object));
|
2021-06-16 23:43:24 +00:00
|
|
|
|
|
|
|
ReadonlyBytes { &int_value, sizeof(UnderlyingBufferDataType) }.copy_to(raw_bytes);
|
2021-06-13 23:02:53 +00:00
|
|
|
flip_if_needed();
|
|
|
|
return raw_bytes;
|
|
|
|
} else {
|
2021-06-16 23:43:24 +00:00
|
|
|
UnderlyingBufferDataType int_value;
|
|
|
|
if constexpr (IsSigned<UnderlyingBufferDataType>) {
|
|
|
|
if constexpr (sizeof(UnderlyingBufferDataType) == 4)
|
2021-10-17 20:33:35 +00:00
|
|
|
int_value = MUST(value.to_i32(global_object));
|
2021-06-16 23:43:24 +00:00
|
|
|
else if constexpr (sizeof(UnderlyingBufferDataType) == 2)
|
2021-10-17 20:44:25 +00:00
|
|
|
int_value = MUST(value.to_i16(global_object));
|
2021-06-16 23:43:24 +00:00
|
|
|
else
|
2021-10-17 20:49:09 +00:00
|
|
|
int_value = MUST(value.to_i8(global_object));
|
2021-06-16 23:43:24 +00:00
|
|
|
} else {
|
|
|
|
if constexpr (sizeof(UnderlyingBufferDataType) == 4)
|
2021-10-17 20:43:29 +00:00
|
|
|
int_value = MUST(value.to_u32(global_object));
|
2021-06-16 23:43:24 +00:00
|
|
|
else if constexpr (sizeof(UnderlyingBufferDataType) == 2)
|
2021-10-17 20:48:24 +00:00
|
|
|
int_value = MUST(value.to_u16(global_object));
|
2021-06-16 23:43:24 +00:00
|
|
|
else if constexpr (!IsSame<T, ClampedU8>)
|
2021-10-17 20:49:41 +00:00
|
|
|
int_value = MUST(value.to_u8(global_object));
|
2021-06-16 23:43:24 +00:00
|
|
|
else
|
2021-10-17 20:50:06 +00:00
|
|
|
int_value = MUST(value.to_u8_clamp(global_object));
|
2021-06-16 23:43:24 +00:00
|
|
|
}
|
|
|
|
ReadonlyBytes { &int_value, sizeof(UnderlyingBufferDataType) }.copy_to(raw_bytes);
|
|
|
|
if constexpr (sizeof(UnderlyingBufferDataType) % 2 == 0)
|
|
|
|
flip_if_needed();
|
2021-06-13 23:02:53 +00:00
|
|
|
return raw_bytes;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// 25.1.2.12 SetValueInBuffer ( arrayBuffer, byteIndex, type, value, isTypedArray, order [ , isLittleEndian ] ), https://tc39.es/ecma262/#sec-setvalueinbuffer
|
|
|
|
template<typename T>
|
|
|
|
Value ArrayBuffer::set_value(size_t byte_index, Value value, [[maybe_unused]] bool is_typed_array, Order, bool is_little_endian)
|
|
|
|
{
|
|
|
|
auto raw_bytes = numeric_to_raw_bytes<T>(global_object(), value, is_little_endian);
|
|
|
|
|
|
|
|
// FIXME: Check for shared buffer
|
|
|
|
|
|
|
|
raw_bytes.span().copy_to(buffer_impl().span().slice(byte_index));
|
|
|
|
return js_undefined();
|
|
|
|
}
|
|
|
|
|
2021-07-11 12:57:54 +00:00
|
|
|
// 25.1.2.13 GetModifySetValueInBuffer ( arrayBuffer, byteIndex, type, value, op [ , isLittleEndian ] ), https://tc39.es/ecma262/#sec-getmodifysetvalueinbuffer
|
|
|
|
template<typename T>
|
|
|
|
Value ArrayBuffer::get_modify_set_value(size_t byte_index, Value value, ReadWriteModifyFunction operation, bool is_little_endian)
|
|
|
|
{
|
|
|
|
auto raw_bytes = numeric_to_raw_bytes<T>(global_object(), value, is_little_endian);
|
|
|
|
|
|
|
|
// FIXME: Check for shared buffer
|
|
|
|
|
|
|
|
auto raw_bytes_read = buffer_impl().slice(byte_index, sizeof(T));
|
|
|
|
auto raw_bytes_modified = operation(raw_bytes_read, raw_bytes);
|
|
|
|
raw_bytes_modified.span().copy_to(buffer_impl().span().slice(byte_index));
|
|
|
|
|
|
|
|
return raw_bytes_to_numeric<T>(global_object(), raw_bytes_read, is_little_endian);
|
|
|
|
}
|
|
|
|
|
2020-12-02 20:49:31 +00:00
|
|
|
}
|