beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-23 08:00:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6
ladybird/Userland/Libraries/LibGUI/TextEditor.h

361 lines
13 KiB
C
Raw Normal View History

Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header.
2020-01-18 08:38:21 +00:00
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
*
Everything: Move to SPDX license identifiers in all files. SPDX License Identifiers are a more compact / standardized way of representing file license information. See: https://spdx.dev/resources/use/#identifiers This was done with the `ambr` search and replace tool. ambr --no-parent-ignore --key-from-file --rep-from-file key.txt rep.txt *
2021-04-22 08:24:48 +00:00
* SPDX-License-Identifier: BSD-2-Clause
Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header.
2020-01-18 08:38:21 +00:00
*/
Begin working on a graphical TextEditor. It's gonna be a wrapper around a new GTextEditor widget so I can easily reuse the functionality anywhere I need it. :^)
2019-03-06 23:31:06 +00:00
#pragma once
#include <AK/Function.h>
LibGUI: Convert Vector<OwnPtr> to NonnullOwnPtrVector. This is turning out really nice so far. :^)
2019-07-24 07:12:23 +00:00
#include <AK/NonnullOwnPtrVector.h>
GTextEditor: Add add_custom_context_menu_action() This allows embedders to add their own custom GAction set to a text editor's context menu.
2019-08-25 19:33:08 +00:00
#include <AK/NonnullRefPtrVector.h>
LibGUI: Remove more header dependencies from Widget.h
2020-02-14 23:24:14 +00:00
#include <LibCore/ElapsedTimer.h>
LibGUI: Add an optional "automatic" autocomplete feature to TextEditor This aims to be a "smart" autocomplete that tries to present the user with useful suggestions without being in the way (too much). Here is its current configuration: - Show suggestions 800ms after something is inserted in the editor - if something else is inserted in that period, reset it back to 800ms to allow the user to type uninterrupted - cancel any shown autocomplete (and the timer) on external changes (paste, cut, etc)
2021-01-01 13:59:11 +00:00
#include <LibCore/Timer.h>
LibGUI: Rename ScrollableWidget => AbstractScrollableWidget
2021-05-03 18:31:58 +00:00
#include <LibGUI/AbstractScrollableWidget.h>
LibGUI+HackStudio: Add an opt-in autocompletion interface to TextEditor ...and use that to implement autocomplete in HackStudio. Now everyone can have autocomplete :^)
2020-12-30 10:25:06 +00:00
#include <LibGUI/Forward.h>
LibGUI: Remove leading G from filenames
2020-02-06 19:33:02 +00:00
#include <LibGUI/TextDocument.h>
#include <LibGUI/TextRange.h>
LibGUI: Remove more header dependencies from Widget.h
2020-02-14 23:24:14 +00:00
#include <LibGfx/TextAlignment.h>
LibSyntax: Move GUI::Highlighter to Syntax::Highlighter in LibSyntax This is a move towards dropping more LibGUI dependencies.
2021-02-07 14:15:10 +00:00
#include <LibSyntax/Forward.h>
LibSyntax+LibGUI+LibJS: Move JS syntax highlighter to LibJS This is a little bit messy but the basic idea is: Syntax::Highlighter now has a Syntax::HighlighterClient to talk to the outside world. It mostly communicates in LibGUI primitives that are available in headers, so inlineable. GUI::TextEditor inherits from Syntax::HighlighterClient. This let us to move GUI::JSSyntaxHighlighter to JS::SyntaxHighlighter and remove LibGUI's dependency on LibJS.
2021-02-07 15:56:02 +00:00
#include <LibSyntax/HighlighterClient.h>
Begin working on a graphical TextEditor. It's gonna be a wrapper around a new GTextEditor widget so I can easily reuse the functionality anywhere I need it. :^)
2019-03-06 23:31:06 +00:00
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 14:07:41 +00:00
namespace GUI {
class TextEditor
LibGUI: Rename ScrollableWidget => AbstractScrollableWidget
2021-05-03 18:31:58 +00:00
: public AbstractScrollableWidget
LibSyntax+LibGUI+LibJS: Move JS syntax highlighter to LibJS This is a little bit messy but the basic idea is: Syntax::Highlighter now has a Syntax::HighlighterClient to talk to the outside world. It mostly communicates in LibGUI primitives that are available in headers, so inlineable. GUI::TextEditor inherits from Syntax::HighlighterClient. This let us to move GUI::JSSyntaxHighlighter to JS::SyntaxHighlighter and remove LibGUI's dependency on LibJS.
2021-02-07 15:56:02 +00:00
, public TextDocument::Client
, public Syntax::HighlighterClient {
C_OBJECT(TextEditor);
TextEditor+EditingEngine: Add support for the basics of Vim emulation
2021-01-02 10:59:55 +00:00
Begin working on a graphical TextEditor. It's gonna be a wrapper around a new GTextEditor widget so I can easily reuse the functionality anywhere I need it. :^)
2019-03-06 23:31:06 +00:00
public:
Meta: Tweak .clang-format to not wrap braces after enums.
2019-06-07 15:13:23 +00:00
enum Type {
Add clang-format file Also run it across the whole tree to get everything using the One True Style. We don't yet run this in an automated fashion as it's a little slow, but there is a snippet to do so in makeall.sh.
2019-05-28 09:53:16 +00:00
MultiLine,
SingleLine
};
LibGUI: Use enum for TextEditor modes & add new DisplayOnly mode Adds a new, more restrictive read-only state to TextEditor which forbids copying, selecting, editor cursors, and context menus. Provides a unique appearance on focus which accomodates ComboBox widgets. All TextEditor modes are now accessed by enum and set_mode() which sets the editor to Editable, ReadOnly or DisplayOnly. Updates applications still using set_readonly().
2020-07-14 21:02:46 +00:00
enum Mode {
Editable,
ReadOnly,
DisplayOnly
};
TextEditor: Implement word wrapping Add a new wrapping mode to the TextEditor that will wrap lines at the spaces between words. Replace the previous menubar checkbox 'Wrapping Mode' in HackStudio and the TextEditor with an exclusive submenu which allows switching between 'No wrapping', 'Wrap anywhere' and 'Wrap at words'. 'Wrap anywhere' (the new 'Wrap lines') is still the default mode. Setting the wrapping mode in the constructors of the TextEditorWidget and HackStudio has been removed, it is now set when constructing the menubar actions.
2021-01-09 12:47:48 +00:00
enum WrappingMode {
NoWrap,
WrapAnywhere,
WrapAtWords
};
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 14:07:41 +00:00
virtual ~TextEditor() override;
Begin working on a graphical TextEditor. It's gonna be a wrapper around a new GTextEditor widget so I can easily reuse the functionality anywhere I need it. :^)
2019-03-06 23:31:06 +00:00
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 14:07:41 +00:00
const TextDocument& document() const { return *m_document; }
TextDocument& document() { return *m_document; }
LibGUI: Move GTextDocument out of GTextEditor The idea here is to decouple the document from the editor widget so you could have multiple editors being views onto the same document. This doesn't work yet, since the document and editor are coupled in various ways still (including a per-line back-pointer to the editor.)
2019-10-27 15:10:07 +00:00
HackStudio: Use CodeDocument instead of TextDocument This commit adds a new GUI widget type, called CodeDocument, which is a TextDocument that can additionaly store data related to the debugger. This fixes various bugs and crashes that occured when we switched between files in debug mode, because we previously held stale breakpoint data for the previous file in the Editor object. We now keep this data at the "document" level rather than the Editor level, which fixes things.
2020-08-15 07:58:31 +00:00
virtual void set_document(TextDocument&);
LibGUI: Support multiple GTextEditors editing the same GTextDocument With this patch, you can now assign the same GTextDocument to multiple GTextEditor widgets via GTextEditor::set_document(). The editors have independent cursors and selection, but all changes are shared, and immediately propagate to all editors. This is very unoptimized and will do lots of unnecessary invalidation, especially line re-wrapping and repainting over and over again.
2019-10-27 18:36:59 +00:00
LibGUI: Add optional placeholder to TextEditor This lets you show some disabled text when no text is entered, and the editor is not focused.
2020-09-20 19:20:24 +00:00
const String& placeholder() const { return m_placeholder; }
void set_placeholder(const StringView& placeholder) { m_placeholder = placeholder; }
TextEditor+EditingEngine: Add support for the basics of Vim emulation
2021-01-02 10:59:55 +00:00
TextDocumentLine& current_line() { return line(m_cursor.line()); }
const TextDocumentLine& current_line() const { return line(m_cursor.line()); }
LibGUI: Implement trailing whitespace visualization in TextEditor This patch adds an optional mode where TextEditor highlights trailing whitespace characters on each line with a nice reddish dither pattern. We should probably make this themable and I'm sure it could be nicer somehow, but this is just a first cut and I do kinda like it. :^)
2020-09-01 17:10:55 +00:00
void set_visualize_trailing_whitespace(bool);
bool visualize_trailing_whitespace() const { return m_visualize_trailing_whitespace; }
TextEditor: Visualize leading whitespace
2021-03-17 16:52:42 +00:00
void set_visualize_leading_whitespace(bool);
bool visualize_leading_whitespace() const { return m_visualize_leading_whitespace; }
LibGUI: Give GTextDocument access to the GTextEditor during commands It's useful for the GTextDocument to have access to the initiating GTextEditor widget during the initial execution of a command. Since commands are executed via calls to GUndoCommand::redo(), we do this by wrapping the invocation of redo() in a new helper called GTextDocumentUndoCommand::execute_from(GTextDocument::Client). This is then used to fetch the current auto-indentation feature state and the soft tab width, both used by text insertion.
2020-01-23 20:04:59 +00:00
virtual bool is_automatic_indentation_enabled() const final { return m_automatic_indentation_enabled; }
GTextEditor: Add very basic automatic indentation. This is off by default, but enabled by TextEditor. It simply inserts the same number of leading spaces as the previous line when hitting Enter. :^)
2019-04-25 20:56:09 +00:00
void set_automatic_indentation_enabled(bool enabled) { m_automatic_indentation_enabled = enabled; }
LibGUI: Give GTextDocument access to the GTextEditor during commands It's useful for the GTextDocument to have access to the initiating GTextEditor widget during the initial execution of a command. Since commands are executed via calls to GUndoCommand::redo(), we do this by wrapping the invocation of redo() in a new helper called GTextDocumentUndoCommand::execute_from(GTextDocument::Client). This is then used to fetch the current auto-indentation feature state and the soft tab width, both used by text insertion.
2020-01-23 20:04:59 +00:00
virtual int soft_tab_width() const final { return m_soft_tab_width; }
TextEditor: Added a setter for soft_tab_width
2021-03-15 21:28:00 +00:00
void set_soft_tab_width(int width) { m_soft_tab_width = width; };
LibGUI: Give GTextDocument access to the GTextEditor during commands It's useful for the GTextDocument to have access to the initiating GTextEditor widget during the initial execution of a command. Since commands are executed via calls to GUndoCommand::redo(), we do this by wrapping the invocation of redo() in a new helper called GTextDocumentUndoCommand::execute_from(GTextDocument::Client). This is then used to fetch the current auto-indentation feature state and the soft tab width, both used by text insertion.
2020-01-23 20:04:59 +00:00
TextEditor: Implement word wrapping Add a new wrapping mode to the TextEditor that will wrap lines at the spaces between words. Replace the previous menubar checkbox 'Wrapping Mode' in HackStudio and the TextEditor with an exclusive submenu which allows switching between 'No wrapping', 'Wrap anywhere' and 'Wrap at words'. 'Wrap anywhere' (the new 'Wrap lines') is still the default mode. Setting the wrapping mode in the constructors of the TextEditorWidget and HackStudio has been removed, it is now set when constructing the menubar actions.
2021-01-09 12:47:48 +00:00
WrappingMode wrapping_mode() const { return m_wrapping_mode; }
bool is_wrapping_enabled() const { return m_wrapping_mode != WrappingMode::NoWrap; }
void set_wrapping_mode(WrappingMode);
GTextEditor: Start working on a line-wrapping feature This is not finished, but since the feature is controlled by a runtime flag, the broken implementation should not affect users of this widget too much (in theory :^).)
2019-08-25 06:43:01 +00:00
LibDraw: Put all classes in the Gfx namespace I started adding things to a Draw namespace, but it somehow felt really wrong seeing Draw::Rect and Draw::Bitmap, etc. So instead, let's rename the library to LibGfx. :^)
2020-02-06 10:56:38 +00:00
Gfx::TextAlignment text_alignment() const { return m_text_alignment; }
void set_text_alignment(Gfx::TextAlignment);
GTextEditor: Add support for different text alignments. Currently only CenterLeft and CenterRight are supported, but it would be very straightforward to add other alignments as well.
2019-04-24 20:24:16 +00:00
IRCClient+LibGUI: Add an input box so we can send messages to channels. Implement this using a GTextEditor with a special single-line mode. This new mode needs some polishing, but it's already very useful.
2019-03-15 16:37:13 +00:00
Type type() const { return m_type; }
bool is_single_line() const { return m_type == SingleLine; }
bool is_multi_line() const { return m_type == MultiLine; }
LibGUI: Use enum for TextEditor modes & add new DisplayOnly mode Adds a new, more restrictive read-only state to TextEditor which forbids copying, selecting, editor cursors, and context menus. Provides a unique appearance on focus which accomodates ComboBox widgets. All TextEditor modes are now accessed by enum and set_mode() which sets the editor to Editable, ReadOnly or DisplayOnly. Updates applications still using set_readonly().
2020-07-14 21:02:46 +00:00
Mode mode() const { return m_mode; }
bool is_editable() const { return m_mode == Editable; }
bool is_readonly() const { return m_mode == ReadOnly; }
bool is_displayonly() const { return m_mode == DisplayOnly; }
void set_mode(const Mode);
VisualBuilder: Tweak grid size and add an (empty) toolbox window.
2019-04-11 02:01:17 +00:00
bool is_ruler_visible() const { return m_ruler_visible; }
LibGUI: Reflow+update TextEditor widget after ruler visibility change
2021-04-09 22:09:44 +00:00
void set_ruler_visible(bool);
VisualBuilder: Tweak grid size and add an (empty) toolbox window.
2019-04-11 02:01:17 +00:00
LibGUI: Add TextEditor::set_icon() You can now set a 16x16 icon on a single-line TextEditor. If present, the icon will be painted to the left of the text content.
2020-06-29 18:34:42 +00:00
void set_icon(const Gfx::Bitmap*);
const Gfx::Bitmap* icon() const { return m_icon; }
LibGUI: Turn GTextBox into a wrapper around a single-line GTextEditor.
2019-04-10 01:08:29 +00:00
Function<void()> on_cursor_change;
GTextEditor: Add on_selection_changed callback. This is probably a bit eager and won't coalesce all updates or even ignore no-op changes to the selection.
2019-04-12 00:52:34 +00:00
Function<void()> on_selection_change;
LibGUI: Add focus hooks to TextEditor
2020-07-04 18:07:55 +00:00
Function<void()> on_focusin;
Function<void()> on_focusout;
Begin working on a graphical TextEditor. It's gonna be a wrapper around a new GTextEditor widget so I can easily reuse the functionality anywhere I need it. :^)
2019-03-06 23:31:06 +00:00
StringViewize a bunch of things -- mostly LibGUI
2019-06-02 12:58:02 +00:00
void set_text(const StringView&);
GTextEditor: Improvements to cursor rendering. The view now scrolls along with you as you move the cursor around.
2019-03-07 12:13:25 +00:00
void scroll_cursor_into_view();
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 14:07:41 +00:00
void scroll_position_into_view(const TextPosition&);
AK: Use size_t for the length of strings Using int was a mistake. This patch changes String, StringImpl, StringView and StringBuilder to use size_t instead of int for lengths. Obviously a lot of code needs to change as a result of this.
2019-12-09 16:45:40 +00:00
size_t line_count() const { return document().line_count(); }
TextEditor+EditingEngine: Add support for the basics of Vim emulation
2021-01-02 10:59:55 +00:00
TextDocumentLine& line(size_t index) { return document().line(index); }
const TextDocumentLine& line(size_t index) const { return document().line(index); }
NonnullOwnPtrVector<TextDocumentLine>& lines() { return document().lines(); }
const NonnullOwnPtrVector<TextDocumentLine>& lines() const { return document().lines(); }
GTextEditor: Make the cursor blink while the editor is focused.
2019-03-07 00:05:35 +00:00
int line_spacing() const { return m_line_spacing; }
LibGUI: Remove more header dependencies from Widget.h
2020-02-14 23:24:14 +00:00
int line_height() const;
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 14:07:41 +00:00
TextPosition cursor() const { return m_cursor; }
TextRange normalized_selection() const { return m_selection.normalized(); }
Begin working on a graphical TextEditor. It's gonna be a wrapper around a new GTextEditor widget so I can easily reuse the functionality anywhere I need it. :^)
2019-03-06 23:31:06 +00:00
TextEditor: Implement replacement functionality This patch adds a new replace widget that cooperates with the find widget, the replace widget takes the input in the find textbox, searches for occurences of that input, and replaces them with the input provied in the replace textbox.
2020-01-11 18:52:47 +00:00
void insert_at_cursor_or_replace_selection(const StringView&);
LibC+Everywhere: Remove open_with_path_length() in favor of open() This API was a mostly gratuitous deviation from POSIX that gave up some portability in exchange for avoiding the occasional strlen(). I don't think that was actually achieving anything valuable, so let's just chill out and have the same open() API as everyone else. :^)
2021-01-12 18:21:59 +00:00
bool write_to_file(const String& path);
GTextEditor: Refactor selection into a GTextRange class. This is a bit more expressive than "selection start + current cursor".
2019-03-08 17:28:24 +00:00
bool has_selection() const { return m_selection.is_valid(); }
GTextEditor: Add selected_text() function. I don't have a clipboard to actually put the copied selection onto yet, so just print the selected text to stdout so we can see what it is.
2019-03-08 00:59:59 +00:00
String selected_text() const;
LibGUI+TextEditor: Add the calculation of selected words This moves the calculation of selected words that was originally in the TextEditor application to TextEditor in LibGUI. This allows all applications with text editors to get this number without having to calculating it themselves.
2021-05-26 00:58:55 +00:00
size_t number_of_selected_words() const;
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 14:07:41 +00:00
void set_selection(const TextRange&);
LibGUI: Expose a function to clear GTextEditor selection
2019-12-02 02:48:32 +00:00
void clear_selection();
LibGUI: Move the undo stack from GTextEditor to GTextDocument Since the same document can be edited by multiple editors, we need to keep the undo stack with the document for coherency.
2019-11-30 12:05:17 +00:00
bool can_undo() const { return document().can_undo(); }
bool can_redo() const { return document().can_redo(); }
GTextEditor: Implement a simple text search API - GTextRange find(const StringView& needle, const GTextPosition& start) This function searches for the needle in the haystack (the full text) and returns a GTextRange for the closest match after "start". If the needle is not found, it returns an invalid GTextRange. If no "start" position is provided, the search begins at the head of the text document. :^)
2019-08-21 19:23:17 +00:00
IRCClient+LibGUI: Add an input box so we can send messages to channels. Implement this using a GTextEditor with a special single-line mode. This new mode needs some polishing, but it's already very useful.
2019-03-15 16:37:13 +00:00
String text() const;
void clear();
GTextEditor: Add selected_text() function. I don't have a clipboard to actually put the copied selection onto yet, so just print the selected text to stdout so we can see what it is.
2019-03-08 00:59:59 +00:00
GTextEditor: Work on cut/copy/paste operations.
2019-03-08 13:08:15 +00:00
void cut();
void copy();
void paste();
TextEditor: The delete key should work even when there's no selection.
2019-03-20 22:11:00 +00:00
void do_delete();
GTextEditor: Shift+Delete should delete the current line.
2019-03-25 12:13:46 +00:00
void delete_current_line();
GTextEditor: Add select_all() API. Take the implementation of Ctrl+A and expose it as an API for clients.
2019-06-22 08:38:38 +00:00
void select_all();
LibGUI: Clear GUI::TextEditor selection before performing undo/redo Fixes #6972.
2021-05-08 21:38:01 +00:00
virtual void undo();
virtual void redo();
GTextEditor: Work on cut/copy/paste operations.
2019-03-08 13:08:15 +00:00
GTextEditor: Add GTextEditor::on_change callback for when content changes.
2019-04-09 14:20:36 +00:00
Function<void()> on_change;
LibGUI+TextEditor: Make TextDocument modified state track undo stack This was quite unreliable before. Changes to the undo stack's modified state are now reflected in the document's modified state, and the GUI::TextEditor widget has its undo/redo actions updated automatically. UndoStack is still a bit hard to understand due to the lazy coalescing of commands, and that's something we should improve upon (e.g with more explicit, incremental command merging.) But for now, this is a nice improvement and undo/redo finally behaves in a way that feels natural.
2021-05-08 11:40:33 +00:00
Function<void(bool modified)> on_modified_change;
LibGUI: Add hover highlighting and keyboard controls to ComboBox Adds a new highlighting effect to the actively selected row in ComboBox ListView. ComboBoxEditor can now be controlled with page up, page down, and the up and down arrow keys. ESC and loss of focus now cause comboboxes to close. Now activates on mouseup as well as return.
2020-07-14 21:18:12 +00:00
Function<void()> on_mousedown;
LibGUI: Turn GTextBox into a wrapper around a single-line GTextEditor.
2019-04-10 01:08:29 +00:00
Function<void()> on_return_pressed;
Function<void()> on_escape_pressed;
LibGUI: Add hover highlighting and keyboard controls to ComboBox Adds a new highlighting effect to the actively selected row in ComboBox ListView. ComboBoxEditor can now be controlled with page up, page down, and the up and down arrow keys. ESC and loss of focus now cause comboboxes to close. Now activates on mouseup as well as return.
2020-07-14 21:18:12 +00:00
Function<void()> on_up_pressed;
Function<void()> on_down_pressed;
Function<void()> on_pageup_pressed;
Function<void()> on_pagedown_pressed;
IRCClient+LibGUI: Add an input box so we can send messages to channels. Implement this using a GTextEditor with a special single-line mode. This new mode needs some polishing, but it's already very useful.
2019-03-15 16:37:13 +00:00
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 14:07:41 +00:00
Action& undo_action() { return *m_undo_action; }
Action& redo_action() { return *m_redo_action; }
Action& cut_action() { return *m_cut_action; }
Action& copy_action() { return *m_copy_action; }
Action& paste_action() { return *m_paste_action; }
Action& delete_action() { return *m_delete_action; }
Action& go_to_line_action() { return *m_go_to_line_action; }
LibGUI: Add Select all action to TextEditor Previously, TextEditor processed the Select all command directly on the keydown event handler. For this reason, WindowManager would not process it as an action for the focused control and an action with the same keyboard shortcut from the parent could override the TextEditor's one even when it is focused. For instance, when pressing Ctrl+A on the FileManager's path bar, all files were selected instead, which is not the expected behavior. Now the Select all command is an actual action on TextEditor, so that WindowManager can process it correctly before any other actions. I also added an icon for it!
2020-04-20 19:10:03 +00:00
Action& select_all_action() { return *m_select_all_action; }
LibGUI: Give GTextEditor a context menu. Now GTextEditor manages its own editing actions (cut/copy/paste/etc) and will show a context menu containing them when requested. Apps that want to put a GTextEditor's actions in its menu can get to the actions via public getters. :^)
2019-04-18 10:25:00 +00:00
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 14:07:41 +00:00
void add_custom_context_menu_action(Action&);
GTextEditor: Add add_custom_context_menu_action() This allows embedders to add their own custom GAction set to a text editor's context menu.
2019-08-25 19:33:08 +00:00
TextEditor: Go-to-line now shows line in middle of view (#4008)
2020-11-10 08:53:50 +00:00
void set_cursor_and_focus_line(size_t line, size_t column);
AK: Use size_t for the length of strings Using int was a mistake. This patch changes String, StringImpl, StringView and StringBuilder to use size_t instead of int for lengths. Obviously a lot of code needs to change as a result of this.
2019-12-09 16:45:40 +00:00
void set_cursor(size_t line, size_t column);
HackStudio: Support searching symbol declarations in the Locator The Locator now keeps a cache of the declared symbol in a document. The language client updates that cache whenever it gets an update from the language server about declared symbols. This allows searching for symbol declarations in the Locator, in addition to file names. Closes #5478
2021-02-27 07:50:02 +00:00
virtual void set_cursor(const TextPosition&);
LibGUI: Make GTextEditor::set_cursor() public Also clamp the cursor value to the possible range instead of asserting when trying to set a cursor past the end of the document.
2019-10-21 16:58:27 +00:00
LibSyntax: Move GUI::Highlighter to Syntax::Highlighter in LibSyntax This is a move towards dropping more LibGUI dependencies.
2021-02-07 14:15:10 +00:00
const Syntax::Highlighter* syntax_highlighter() const;
void set_syntax_highlighter(OwnPtr<Syntax::Highlighter>);
LibGUI+HackStudio: Move syntax highlighting from HackStudio to LibGUI This patch introduces the GUI::SyntaxHighlighter class, which can be attached to a GUI::TextEditor to provide syntax highlighting. The C++ syntax highlighting from HackStudio becomes a new class called GUI::CppSyntaxHighlighter. This will make it possible to get C++ syntax highlighting in any app that uses a GUI::TextEditor. :^) Sidenote: It does feel a bit weird having a C++ lexer in a GUI toolkit library, and we'll probably end up moving this out to a separate place as this functionality grows larger.
2020-02-07 19:07:15 +00:00
LibGUI+HackStudio: Add an opt-in autocompletion interface to TextEditor ...and use that to implement autocomplete in HackStudio. Now everyone can have autocomplete :^)
2020-12-30 10:25:06 +00:00
const AutocompleteProvider* autocomplete_provider() const;
void set_autocomplete_provider(OwnPtr<AutocompleteProvider>&&);
TextEditor+EditingEngine: Add support for the basics of Vim emulation
2021-01-02 10:59:55 +00:00
const EditingEngine* editing_engine() const;
void set_editing_engine(OwnPtr<EditingEngine>);
LibGUI: Add an optional "automatic" autocomplete feature to TextEditor This aims to be a "smart" autocomplete that tries to present the user with useful suggestions without being in the way (too much). Here is its current configuration: - Show suggestions 800ms after something is inserted in the editor - if something else is inserted in that period, reset it back to 800ms to allow the user to type uninterrupted - cancel any shown autocomplete (and the timer) on external changes (paste, cut, etc)
2021-01-01 13:59:11 +00:00
bool should_autocomplete_automatically() const { return m_autocomplete_timer; }
void set_should_autocomplete_automatically(bool);
LibGUI+HackStudio: Fix cursor appearance and crash while debugging HackStudio uses a TreeView to display the list of current variables while debugging, and when the program completes, it sets that view's model to a null model. This would trip an assertion if the TreeView had something selected at the time, so this patch lessens the assertion into a simple null check. Additionally, the cursor would look laggy when moving about the editor because the code was waiting for a window repaint to update the cursor's look when it makes more sense to update the cursor when it actually moves. This change also requires the base GUI::TextEditor to expose a getter to tell if its currently in a drag selection. Finally, requesting a context menu in the line ruler on the side of the editor would also place/remove breakpoints, which was counter intuitive, so this requires a left click to modify breakpoint placement.
2020-05-30 06:01:35 +00:00
bool is_in_drag_select() const { return m_in_drag_select; }
TextEditor+EditingEngine: Add support for the basics of Vim emulation
2021-01-02 10:59:55 +00:00
TextRange* selection() { return &m_selection; };
void did_update_selection();
void did_change();
void update_cursor();
void add_code_point(u32 code_point);
void reset_cursor_blink();
EditingEngine: Split selection from movement functions This patch moves selection updates outside movement functions in EditingEngine. Previously, movement functions would automatically update the selection based on whether the Shift key was pressed down during movement. However, not all EditingEngine subclasses want that; VimEditingEngine being a good example (because all selection is handled in visual mode). Therefore, this patch moves all selection updating to EditingEngine::on_key(). Subclasses wishing to provide custom movement and selection semantics should override it (and VimEditingEngine already does).
2021-04-26 20:29:05 +00:00
void update_selection(bool is_selecting);
TextEditor+EditingEngine: Add support for the basics of Vim emulation
2021-01-02 10:59:55 +00:00
int number_of_visible_lines() const;
Gfx::IntRect cursor_content_rect() const;
TextPosition text_position_at_content_position(const Gfx::IntPoint&) const;
Vim: Add change word and delete word functionality Add the functionality of key sequences 'cw', 'ce', 'cb', 'dw', 'de' and 'db'.
2021-01-27 11:57:39 +00:00
void delete_text_range(TextRange);
LibGUI: Add a way for GWidget subclasses to learn that the font changed Use this in GTextEditor to update the vertical scrolling step size so we always scroll one-line-at-a-time.
2019-09-01 10:26:35 +00:00
protected:
LibGUI: Remove parent parameter to GUI::Widget constructor
2020-02-23 11:07:13 +00:00
explicit TextEditor(Type = Type::MultiLine);
LibGUI: Add a way for GWidget subclasses to learn that the font changed Use this in GTextEditor to update the vertical scrolling step size so we always scroll one-line-at-a-time.
2019-09-01 10:26:35 +00:00
LibGUI: Convert GTextBox, GTextEditor and GResizeCorner to ObjectPtr
2019-09-21 13:43:52 +00:00
virtual void did_change_font() override;
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 14:07:41 +00:00
virtual void paint_event(PaintEvent&) override;
virtual void mousedown_event(MouseEvent&) override;
virtual void mouseup_event(MouseEvent&) override;
virtual void mousemove_event(MouseEvent&) override;
virtual void doubleclick_event(MouseEvent&) override;
virtual void keydown_event(KeyEvent&) override;
LibGUI: Make focus events more aware of why focus is changing This patch adds GUI::FocusEvent which has a GUI::FocusSource. The focus source is one of three things: - Programmatic - Mouse - Keyboard This allows receivers of focus events to implement different behaviors depending on how they receive/lose focus.
2020-08-14 17:56:40 +00:00
virtual void focusin_event(FocusEvent&) override;
virtual void focusout_event(FocusEvent&) override;
LibCore: Put all classes in the Core namespace and remove the leading C I've been wanting to do this for a long time. It's time we start being consistent about how this stuff works. The new convention is: - "LibFoo" is a userspace library that provides the "Foo" namespace. That's it :^) This was pretty tedious to convert and I didn't even start on LibGUI yet. But it's coming up next.
2020-02-02 11:34:39 +00:00
virtual void timer_event(Core::TimerEvent&) override;
virtual void enter_event(Core::Event&) override;
virtual void leave_event(Core::Event&) override;
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 14:07:41 +00:00
virtual void context_menu_event(ContextMenuEvent&) override;
virtual void resize_event(ResizeEvent&) override;
LibGUI: Add a ThemeChange event
2020-03-16 11:36:21 +00:00
virtual void theme_change_event(ThemeChangeEvent&) override;
Meta+LibC through LibHTTP: Make clang-format-10 clean Why break at LibHTTP? Because "Meta+Libraries" would be insanely large, and breaking between LibHTTP and LibJS makes the commits roughly evenly large.
2020-09-18 07:49:51 +00:00
virtual void cursor_did_change() { }
LibGfx: Rename Rect,Point,Size => IntRect,IntPoint,IntSize This fits nicer with FloatRect,FloatPoint,FloatSize and gives a much better visual clue about what type of metric is being used.
2020-06-10 08:57:59 +00:00
Gfx::IntRect ruler_content_rect(size_t line) const;
WindowServer: Add support for per-window override cursors. Use this to implement automatic switching to an I-beam cursor when hovering over a GTextEditor. :^)
2019-03-31 21:52:02 +00:00
LibGfx: Rename Rect,Point,Size => IntRect,IntPoint,IntSize This fits nicer with FloatRect,FloatPoint,FloatSize and gives a much better visual clue about what type of metric is being used.
2020-06-10 08:57:59 +00:00
TextPosition text_position_at(const Gfx::IntPoint&) const;
HackStudio: GUI support for setting breakpoints on source code lines
2020-04-24 20:48:25 +00:00
bool ruler_visible() const { return m_ruler_visible; }
HackStudio: Add auto-complete capability to the Editor
2020-09-20 17:58:46 +00:00
Gfx::IntRect content_rect_for_position(const TextPosition&) const;
int ruler_width() const;
GTextEditor: Make text_position_at() protected
2019-10-29 20:37:46 +00:00
LibGUI: Convert GTextBox, GTextEditor and GResizeCorner to ObjectPtr
2019-09-21 13:43:52 +00:00
private:
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 14:07:41 +00:00
friend class TextDocumentLine;
LibGUI: Move GTextDocument out of GTextEditor The idea here is to decouple the document from the editor widget so you could have multiple editors being views onto the same document. This doesn't work yet, since the document and editor are coupled in various ways still (including a per-line back-pointer to the editor.)
2019-10-27 15:10:07 +00:00
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 14:07:41 +00:00
// ^TextDocument::Client
LibGUI: Move visual line metadata from GTextDocument to GTextEditor This patch decouples GTextDocument and GTextDocumentLine from the line wrapping functionality of GTextEditor. This should basically make it possible to have multiple GTextEditors editing the same GTextDocument. Of course, that will require a bit more work since there's no paint invalidation yet.
2019-10-27 17:00:07 +00:00
virtual void document_did_append_line() override;
AK: Use size_t for the length of strings Using int was a mistake. This patch changes String, StringImpl, StringView and StringBuilder to use size_t instead of int for lengths. Obviously a lot of code needs to change as a result of this.
2019-12-09 16:45:40 +00:00
virtual void document_did_insert_line(size_t) override;
virtual void document_did_remove_line(size_t) override;
LibGUI: Move visual line metadata from GTextDocument to GTextEditor This patch decouples GTextDocument and GTextDocumentLine from the line wrapping functionality of GTextEditor. This should basically make it possible to have multiple GTextEditors editing the same GTextDocument. Of course, that will require a bit more work since there's no paint invalidation yet.
2019-10-27 17:00:07 +00:00
virtual void document_did_remove_all_lines() override;
LibGUI: Support multiple GTextEditors editing the same GTextDocument With this patch, you can now assign the same GTextDocument to multiple GTextEditor widgets via GTextEditor::set_document(). The editors have independent cursors and selection, but all changes are shared, and immediately propagate to all editors. This is very unoptimized and will do lots of unnecessary invalidation, especially line re-wrapping and repainting over and over again.
2019-10-27 18:36:59 +00:00
virtual void document_did_change() override;
LibGUI: Don't recompute line-wrapping over and over during set_text() This makes the TextEditor start up fast for large files again.
2019-11-23 16:41:14 +00:00
virtual void document_did_set_text() override;
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 14:07:41 +00:00
virtual void document_did_set_cursor(const TextPosition&) override;
LibGUI: Use UndoStack::on_state_change inside TextDocument/TextEditor Have TextDocument listen for state changes on the internal undo stack, and forward those to all clients via a new virtual function. This simplifies updating the can_undo / can_redo states of TextEditor.
2021-05-08 11:16:37 +00:00
virtual void document_did_update_undo_stack() override;
LibGUI: Move visual line metadata from GTextDocument to GTextEditor This patch decouples GTextDocument and GTextDocumentLine from the line wrapping functionality of GTextEditor. This should basically make it possible to have multiple GTextEditors editing the same GTextDocument. Of course, that will require a bit more work since there's no paint invalidation yet.
2019-10-27 17:00:07 +00:00
LibSyntax+LibGUI+LibJS: Move JS syntax highlighter to LibJS This is a little bit messy but the basic idea is: Syntax::Highlighter now has a Syntax::HighlighterClient to talk to the outside world. It mostly communicates in LibGUI primitives that are available in headers, so inlineable. GUI::TextEditor inherits from Syntax::HighlighterClient. This let us to move GUI::JSSyntaxHighlighter to JS::SyntaxHighlighter and remove LibGUI's dependency on LibJS.
2021-02-07 15:56:02 +00:00
// ^Syntax::HighlighterClient
virtual Vector<TextDocumentSpan>& spans() final { return document().spans(); }
virtual const Vector<TextDocumentSpan>& spans() const final { return document().spans(); }
LibGUI: Add missing "final" in TextEditor
2021-02-07 18:32:40 +00:00
virtual void highlighter_did_set_spans(Vector<TextDocumentSpan> spans) final { document().set_spans(move(spans)); }
LibSyntax+LibGUI+LibJS: Move JS syntax highlighter to LibJS This is a little bit messy but the basic idea is: Syntax::Highlighter now has a Syntax::HighlighterClient to talk to the outside world. It mostly communicates in LibGUI primitives that are available in headers, so inlineable. GUI::TextEditor inherits from Syntax::HighlighterClient. This let us to move GUI::JSSyntaxHighlighter to JS::SyntaxHighlighter and remove LibGUI's dependency on LibJS.
2021-02-07 15:56:02 +00:00
virtual void set_span_at_index(size_t index, TextDocumentSpan span) final { document().set_span_at_index(index, move(span)); }
virtual void highlighter_did_request_update() final { update(); }
virtual String highlighter_did_request_text() const final { return text(); }
virtual GUI::TextDocument& highlighter_did_request_document() final { return document(); }
virtual GUI::TextPosition highlighter_did_request_cursor() const final { return m_cursor; }
LibGUI: Give GTextEditor a context menu. Now GTextEditor manages its own editing actions (cut/copy/paste/etc) and will show a context menu containing them when requested. Apps that want to put a GTextEditor's actions in its menu can get to the actions via public getters. :^)
2019-04-18 10:25:00 +00:00
void create_actions();
GTextEditor: Disable the ruler in single-line mode. Also make it possible to hide the ruler in multi-line mode, if you should want to do that. :^)
2019-03-15 16:54:05 +00:00
void paint_ruler(Painter&);
LibGUI: Make GTextEditor inherit from GScrollableWidget. This is quite nice, now we can share a ton of logic. :^)
2019-03-16 15:54:51 +00:00
void update_content_size();
LibGUI: Support variable-width fonts in TextEditor This patch reworks metric and coordinate computation to iterate over text content instead of making assumptions about fixed glyph widths.
2020-05-18 14:38:28 +00:00
int fixed_glyph_width() const;
Begin working on a graphical TextEditor. It's gonna be a wrapper around a new GTextEditor widget so I can easily reuse the functionality anywhere I need it. :^)
2019-03-06 23:31:06 +00:00
LibGUI: Defer line reflow during text insertion Add a deferral counter and defer reflowing the visual lines until the counter is at zero. Use this to defer reflow when inserting text. This fixes glacial slowdown while paste large amounts of text.
2020-05-27 17:18:40 +00:00
void defer_reflow();
void undefer_reflow();
LibGUI: Add an optional "automatic" autocomplete feature to TextEditor This aims to be a "smart" autocomplete that tries to present the user with useful suggestions without being in the way (too much). Here is its current configuration: - Show suggestions 800ms after something is inserted in the editor - if something else is inserted in that period, reset it back to 800ms to allow the user to type uninterrupted - cancel any shown autocomplete (and the timer) on external changes (paste, cut, etc)
2021-01-01 13:59:11 +00:00
void try_show_autocomplete();
LibGUI: Add TextEditor::set_icon() You can now set a 16x16 icon on a single-line TextEditor. If present, the icon will be painted to the left of the text content.
2020-06-29 18:34:42 +00:00
int icon_size() const { return 16; }
int icon_padding() const { return 2; }
LibGUI: Defer line reflow during text insertion Add a deferral counter and defer reflowing the visual lines until the counter is at zero. Use this to defer reflow when inserting text. This fixes glacial slowdown while paste large amounts of text.
2020-05-27 17:18:40 +00:00
class ReflowDeferrer {
public:
ReflowDeferrer(TextEditor& editor)
: m_editor(editor)
{
m_editor.defer_reflow();
}
~ReflowDeferrer()
{
m_editor.undefer_reflow();
}
LibGUI: Use enum for TextEditor modes & add new DisplayOnly mode Adds a new, more restrictive read-only state to TextEditor which forbids copying, selecting, editor cursors, and context menus. Provides a unique appearance on focus which accomodates ComboBox widgets. All TextEditor modes are now accessed by enum and set_mode() which sets the editor to Editable, ReadOnly or DisplayOnly. Updates applications still using set_readonly().
2020-07-14 21:02:46 +00:00
LibGUI: Defer line reflow during text insertion Add a deferral counter and defer reflowing the visual lines until the counter is at zero. Use this to defer reflow when inserting text. This fixes glacial slowdown while paste large amounts of text.
2020-05-27 17:18:40 +00:00
private:
TextEditor& m_editor;
};
LibGfx: Rename Rect,Point,Size => IntRect,IntPoint,IntSize This fits nicer with FloatRect,FloatPoint,FloatSize and gives a much better visual clue about what type of metric is being used.
2020-06-10 08:57:59 +00:00
Gfx::IntRect line_content_rect(size_t item_index) const;
Gfx::IntRect line_widget_rect(size_t line_index) const;
TextEditor: The delete key should work even when there's no selection.
2019-03-20 22:11:00 +00:00
void delete_selection();
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 14:07:41 +00:00
int content_x_for_position(const TextPosition&) const;
LibGfx: Rename Rect,Point,Size => IntRect,IntPoint,IntSize This fits nicer with FloatRect,FloatPoint,FloatSize and gives a much better visual clue about what type of metric is being used.
2020-06-10 08:57:59 +00:00
Gfx::IntRect ruler_rect_in_inner_coordinates() const;
Gfx::IntRect visible_text_rect_in_inner_coordinates() const;
GTextEditor: Start working on a line-wrapping feature This is not finished, but since the feature is controlled by a runtime flag, the broken implementation should not affect users of this widget too much (in theory :^).)
2019-08-25 06:43:01 +00:00
void recompute_all_visual_lines();
TextEditor: Added redo functionality & proper stack manipulation Added redo functionality & added m_undo_stack_index that moves back & forth on the stack depending on the undo's & redo's.
2019-11-05 22:37:47 +00:00
void ensure_cursor_is_valid();
GTextEditor: Add a way to flush any pending on_change notifications Since on_change handlers can alter the text document we're working on, we have to make sure they've been run before we try looking at spans. This fixes some flakiness when a paint happened before HackStudio had a chance to re-highlight some C++ while editing it. The design where clients of GTextEditor perform syntax highlighting in the "arbitrary code execution" on_change callback is not very good. We should find a way to move highlighting closer to the editor.
2019-11-08 18:49:08 +00:00
void flush_pending_change_notification_if_needed();
GTextEditor: Add Home/End and Ctrl+Home/Ctrl+End navigation shortcuts. For start/end of line and start/end of document respectively.
2019-03-07 12:21:51 +00:00
AK: Use size_t for the length of strings Using int was a mistake. This patch changes String, StringImpl, StringView and StringBuilder to use size_t instead of int for lengths. Obviously a lot of code needs to change as a result of this.
2019-12-09 16:45:40 +00:00
size_t visual_line_containing(size_t line_index, size_t column) const;
void recompute_visual_lines(size_t line_index);
LibGUI: Move visual line metadata from GTextDocument to GTextEditor This patch decouples GTextDocument and GTextDocumentLine from the line wrapping functionality of GTextEditor. This should basically make it possible to have multiple GTextEditors editing the same GTextDocument. Of course, that will require a bit more work since there's no paint invalidation yet.
2019-10-27 17:00:07 +00:00
LibGUI: Keep scrolling while drag-selecting outside a TextEditor If you start selecting text and move the cursor outside the TextEditor widget area without letting go of the mouse button, we will now keep scrolling a little bit every 100ms.
2020-04-20 19:31:49 +00:00
void automatic_selection_scroll_timer_fired();
LibGUI: Consolidate and simplify commands used for insertion/removal This patch adds InsertTextCommand and RemoveTextCommand. These two commands are used to ... insert and remove text :^) The bulk of the logic is moved into GTextDocument, and we now use the command's redo() virtual to perform the action. Or in other words, when you type into the text editor, we create an InsertTextCommand, push it onto the undo stack, and call redo() on it immediately. That's how the text gets inserted. This makes it quite easy to implement more commands, as there is no distinction between a redo() and the initial application.
2019-11-30 15:50:24 +00:00
template<class T, class... Args>
inline void execute(Args&&... args)
{
auto command = make<T>(*m_document, forward<Args>(args)...);
LibGUI: Make autoformatting performed on InsertTextCommand visible to on_edit_action
2020-12-17 15:44:02 +00:00
command->perform_formatting(*this);
LibGUI: Some tweaks for TextEditor's will-execute-command virtual Renamed the virtual from "on_edit_action" to "will_execute" so it doesn't clash with our convention for Function hook names. Also tighten the parameter type to GUI::TextDocumentUndoCommand since that's the only kind of command it will receive.
2021-05-08 13:52:37 +00:00
will_execute(*command);
LibGUI: Give GTextDocument access to the GTextEditor during commands It's useful for the GTextDocument to have access to the initiating GTextEditor widget during the initial execution of a command. Since commands are executed via calls to GUndoCommand::redo(), we do this by wrapping the invocation of redo() in a new helper called GTextDocumentUndoCommand::execute_from(GTextDocument::Client). This is then used to fetch the current auto-indentation feature state and the soft tab width, both used by text insertion.
2020-01-23 20:04:59 +00:00
command->execute_from(*this);
LibGUI: Consolidate and simplify commands used for insertion/removal This patch adds InsertTextCommand and RemoveTextCommand. These two commands are used to ... insert and remove text :^) The bulk of the logic is moved into GTextDocument, and we now use the command's redo() virtual to perform the action. Or in other words, when you type into the text editor, we create an InsertTextCommand, push it onto the undo stack, and call redo() on it immediately. That's how the text gets inserted. This makes it quite easy to implement more commands, as there is no distinction between a redo() and the initial application.
2019-11-30 15:50:24 +00:00
m_document->add_to_undo_stack(move(command));
}
LibGUI: Some tweaks for TextEditor's will-execute-command virtual Renamed the virtual from "on_edit_action" to "will_execute" so it doesn't clash with our convention for Function hook names. Also tighten the parameter type to GUI::TextDocumentUndoCommand since that's the only kind of command it will receive.
2021-05-08 13:52:37 +00:00
virtual void will_execute(TextDocumentUndoCommand const&) { }
HackStudio: Integrate with C++ Language Server Editors now communicate with the c++ language server when openning and editing c++ source files, and go through the language server to get autocomplete suggestions.
2020-09-26 21:11:15 +00:00
IRCClient+LibGUI: Add an input box so we can send messages to channels. Implement this using a GTextEditor with a special single-line mode. This new mode needs some polishing, but it's already very useful.
2019-03-15 16:37:13 +00:00
Type m_type { MultiLine };
LibGUI: Use enum for TextEditor modes & add new DisplayOnly mode Adds a new, more restrictive read-only state to TextEditor which forbids copying, selecting, editor cursors, and context menus. Provides a unique appearance on focus which accomodates ComboBox widgets. All TextEditor modes are now accessed by enum and set_mode() which sets the editor to Editable, ReadOnly or DisplayOnly. Updates applications still using set_readonly().
2020-07-14 21:02:46 +00:00
Mode m_mode { Editable };
IRCClient+LibGUI: Add an input box so we can send messages to channels. Implement this using a GTextEditor with a special single-line mode. This new mode needs some polishing, but it's already very useful.
2019-03-15 16:37:13 +00:00
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 14:07:41 +00:00
TextPosition m_cursor;
LibDraw: Put all classes in the Gfx namespace I started adding things to a Draw namespace, but it somehow felt really wrong seeing Draw::Rect and Draw::Bitmap, etc. So instead, let's rename the library to LibGfx. :^)
2020-02-06 10:56:38 +00:00
Gfx::TextAlignment m_text_alignment { Gfx::TextAlignment::CenterLeft };
GTextEditor: Make the cursor blink while the editor is focused.
2019-03-07 00:05:35 +00:00
bool m_cursor_state { true };
LibGUI+WindowServer: Implement drag-to-select behavior in GTextEditor. To make this feel right, I needed to start passing keyboard modifiers along with mouse events. That allows shift-clicking to extend the selection. :^)
2019-03-08 16:53:02 +00:00
bool m_in_drag_select { false };
GTextEditor: Turn off the ruler by default. You're usually not gonna want the ruler. TextEditor can enable it manually.
2019-04-24 21:06:44 +00:00
bool m_ruler_visible { false };
GTextEditor: Add a way to flush any pending on_change notifications Since on_change handlers can alter the text document we're working on, we have to make sure they've been run before we try looking at spans. This fixes some flakiness when a paint happened before HackStudio had a chance to re-highlight some C++ while editing it. The design where clients of GTextEditor perform syntax highlighting in the "arbitrary code execution" on_change callback is not very good. We should find a way to move highlighting closer to the editor.
2019-11-08 18:49:08 +00:00
bool m_has_pending_change_notification { false };
GTextEditor: Add very basic automatic indentation. This is off by default, but enabled by TextEditor. It simply inserts the same number of leading spaces as the previous line when hitting Enter. :^)
2019-04-25 20:56:09 +00:00
bool m_automatic_indentation_enabled { false };
LibGUI: TextEditor widget should default to no wrapping Since we don't support wrapping in right-aligned text mode, let's keep the old behavior of wrapping being off-by-default for now. Fixes #5275.
2021-02-09 19:27:39 +00:00
WrappingMode m_wrapping_mode { WrappingMode::NoWrap };
LibGUI: Implement trailing whitespace visualization in TextEditor This patch adds an optional mode where TextEditor highlights trailing whitespace characters on each line with a nice reddish dither pattern. We should probably make this themable and I'm sure it could be nicer somehow, but this is just a first cut and I do kinda like it. :^)
2020-09-01 17:10:55 +00:00
bool m_visualize_trailing_whitespace { true };
TextEditor: Visualize leading whitespace
2021-03-17 16:52:42 +00:00
bool m_visualize_leading_whitespace { false };
LibGUI: Let GTextEditor deal with its horizontal padding internally. I originally wanted to have the padding concept in GScrollableWidget but it's really finicky with the ruler and everything.
2019-03-16 22:16:37 +00:00
int m_line_spacing { 4 };
AK: Use size_t for the length of strings Using int was a mistake. This patch changes String, StringImpl, StringView and StringBuilder to use size_t instead of int for lengths. Obviously a lot of code needs to change as a result of this.
2019-12-09 16:45:40 +00:00
size_t m_soft_tab_width { 4 };
LibGUI: Add 1px of horizontal content padding to TextEditor This adds a little bit of needed air around the text.
2020-05-18 15:47:01 +00:00
int m_horizontal_content_padding { 3 };
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 14:07:41 +00:00
TextRange m_selection;
RefPtr<Menu> m_context_menu;
RefPtr<Action> m_undo_action;
RefPtr<Action> m_redo_action;
RefPtr<Action> m_cut_action;
RefPtr<Action> m_copy_action;
RefPtr<Action> m_paste_action;
RefPtr<Action> m_delete_action;
RefPtr<Action> m_go_to_line_action;
LibGUI: Add Select all action to TextEditor Previously, TextEditor processed the Select all command directly on the keydown event handler. For this reason, WindowManager would not process it as an action for the focused control and an action with the same keyboard shortcut from the parent could override the TextEditor's one even when it is focused. For instance, when pressing Ctrl+A on the FileManager's path bar, all files were selected instead, which is not the expected behavior. Now the Select all command is an actual action on TextEditor, so that WindowManager can process it correctly before any other actions. I also added an icon for it!
2020-04-20 19:10:03 +00:00
RefPtr<Action> m_select_all_action;
LibCore: Put all classes in the Core namespace and remove the leading C I've been wanting to do this for a long time. It's time we start being consistent about how this stuff works. The new convention is: - "LibFoo" is a userspace library that provides the "Foo" namespace. That's it :^) This was pretty tedious to convert and I didn't even start on LibGUI yet. But it's coming up next.
2020-02-02 11:34:39 +00:00
Core::ElapsedTimer m_triple_click_timer;
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 14:07:41 +00:00
NonnullRefPtrVector<Action> m_custom_context_menu_actions;
GTextEditor: Add a "span" mechanism for having custom-style text ranges It's now possible to give GTextEditor a vector of Span objects. Spans currently tell the editor which color to use for each character in the span. This can be used to implement syntax highlighting :^)
2019-10-25 19:05:06 +00:00
LibGUI: Defer line reflow during text insertion Add a deferral counter and defer reflowing the visual lines until the counter is at zero. Use this to defer reflow when inserting text. This fixes glacial slowdown while paste large amounts of text.
2020-05-27 17:18:40 +00:00
size_t m_reflow_deferred { 0 };
LibGUI: Don't update cursor, if visual data out-of-date This fixes https://github.com/SerenityOS/serenity/issues/2498 A nullptr dereference was caused by the visual data beeing out of sync with the line data, due to a deferred recompute.
2020-06-12 22:31:46 +00:00
bool m_reflow_requested { false };
bool is_visual_data_up_to_date() const { return !m_reflow_requested; }
LibGUI: Defer line reflow during text insertion Add a deferral counter and defer reflowing the visual lines until the counter is at zero. Use this to defer reflow when inserting text. This fixes glacial slowdown while paste large amounts of text.
2020-05-27 17:18:40 +00:00
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 14:07:41 +00:00
RefPtr<TextDocument> m_document;
LibGUI: Move visual line metadata from GTextDocument to GTextEditor This patch decouples GTextDocument and GTextDocumentLine from the line wrapping functionality of GTextEditor. This should basically make it possible to have multiple GTextEditors editing the same GTextDocument. Of course, that will require a bit more work since there's no paint invalidation yet.
2019-10-27 17:00:07 +00:00
LibGUI: Add optional placeholder to TextEditor This lets you show some disabled text when no text is entered, and the editor is not focused.
2020-09-20 19:20:24 +00:00
String m_placeholder { "" };
LibGUI: Move visual line metadata from GTextDocument to GTextEditor This patch decouples GTextDocument and GTextDocumentLine from the line wrapping functionality of GTextEditor. This should basically make it possible to have multiple GTextEditors editing the same GTextDocument. Of course, that will require a bit more work since there's no paint invalidation yet.
2019-10-27 17:00:07 +00:00
template<typename Callback>
AK: Use size_t for the length of strings Using int was a mistake. This patch changes String, StringImpl, StringView and StringBuilder to use size_t instead of int for lengths. Obviously a lot of code needs to change as a result of this.
2019-12-09 16:45:40 +00:00
void for_each_visual_line(size_t line_index, Callback) const;
LibGUI: Move visual line metadata from GTextDocument to GTextEditor This patch decouples GTextDocument and GTextDocumentLine from the line wrapping functionality of GTextEditor. This should basically make it possible to have multiple GTextEditors editing the same GTextDocument. Of course, that will require a bit more work since there's no paint invalidation yet.
2019-10-27 17:00:07 +00:00
struct LineVisualData {
AK: Use size_t for the length of strings Using int was a mistake. This patch changes String, StringImpl, StringView and StringBuilder to use size_t instead of int for lengths. Obviously a lot of code needs to change as a result of this.
2019-12-09 16:45:40 +00:00
Vector<size_t, 1> visual_line_breaks;
LibGfx: Rename Rect,Point,Size => IntRect,IntPoint,IntSize This fits nicer with FloatRect,FloatPoint,FloatSize and gives a much better visual clue about what type of metric is being used.
2020-06-10 08:57:59 +00:00
Gfx::IntRect visual_rect;
LibGUI: Move visual line metadata from GTextDocument to GTextEditor This patch decouples GTextDocument and GTextDocumentLine from the line wrapping functionality of GTextEditor. This should basically make it possible to have multiple GTextEditors editing the same GTextDocument. Of course, that will require a bit more work since there's no paint invalidation yet.
2019-10-27 17:00:07 +00:00
};
NonnullOwnPtrVector<LineVisualData> m_line_visual_data;
LibGUI+HackStudio: Move syntax highlighting from HackStudio to LibGUI This patch introduces the GUI::SyntaxHighlighter class, which can be attached to a GUI::TextEditor to provide syntax highlighting. The C++ syntax highlighting from HackStudio becomes a new class called GUI::CppSyntaxHighlighter. This will make it possible to get C++ syntax highlighting in any app that uses a GUI::TextEditor. :^) Sidenote: It does feel a bit weird having a C++ lexer in a GUI toolkit library, and we'll probably end up moving this out to a separate place as this functionality grows larger.
2020-02-07 19:07:15 +00:00
LibSyntax: Move GUI::Highlighter to Syntax::Highlighter in LibSyntax This is a move towards dropping more LibGUI dependencies.
2021-02-07 14:15:10 +00:00
OwnPtr<Syntax::Highlighter> m_highlighter;
LibGUI+HackStudio: Add an opt-in autocompletion interface to TextEditor ...and use that to implement autocomplete in HackStudio. Now everyone can have autocomplete :^)
2020-12-30 10:25:06 +00:00
OwnPtr<AutocompleteProvider> m_autocomplete_provider;
OwnPtr<AutocompleteBox> m_autocomplete_box;
LibGUI: Add an optional "automatic" autocomplete feature to TextEditor This aims to be a "smart" autocomplete that tries to present the user with useful suggestions without being in the way (too much). Here is its current configuration: - Show suggestions 800ms after something is inserted in the editor - if something else is inserted in that period, reset it back to 800ms to allow the user to type uninterrupted - cancel any shown autocomplete (and the timer) on external changes (paste, cut, etc)
2021-01-01 13:59:11 +00:00
bool m_should_keep_autocomplete_box { false };
size_t m_automatic_autocomplete_delay_ms { 800 };
LibGUI: Keep scrolling while drag-selecting outside a TextEditor If you start selecting text and move the cursor outside the TextEditor widget area without letting go of the mouse button, we will now keep scrolling a little bit every 100ms.
2020-04-20 19:31:49 +00:00
RefPtr<Core::Timer> m_automatic_selection_scroll_timer;
LibGUI: Add an optional "automatic" autocomplete feature to TextEditor This aims to be a "smart" autocomplete that tries to present the user with useful suggestions without being in the way (too much). Here is its current configuration: - Show suggestions 800ms after something is inserted in the editor - if something else is inserted in that period, reset it back to 800ms to allow the user to type uninterrupted - cancel any shown autocomplete (and the timer) on external changes (paste, cut, etc)
2021-01-01 13:59:11 +00:00
RefPtr<Core::Timer> m_autocomplete_timer;
TextEditor+EditingEngine: Add support for the basics of Vim emulation
2021-01-02 10:59:55 +00:00
OwnPtr<EditingEngine> m_editing_engine;
LibGfx: Rename Rect,Point,Size => IntRect,IntPoint,IntSize This fits nicer with FloatRect,FloatPoint,FloatSize and gives a much better visual clue about what type of metric is being used.
2020-06-10 08:57:59 +00:00
Gfx::IntPoint m_last_mousemove_position;
LibGUI: Add TextEditor::set_icon() You can now set a 16x16 icon on a single-line TextEditor. If present, the icon will be painted to the left of the text content.
2020-06-29 18:34:42 +00:00
RefPtr<Gfx::Bitmap> m_icon;
Begin working on a graphical TextEditor. It's gonna be a wrapper around a new GTextEditor widget so I can easily reuse the functionality anywhere I need it. :^)
2019-03-06 23:31:06 +00:00
};
LibGUI: Put all classes in the GUI namespace and remove the leading G This took me a moment. Welcome to the new world of GUI::Widget! :^)
2020-02-02 14:07:41 +00:00
}
Reference in a new issue Copy permalink