beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6
ladybird/Ladybird/Qt/BrowserWindow.cpp

869 lines
33 KiB
C++
Raw Normal View History

Ladybird: Rudimentary tabbed browsing support This patch removes the browser WebView from the window and places it inside a Tab object, all wrapped up in a QT tab control. So far you can create tabs, but can't close them.
2022-07-05 22:18:21 +00:00
/*
Ladybird: Add "Copy" and "Select All" actions to the Edit menu
2023-01-11 19:09:52 +00:00
* Copyright (c) 2022-2023, Andreas Kling <kling@serenityos.org>
Ladybird: Rudimentary tabbed browsing support This patch removes the browser WebView from the window and places it inside a Tab object, all wrapped up in a QT tab control. So far you can create tabs, but can't close them.
2022-07-05 22:18:21 +00:00
* Copyright (c) 2022, Matthew Costa <ucosty@gmail.com>
Ladybird: Add SettingsDialog stub
2022-07-14 04:08:30 +00:00
* Copyright (c) 2022, Filiph Sandström <filiph.sandstrom@filfatstudios.com>
Ladybird: Implement zoom :^)
2023-01-12 14:39:53 +00:00
* Copyright (c) 2023, Linus Groh <linusg@serenityos.org>
Ladybird: Rudimentary tabbed browsing support This patch removes the browser WebView from the window and places it inside a Tab object, all wrapped up in a QT tab control. So far you can create tabs, but can't close them.
2022-07-05 22:18:21 +00:00
*
* SPDX-License-Identifier: BSD-2-Clause
*/
Ladybird: Add a location bar and allow navigating to new pages :^)
2022-07-03 19:26:51 +00:00
#include "BrowserWindow.h"
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
#include "Icon.h"
Ladybird: Add SettingsDialog stub
2022-07-14 04:08:30 +00:00
#include "Settings.h"
#include "SettingsDialog.h"
Ladybird: Move Qt-specific classes and functions to a Qt subdirectory This will help a lot with developing chromes for different UI frameworks where we can see which helper classes and processes are really using Qt vs just using it to get at helper data. As a bonus, remove Qt dependency from WebDriver.
2023-08-05 16:42:26 +00:00
#include "StringUtils.h"
Ladybird: Render web content in a separate process :^) This patch brings over the WebContent process over from SerenityOS to Ladybird, along with a new WebContentView widget that renders web content in a separate process. There's a lot of jank and FIXME material here, notably I had to re-add manually pumped Core::EventLoop instances on both sides, in order to get the IPC protocol running. This introduces a lot of latency and we should work towards replacing those loops with improved abstractions. The WebContent process is built separately here (not part of Lagom) and we provide our own main.cpp for it. Like everything, this can be better architected, it's just a starting point. :^)
2022-10-05 13:23:41 +00:00
#include "WebContentView.h"
Ladybird: Update pointer to current tab when the selected tab changes This allows requests like dumping the DOM tree to be forwarded to the correct tab. Otherwise, the event would be forwarded to the most recently created tab.
2022-09-13 16:18:32 +00:00
#include <AK/TypeCasts.h>
Ladybird: Move Qt-specific classes and functions to a Qt subdirectory This will help a lot with developing chromes for different UI frameworks where we can see which helper classes and processes are really using Qt vs just using it to get at helper data. As a bonus, remove Qt dependency from WebDriver.
2023-08-05 16:42:26 +00:00
#include <Ladybird/Utilities.h>
Ladybird: Replace ColorScheme enum with Web::CSS::PreferredColorScheme This matches OutOfProcessWebView::set_preferred_color_scheme().
2023-01-12 18:27:34 +00:00
#include <LibWeb/CSS/PreferredColorScheme.h>
Ladybird/BrowserWindow: Port user agent spoofing from Browser
2022-09-26 14:57:44 +00:00
#include <LibWeb/Loader/ResourceLoader.h>
Ladybird+LibWebView: Move CookieJar, Database, and History to LibWebView These classes are used as-is in all chromes. Move them to LibWebView so that non-Serenity chromes don't have to awkwardly reach into its headers and sources.
2023-08-31 11:07:07 +00:00
#include <LibWebView/CookieJar.h>
Browser+Ladybird: Let the list of user agent strings be shared
2023-09-11 13:49:57 +00:00
#include <LibWebView/UserAgent.h>
Ladybird: Add a "Reload" action to reload the current URL
2022-07-05 19:10:50 +00:00
#include <QAction>
Ladybird/BrowserWindow: Add UI for switching preferred CSS color scheme
2022-09-19 08:48:02 +00:00
#include <QActionGroup>
Ladybird: Add "Copy" and "Select All" actions to the Edit menu
2023-01-11 19:09:52 +00:00
#include <QClipboard>
#include <QGuiApplication>
Ladybird/BrowserWindow: Port user agent spoofing from Browser
2022-09-26 14:57:44 +00:00
#include <QInputDialog>
Ladybird: Add "View Source" menu action (Ctrl+U)
2022-07-09 15:46:11 +00:00
#include <QPlainTextEdit>
Ladybird: Add keyboard shortcuts for jumping to a specific tab It's now possible to open a specific tab by using Ctrl/Command plus the number key corresponding to its position in the tab row.
2023-09-20 09:32:37 +00:00
#include <QShortcut>
Ladybird: Close tab clicking wheel of the mouse
2023-02-05 02:26:20 +00:00
#include <QTabBar>
Ladybird/Qt: Listen to DPI changes and update WebContentView accordingly
2023-12-13 18:10:05 +00:00
#include <QWindow>
Ladybird: Add a location bar and allow navigating to new pages :^)
2022-07-03 19:26:51 +00:00
Ladybird: Move classes and types into the Ladybird namespace We were super inconsistent about this, with most "new" classes living in the Ladybird namespace, while "old" ones were in the global namespace, or even sitting in the Browser namespace.
2023-08-02 17:52:59 +00:00
namespace Ladybird {
Ladybird: Port over part of the "Debug" menu from the SerenityOS browser This is pretty messy, but we have to start somewhere. Eventually we should find a way to share this code with SerenityOS.
2022-07-08 12:14:40 +00:00
Ladybird: Use the DALL-E ladybird globe as the application icon This looks a lot more "at home" than usual pixel art logo on non-SerenityOS systems. :^) Also, stop using site favicons as the app icon as that made it annoyingly hard to find Ladybird in task switchers sometimes.
2023-05-27 14:25:22 +00:00
static QIcon const& app_icon()
{
static QIcon icon;
if (icon.isNull()) {
QPixmap pixmap;
pixmap.load(":/Icons/ladybird.png");
icon = QIcon(pixmap);
}
return icon;
}
AK+LibURL: Move AK::URL into a new URL library This URL library ends up being a relatively fundamental base library of the system, as LibCore depends on LibURL. This change has two main benefits: * Moving AK back more towards being an agnostic library that can be used between the kernel and userspace. URL has never really fit that description - and is not used in the kernel. * URL _should_ depend on LibUnicode, as it needs punnycode support. However, it's not really possible to do this inside of AK as it can't depend on any external library. This change brings us a little closer to being able to do that, but unfortunately we aren't there quite yet, as the code generators depend on LibCore.
2024-03-18 03:22:27 +00:00
BrowserWindow::BrowserWindow(Vector<URL::URL> const& initial_urls, WebView::CookieJar& cookie_jar, WebContentOptions const& web_content_options, StringView webdriver_content_ipc_path)
Ladybird: Implement SQLServer for Ladybird :^) This adds a SQLServer binary for Ladybird to make use of Serenity's SQL implementation. This has to use the same IPC socket handling that was used to make WebContent and WebDriver work out-of-process. Unlike Serenity, Ladybird creates a new SQLServer instance for each Ladybird instance. In the future, we should try to make sure there is only one SQLServer instance at a time, and allow multiple Ladybird instances to communicate with it.
2022-12-05 18:09:42 +00:00
: m_cookie_jar(cookie_jar)
Ladybird+LibWebView: Move options used to launch WebContent to a struct It is currently a bit messy to pass these options along from main() to where WebContent is actually launched. If a new flag were to be added, there are a couple dozen files that need to be updated to pass that flag along. With this change, the flag can just be added to the struct, set in main(), and handled in launch_web_content_process().
2023-12-01 17:18:40 +00:00
, m_web_content_options(web_content_options)
Ladybird/WebDriver: Move to using local socket files for WebDriver IPC This allows us to use standard Serenity IPC infrastructure rather than manually creating FD-passing sockets. This also lets us use Serenity's WebDriver Session class, removing the copy previously used in Ladybird. This ensures any changes to Session in the future will be picked up by Ladybird for free.
2022-12-15 14:18:52 +00:00
, m_webdriver_content_ipc_path(webdriver_content_ipc_path)
Ladybird: Add a location bar and allow navigating to new pages :^)
2022-07-03 19:26:51 +00:00
{
Ladybird: Use the DALL-E ladybird globe as the application icon This looks a lot more "at home" than usual pixel art logo on non-SerenityOS systems. :^) Also, stop using site favicons as the app icon as that made it annoyingly hard to find Ladybird in task switchers sometimes.
2023-05-27 14:25:22 +00:00
setWindowIcon(app_icon());
Ladybird/Everywhere: Ensure that Qt objects are created with parents This prevents memory leaks detected by both Valgrind and ASAN/LSAN. Valgrind is still suspicious of the leaked JS::VM from Web::Bindings::main_thread_vm() but there's other issues with leak checking all the GC'd objects. Co-Authored-By: Diego Iastrubni <diegoiast@gmail.com>
2022-10-01 18:46:24 +00:00
m_tabs_container = new QTabWidget(this);
Ladybird: Close tab clicking wheel of the mouse
2023-02-05 02:26:20 +00:00
m_tabs_container->installEventFilter(this);
Ladybird: Rudimentary tabbed browsing support This patch removes the browser WebView from the window and places it inside a Tab object, all wrapped up in a QT tab control. So far you can create tabs, but can't close them.
2022-07-05 22:18:21 +00:00
m_tabs_container->setElideMode(Qt::TextElideMode::ElideRight);
m_tabs_container->setMovable(true);
m_tabs_container->setTabsClosable(true);
Ladybird: Tweak the QTabWidget look
2022-09-09 12:07:24 +00:00
m_tabs_container->setDocumentMode(true);
Ladybird: Clean up tab bar autohide Qt has this feature built-in, so there's no need to create a custom implementation
2022-09-22 16:23:59 +00:00
m_tabs_container->setTabBarAutoHide(true);
Ladybird: Hide TabBar if count <= 1
2022-07-12 09:41:11 +00:00
Ladybird/Qt: Listen to DPI changes and update WebContentView accordingly
2023-12-13 18:10:05 +00:00
// Listen for DPI changes
m_device_pixel_ratio = devicePixelRatio();
m_current_screen = screen();
Ladybird/Qt: Properly listen for DPI changes on Wayland Some Wayland compositors have support of fractional-scale-v1 protocol. The protocol allows compositor to announce a preferred fractional scale on a per-wl_surface basis. Qt forwards these Wayland events to an application using a usual DevicePixelRatioChange event. However, in contrast to the other platforms, this DevicePixelRatioChange event is issued directly on widgets and not screens. Additionally, the exact fractional scale is stored in QWindow object and not the current screen. Note that in theory it is possible to obtain per-screen fractional scaling on Wayland by interpolating data provided by wl_output and xdg_output events but qtwayland does not do that. If fractional-scale-v1 is not available, qtwayland will still fire per-Widget DevicePixelRatioChange events, but, obviously, with the per-screen possibly larger ceiled scaling. This whole thing makes handling DPI changes on Wayland really simple. All we need to do is to intercept DevicePixelRatioChange events firing on QWindow objects and call the old device_pixel_ratio_changed handler with the window's devicePixelRatio(). The only caveat here is not forget to always set QWidget's parent before calling devicePixelRatio() on it.
2024-01-27 04:14:41 +00:00
if (QT_VERSION < QT_VERSION_CHECK(6, 6, 0) || QGuiApplication::platformName() != "wayland") {
setAttribute(Qt::WA_NativeWindow);
setAttribute(Qt::WA_DontCreateNativeAncestors);
Ladybird/Qt: Listen to DPI changes and update WebContentView accordingly
2023-12-13 18:10:05 +00:00
QObject::connect(m_current_screen, &QScreen::logicalDotsPerInchChanged, this, &BrowserWindow::device_pixel_ratio_changed);
Ladybird/Qt: Properly listen for DPI changes on Wayland Some Wayland compositors have support of fractional-scale-v1 protocol. The protocol allows compositor to announce a preferred fractional scale on a per-wl_surface basis. Qt forwards these Wayland events to an application using a usual DevicePixelRatioChange event. However, in contrast to the other platforms, this DevicePixelRatioChange event is issued directly on widgets and not screens. Additionally, the exact fractional scale is stored in QWindow object and not the current screen. Note that in theory it is possible to obtain per-screen fractional scaling on Wayland by interpolating data provided by wl_output and xdg_output events but qtwayland does not do that. If fractional-scale-v1 is not available, qtwayland will still fire per-Widget DevicePixelRatioChange events, but, obviously, with the per-screen possibly larger ceiled scaling. This whole thing makes handling DPI changes on Wayland really simple. All we need to do is to intercept DevicePixelRatioChange events firing on QWindow objects and call the old device_pixel_ratio_changed handler with the window's devicePixelRatio(). The only caveat here is not forget to always set QWidget's parent before calling devicePixelRatio() on it.
2024-01-27 04:14:41 +00:00
QObject::connect(windowHandle(), &QWindow::screenChanged, this, [this](QScreen* screen) {
if (m_device_pixel_ratio != devicePixelRatio())
device_pixel_ratio_changed(devicePixelRatio());
// Listen for logicalDotsPerInchChanged signals on new screen
QObject::disconnect(m_current_screen, &QScreen::logicalDotsPerInchChanged, nullptr, nullptr);
m_current_screen = screen;
QObject::connect(m_current_screen, &QScreen::logicalDotsPerInchChanged, this, &BrowserWindow::device_pixel_ratio_changed);
});
}
Ladybird/Qt: Listen to DPI changes and update WebContentView accordingly
2023-12-13 18:10:05 +00:00
Ladybird: Port over part of the "Debug" menu from the SerenityOS browser This is pretty messy, but we have to start somewhere. Eventually we should find a way to share this code with SerenityOS.
2022-07-08 12:14:40 +00:00
auto* menu = menuBar()->addMenu("&File");
Ladybird: Fix build with Qt 6.2.4
2022-07-07 00:55:21 +00:00
Ladybird+LibWeb: Add initial about:version internal page
2024-01-12 18:41:26 +00:00
auto* about_action = new QAction("&About Ladybird", this);
menu->addAction(about_action);
menu->addSeparator();
Ladybird/Everywhere: Ensure that Qt objects are created with parents This prevents memory leaks detected by both Valgrind and ASAN/LSAN. Valgrind is still suspicious of the leaked JS::VM from Web::Bindings::main_thread_vm() but there's other issues with leak checking all the GC'd objects. Co-Authored-By: Diego Iastrubni <diegoiast@gmail.com>
2022-10-01 18:46:24 +00:00
auto* new_tab_action = new QAction("New &Tab", this);
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
new_tab_action->setIcon(load_icon_from_uri("resource://icons/16x16/new-tab.png"sv));
Ladybird: Use QKeySequence::StandardKey as much as possible Let Qt pick the most appropriate native shortcut when it knows one.
2023-01-12 18:39:07 +00:00
new_tab_action->setShortcuts(QKeySequence::keyBindings(QKeySequence::StandardKey::AddTab));
Ladybird: Fix build with Qt 6.2.4
2022-07-07 00:55:21 +00:00
menu->addAction(new_tab_action);
Ladybird: Add shortcut to "Close Current Tab"
2023-05-25 01:26:42 +00:00
auto* close_current_tab_action = new QAction("&Close Current Tab", this);
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
close_current_tab_action->setIcon(load_icon_from_uri("resource://icons/16x16/close-tab.png"sv));
Ladybird: Use QKeySequence::StandardKey as much as possible Let Qt pick the most appropriate native shortcut when it knows one.
2023-01-12 18:39:07 +00:00
close_current_tab_action->setShortcuts(QKeySequence::keyBindings(QKeySequence::StandardKey::Close));
Ladybird: Add Ctrl-W action to close current tab (#28)
2022-07-19 10:16:46 +00:00
menu->addAction(close_current_tab_action);
Ladybird: Add "Open File..." to menu
2023-05-25 21:47:12 +00:00
auto* open_file_action = new QAction("&Open File...", this);
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
open_file_action->setIcon(load_icon_from_uri("resource://icons/16x16/filetype-folder-open.png"sv));
Ladybird: Add "Open File..." to menu
2023-05-25 21:47:12 +00:00
open_file_action->setShortcut(QKeySequence(QKeySequence::StandardKey::Open));
menu->addAction(open_file_action);
Ladybird: Add two separators to menus
2023-05-25 20:35:27 +00:00
menu->addSeparator();
Ladybird/Everywhere: Ensure that Qt objects are created with parents This prevents memory leaks detected by both Valgrind and ASAN/LSAN. Valgrind is still suspicious of the leaked JS::VM from Web::Bindings::main_thread_vm() but there's other issues with leak checking all the GC'd objects. Co-Authored-By: Diego Iastrubni <diegoiast@gmail.com>
2022-10-01 18:46:24 +00:00
auto* quit_action = new QAction("&Quit", this);
Ladybird: Use QKeySequence::StandardKey as much as possible Let Qt pick the most appropriate native shortcut when it knows one.
2023-01-12 18:39:07 +00:00
quit_action->setShortcuts(QKeySequence::keyBindings(QKeySequence::StandardKey::Quit));
Ladybird: Fix build with Qt 6.2.4
2022-07-07 00:55:21 +00:00
menu->addAction(quit_action);
Ladybird: Add a "Reload" action to reload the current URL
2022-07-05 19:10:50 +00:00
Ladybird: Add "Copy" and "Select All" actions to the Edit menu
2023-01-11 19:09:52 +00:00
auto* edit_menu = menuBar()->addMenu("&Edit");
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
m_copy_selection_action = new QAction("&Copy", this);
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
m_copy_selection_action->setIcon(load_icon_from_uri("resource://icons/16x16/edit-copy.png"sv));
Ladybird: Move the page context menu from the BrowserWindow to the Tab This will allow us to show different context menus depending on what element is clicked, much like we do for Browser on Serenity.
2023-05-15 15:49:44 +00:00
m_copy_selection_action->setShortcuts(QKeySequence::keyBindings(QKeySequence::StandardKey::Copy));
edit_menu->addAction(m_copy_selection_action);
QObject::connect(m_copy_selection_action, &QAction::triggered, this, &BrowserWindow::copy_selected_text);
Ladybird: Add "Copy" and "Select All" actions to the Edit menu
2023-01-11 19:09:52 +00:00
LibWeb+WebContent+Ladybird: Add ability to paste text from clipboard Text can be pasted by pressing Ctrl/Cmd+V or by using button in the context menu. For now only the Qt client is supported.
2024-03-22 10:56:49 +00:00
m_paste_action = new QAction("&Paste", this);
m_paste_action->setIcon(load_icon_from_uri("resource://icons/16x16/paste.png"sv));
m_paste_action->setShortcuts(QKeySequence::keyBindings(QKeySequence::StandardKey::Paste));
edit_menu->addAction(m_paste_action);
QObject::connect(m_paste_action, &QAction::triggered, this, &BrowserWindow::paste);
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
m_select_all_action = new QAction("Select &All", this);
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
m_select_all_action->setIcon(load_icon_from_uri("resource://icons/16x16/select-all.png"sv));
Ladybird: Move the page context menu from the BrowserWindow to the Tab This will allow us to show different context menus depending on what element is clicked, much like we do for Browser on Serenity.
2023-05-15 15:49:44 +00:00
m_select_all_action->setShortcuts(QKeySequence::keyBindings(QKeySequence::StandardKey::SelectAll));
edit_menu->addAction(m_select_all_action);
QObject::connect(m_select_all_action, &QAction::triggered, this, &BrowserWindow::select_all);
Ladybird: Add "Copy" and "Select All" actions to the Edit menu
2023-01-11 19:09:52 +00:00
Ladybird: Add two separators to menus
2023-05-25 20:35:27 +00:00
edit_menu->addSeparator();
Ladybird: Move "Settings" from "File" to "Edit"
2023-05-25 01:23:33 +00:00
auto* settings_action = new QAction("&Settings", this);
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
settings_action->setIcon(load_icon_from_uri("resource://icons/16x16/settings.png"sv));
Ladybird: Move "Settings" from "File" to "Edit"
2023-05-25 01:23:33 +00:00
settings_action->setShortcuts(QKeySequence::keyBindings(QKeySequence::StandardKey::Preferences));
edit_menu->addAction(settings_action);
Ladybird: Switch to next/previous tab with Ctrl+PageDown/PageUp
2022-09-12 07:22:43 +00:00
auto* view_menu = menuBar()->addMenu("&View");
Ladybird/Everywhere: Ensure that Qt objects are created with parents This prevents memory leaks detected by both Valgrind and ASAN/LSAN. Valgrind is still suspicious of the leaked JS::VM from Web::Bindings::main_thread_vm() but there's other issues with leak checking all the GC'd objects. Co-Authored-By: Diego Iastrubni <diegoiast@gmail.com>
2022-10-01 18:46:24 +00:00
auto* open_next_tab_action = new QAction("Open &Next Tab", this);
Ladybird: Switch to next/previous tab with Ctrl+PageDown/PageUp
2022-09-12 07:22:43 +00:00
open_next_tab_action->setShortcut(QKeySequence(Qt::CTRL | Qt::Key_PageDown));
view_menu->addAction(open_next_tab_action);
QObject::connect(open_next_tab_action, &QAction::triggered, this, &BrowserWindow::open_next_tab);
Ladybird/Everywhere: Ensure that Qt objects are created with parents This prevents memory leaks detected by both Valgrind and ASAN/LSAN. Valgrind is still suspicious of the leaked JS::VM from Web::Bindings::main_thread_vm() but there's other issues with leak checking all the GC'd objects. Co-Authored-By: Diego Iastrubni <diegoiast@gmail.com>
2022-10-01 18:46:24 +00:00
auto* open_previous_tab_action = new QAction("Open &Previous Tab", this);
Ladybird: Switch to next/previous tab with Ctrl+PageDown/PageUp
2022-09-12 07:22:43 +00:00
open_previous_tab_action->setShortcut(QKeySequence(Qt::CTRL | Qt::Key_PageUp));
view_menu->addAction(open_previous_tab_action);
QObject::connect(open_previous_tab_action, &QAction::triggered, this, &BrowserWindow::open_previous_tab);
Ladybird/BrowserWindow: Add UI for switching preferred CSS color scheme
2022-09-19 08:48:02 +00:00
view_menu->addSeparator();
Ladybird: Show current zoom level in view menu
2023-03-26 17:56:17 +00:00
m_zoom_menu = view_menu->addMenu("&Zoom");
Ladybird: Implement zoom :^)
2023-01-12 14:39:53 +00:00
auto* zoom_in_action = new QAction("Zoom &In", this);
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
zoom_in_action->setIcon(load_icon_from_uri("resource://icons/16x16/zoom-in.png"sv));
Ladybird: Add Ctrl+= as an alternate "zoom in" shortcut On many keyboards, Ctrl++ is actually Ctrl+Shift+=, and Ctrl+= makes more sense as it's symmetric with Ctrl+-. Both Firefox and Chrome already support this alternate shortcut, so let's be nice and support it in Ladybird as well. :^)
2023-01-12 18:52:24 +00:00
auto zoom_in_shortcuts = QKeySequence::keyBindings(QKeySequence::StandardKey::ZoomIn);
zoom_in_shortcuts.append(QKeySequence(Qt::CTRL | Qt::Key_Equal));
zoom_in_action->setShortcuts(zoom_in_shortcuts);
Ladybird: Show current zoom level in view menu
2023-03-26 17:56:17 +00:00
m_zoom_menu->addAction(zoom_in_action);
Ladybird: Implement zoom :^)
2023-01-12 14:39:53 +00:00
QObject::connect(zoom_in_action, &QAction::triggered, this, &BrowserWindow::zoom_in);
auto* zoom_out_action = new QAction("Zoom &Out", this);
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
zoom_out_action->setIcon(load_icon_from_uri("resource://icons/16x16/zoom-out.png"sv));
Ladybird: Use QKeySequence::StandardKey as much as possible Let Qt pick the most appropriate native shortcut when it knows one.
2023-01-12 18:39:07 +00:00
zoom_out_action->setShortcuts(QKeySequence::keyBindings(QKeySequence::StandardKey::ZoomOut));
Ladybird: Show current zoom level in view menu
2023-03-26 17:56:17 +00:00
m_zoom_menu->addAction(zoom_out_action);
Ladybird: Implement zoom :^)
2023-01-12 14:39:53 +00:00
QObject::connect(zoom_out_action, &QAction::triggered, this, &BrowserWindow::zoom_out);
auto* reset_zoom_action = new QAction("&Reset Zoom", this);
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
reset_zoom_action->setIcon(load_icon_from_uri("resource://icons/16x16/zoom-reset.png"sv));
Ladybird: Implement zoom :^)
2023-01-12 14:39:53 +00:00
reset_zoom_action->setShortcut(QKeySequence(Qt::CTRL | Qt::Key_0));
Ladybird: Show current zoom level in view menu
2023-03-26 17:56:17 +00:00
m_zoom_menu->addAction(reset_zoom_action);
Ladybird: Implement zoom :^)
2023-01-12 14:39:53 +00:00
QObject::connect(reset_zoom_action, &QAction::triggered, this, &BrowserWindow::reset_zoom);
view_menu->addSeparator();
Ladybird/BrowserWindow: Add UI for switching preferred CSS color scheme
2022-09-19 08:48:02 +00:00
auto* color_scheme_menu = view_menu->addMenu("&Color Scheme");
Ladybird/BrowserWindow: Give color scheme action group a detailed name 'group' is not very specific.
2022-09-26 14:28:01 +00:00
auto* color_scheme_group = new QActionGroup(this);
Ladybird/BrowserWindow: Add UI for switching preferred CSS color scheme
2022-09-19 08:48:02 +00:00
Ladybird/Everywhere: Ensure that Qt objects are created with parents This prevents memory leaks detected by both Valgrind and ASAN/LSAN. Valgrind is still suspicious of the leaked JS::VM from Web::Bindings::main_thread_vm() but there's other issues with leak checking all the GC'd objects. Co-Authored-By: Diego Iastrubni <diegoiast@gmail.com>
2022-10-01 18:46:24 +00:00
auto* auto_color_scheme = new QAction("&Auto", this);
Ladybird/BrowserWindow: Add UI for switching preferred CSS color scheme
2022-09-19 08:48:02 +00:00
auto_color_scheme->setCheckable(true);
Ladybird/BrowserWindow: Give color scheme action group a detailed name 'group' is not very specific.
2022-09-26 14:28:01 +00:00
color_scheme_group->addAction(auto_color_scheme);
Ladybird/BrowserWindow: Add UI for switching preferred CSS color scheme
2022-09-19 08:48:02 +00:00
color_scheme_menu->addAction(auto_color_scheme);
QObject::connect(auto_color_scheme, &QAction::triggered, this, &BrowserWindow::enable_auto_color_scheme);
Ladybird/Everywhere: Ensure that Qt objects are created with parents This prevents memory leaks detected by both Valgrind and ASAN/LSAN. Valgrind is still suspicious of the leaked JS::VM from Web::Bindings::main_thread_vm() but there's other issues with leak checking all the GC'd objects. Co-Authored-By: Diego Iastrubni <diegoiast@gmail.com>
2022-10-01 18:46:24 +00:00
auto* light_color_scheme = new QAction("&Light", this);
Ladybird/BrowserWindow: Add UI for switching preferred CSS color scheme
2022-09-19 08:48:02 +00:00
light_color_scheme->setCheckable(true);
Ladybird/BrowserWindow: Give color scheme action group a detailed name 'group' is not very specific.
2022-09-26 14:28:01 +00:00
color_scheme_group->addAction(light_color_scheme);
Ladybird/BrowserWindow: Add UI for switching preferred CSS color scheme
2022-09-19 08:48:02 +00:00
color_scheme_menu->addAction(light_color_scheme);
QObject::connect(light_color_scheme, &QAction::triggered, this, &BrowserWindow::enable_light_color_scheme);
Ladybird/Everywhere: Ensure that Qt objects are created with parents This prevents memory leaks detected by both Valgrind and ASAN/LSAN. Valgrind is still suspicious of the leaked JS::VM from Web::Bindings::main_thread_vm() but there's other issues with leak checking all the GC'd objects. Co-Authored-By: Diego Iastrubni <diegoiast@gmail.com>
2022-10-01 18:46:24 +00:00
auto* dark_color_scheme = new QAction("&Dark", this);
Ladybird/BrowserWindow: Add UI for switching preferred CSS color scheme
2022-09-19 08:48:02 +00:00
dark_color_scheme->setCheckable(true);
Ladybird/BrowserWindow: Give color scheme action group a detailed name 'group' is not very specific.
2022-09-26 14:28:01 +00:00
color_scheme_group->addAction(dark_color_scheme);
Ladybird/BrowserWindow: Add UI for switching preferred CSS color scheme
2022-09-19 08:48:02 +00:00
color_scheme_menu->addAction(dark_color_scheme);
QObject::connect(dark_color_scheme, &QAction::triggered, this, &BrowserWindow::enable_dark_color_scheme);
auto_color_scheme->setChecked(true);
Ladybird: Add "View Source" menu action (Ctrl+U)
2022-07-09 15:46:11 +00:00
auto* inspect_menu = menuBar()->addMenu("&Inspect");
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
m_view_source_action = new QAction("View &Source", this);
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
m_view_source_action->setIcon(load_icon_from_uri("resource://icons/16x16/filetype-html.png"sv));
Ladybird: Move the page context menu from the BrowserWindow to the Tab This will allow us to show different context menus depending on what element is clicked, much like we do for Browser on Serenity.
2023-05-15 15:49:44 +00:00
m_view_source_action->setShortcut(QKeySequence(Qt::CTRL | Qt::Key_U));
inspect_menu->addAction(m_view_source_action);
QObject::connect(m_view_source_action, &QAction::triggered, this, [this] {
Ladybird: Add "View Source" menu action (Ctrl+U)
2022-07-09 15:46:11 +00:00
if (m_current_tab) {
Ladybird: Render web content in a separate process :^) This patch brings over the WebContent process over from SerenityOS to Ladybird, along with a new WebContentView widget that renders web content in a separate process. There's a lot of jank and FIXME material here, notably I had to re-add manually pumped Core::EventLoop instances on both sides, in order to get the IPC protocol running. This introduces a lot of latency and we should work towards replacing those loops with improved abstractions. The WebContent process is built separately here (not part of Lagom) and we provide our own main.cpp for it. Like everything, this can be better architected, it's just a starting point. :^)
2022-10-05 13:23:41 +00:00
m_current_tab->view().get_source();
Ladybird: Add "View Source" menu action (Ctrl+U)
2022-07-09 15:46:11 +00:00
}
});
Ladybird: Prevent QAction leaking In some places in the code QAction instances are added to a parent directly on instantiation. In the case they are not, Valgrind reports them as leaking.
2023-07-19 16:07:50 +00:00
auto* inspector_action = new QAction("Open &Inspector", this);
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
inspector_action->setIcon(load_icon_from_uri("resource://icons/browser/dom-tree.png"sv));
Ladybird: Allow opening the Inspector with both ctrl+shift+I and F12 Ladybird on Serenity currently only uses F12, and on other platforms only uses ctrl+shift+I. Most browsers support both hotkeys, so let's do the same for consistency. Note that the AppKit chrome cannot support both shortcuts. macOS does not allow setting multiple "key equivalent" strings on an action. There are some questionable hacks we could do to support this eventually, but for now, just ctrl+shift+I is supported on macOS.
2023-12-02 15:58:17 +00:00
inspector_action->setShortcuts({ QKeySequence("Ctrl+Shift+I"), QKeySequence("F12") });
Ladybird: Add a very simple DOM inspector We use a ModelTranslator to expose a DOMTreeModel from LibWebView :^) It allows you to select the currently inspected node, which causes the engine to render a little box model overlay above the web content.
2022-09-25 10:17:53 +00:00
inspect_menu->addAction(inspector_action);
QObject::connect(inspector_action, &QAction::triggered, this, [this] {
if (m_current_tab) {
Ladybird: Move ownership of the JS console/inspector to the tab object This is to match Browser, where ownership of all "subwidgets" is placed on the tab as well. This further lets us align the web view callbacks to match Browser's OOPWV as well, which will later let us move them into the base LibWebView class.
2023-05-17 15:54:36 +00:00
m_current_tab->show_inspector_window();
Ladybird: Add a very simple DOM inspector We use a ModelTranslator to expose a DOMTreeModel from LibWebView :^) It allows you to select the currently inspected node, which causes the engine to render a little box model overlay above the web content.
2022-09-25 10:17:53 +00:00
}
});
Ladybird: Port over part of the "Debug" menu from the SerenityOS browser This is pretty messy, but we have to start somewhere. Eventually we should find a way to share this code with SerenityOS.
2022-07-08 12:14:40 +00:00
auto* debug_menu = menuBar()->addMenu("&Debug");
LibWeb+WebContent: Add option to dump session history of a traversable
2023-08-14 18:19:41 +00:00
auto* dump_session_history_tree_action = new QAction("Dump Session History Tree", this);
debug_menu->addAction(dump_session_history_tree_action);
QObject::connect(dump_session_history_tree_action, &QAction::triggered, this, [this] {
debug_request("dump-session-history");
});
Ladybird: Add missing shortcuts Add the missing shortcuts from Ladybird SerenityOS to Ladybird QT
2023-06-24 01:36:19 +00:00
auto* dump_dom_tree_action = new QAction("Dump &DOM Tree", this);
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
dump_dom_tree_action->setIcon(load_icon_from_uri("resource://icons/browser/dom-tree.png"sv));
Ladybird: Port over part of the "Debug" menu from the SerenityOS browser This is pretty messy, but we have to start somewhere. Eventually we should find a way to share this code with SerenityOS.
2022-07-08 12:14:40 +00:00
debug_menu->addAction(dump_dom_tree_action);
QObject::connect(dump_dom_tree_action, &QAction::triggered, this, [this] {
debug_request("dump-dom-tree");
});
Ladybird: Add missing shortcuts Add the missing shortcuts from Ladybird SerenityOS to Ladybird QT
2023-06-24 01:36:19 +00:00
auto* dump_layout_tree_action = new QAction("Dump &Layout Tree", this);
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
dump_layout_tree_action->setIcon(load_icon_from_uri("resource://icons/16x16/layout.png"sv));
Ladybird: Port over part of the "Debug" menu from the SerenityOS browser This is pretty messy, but we have to start somewhere. Eventually we should find a way to share this code with SerenityOS.
2022-07-08 12:14:40 +00:00
debug_menu->addAction(dump_layout_tree_action);
QObject::connect(dump_layout_tree_action, &QAction::triggered, this, [this] {
debug_request("dump-layout-tree");
});
Ladybird: Add missing shortcuts Add the missing shortcuts from Ladybird SerenityOS to Ladybird QT
2023-06-24 01:36:19 +00:00
auto* dump_paint_tree_action = new QAction("Dump &Paint Tree", this);
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
dump_paint_tree_action->setIcon(load_icon_from_uri("resource://icons/16x16/layout.png"sv));
LibWeb+Browser+Ladybird: Add menu action to dump paint tree
2023-03-18 19:22:58 +00:00
debug_menu->addAction(dump_paint_tree_action);
QObject::connect(dump_paint_tree_action, &QAction::triggered, this, [this] {
debug_request("dump-paint-tree");
});
Ladybird: Add missing shortcuts Add the missing shortcuts from Ladybird SerenityOS to Ladybird QT
2023-06-24 01:36:19 +00:00
auto* dump_stacking_context_tree_action = new QAction("Dump S&tacking Context Tree", this);
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
dump_stacking_context_tree_action->setIcon(load_icon_from_uri("resource://icons/16x16/layers.png"sv));
Ladybird: Port over part of the "Debug" menu from the SerenityOS browser This is pretty messy, but we have to start somewhere. Eventually we should find a way to share this code with SerenityOS.
2022-07-08 12:14:40 +00:00
debug_menu->addAction(dump_stacking_context_tree_action);
QObject::connect(dump_stacking_context_tree_action, &QAction::triggered, this, [this] {
debug_request("dump-stacking-context-tree");
});
Ladybird: Add missing shortcuts Add the missing shortcuts from Ladybird SerenityOS to Ladybird QT
2023-06-24 01:36:19 +00:00
auto* dump_style_sheets_action = new QAction("Dump &Style Sheets", this);
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
dump_style_sheets_action->setIcon(load_icon_from_uri("resource://icons/16x16/filetype-css.png"sv));
Ladybird: Port over part of the "Debug" menu from the SerenityOS browser This is pretty messy, but we have to start somewhere. Eventually we should find a way to share this code with SerenityOS.
2022-07-08 12:14:40 +00:00
debug_menu->addAction(dump_style_sheets_action);
QObject::connect(dump_style_sheets_action, &QAction::triggered, this, [this] {
debug_request("dump-style-sheets");
});
Ladybird: Add missing shortcuts Add the missing shortcuts from Ladybird SerenityOS to Ladybird QT
2023-06-24 01:36:19 +00:00
auto* dump_styles_action = new QAction("Dump &All Resolved Styles", this);
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
dump_styles_action->setIcon(load_icon_from_uri("resource://icons/16x16/filetype-css.png"sv));
Ladybird+Browser: Add a 'Dump All Resolved Styles' debug option This option dumps all styles for all elements in the document; very helpful for finding properties that have changed unintentionally :^)
2023-05-27 12:03:08 +00:00
debug_menu->addAction(dump_styles_action);
QObject::connect(dump_styles_action, &QAction::triggered, this, [this] {
debug_request("dump-all-resolved-styles");
});
Ladybird: Add missing shortcuts Add the missing shortcuts from Ladybird SerenityOS to Ladybird QT
2023-06-24 01:36:19 +00:00
auto* dump_history_action = new QAction("Dump &History", this);
dump_history_action->setShortcut(QKeySequence(Qt::CTRL | Qt::Key_H));
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
dump_history_action->setIcon(load_icon_from_uri("resource://icons/16x16/history.png"sv));
Ladybird: Port over part of the "Debug" menu from the SerenityOS browser This is pretty messy, but we have to start somewhere. Eventually we should find a way to share this code with SerenityOS.
2022-07-08 12:14:40 +00:00
debug_menu->addAction(dump_history_action);
QObject::connect(dump_history_action, &QAction::triggered, this, [this] {
debug_request("dump-history");
});
Ladybird: Add missing shortcuts Add the missing shortcuts from Ladybird SerenityOS to Ladybird QT
2023-06-24 01:36:19 +00:00
auto* dump_cookies_action = new QAction("Dump C&ookies", this);
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
dump_cookies_action->setIcon(load_icon_from_uri("resource://icons/browser/cookie.png"sv));
Ladybird: Port over part of the "Debug" menu from the SerenityOS browser This is pretty messy, but we have to start somewhere. Eventually we should find a way to share this code with SerenityOS.
2022-07-08 12:14:40 +00:00
debug_menu->addAction(dump_cookies_action);
QObject::connect(dump_cookies_action, &QAction::triggered, this, [this] {
Ladybird: Hook up the CookieJar again after WebContent introduction
2022-10-11 08:53:28 +00:00
m_cookie_jar.dump_cookies();
Ladybird: Port over part of the "Debug" menu from the SerenityOS browser This is pretty messy, but we have to start somewhere. Eventually we should find a way to share this code with SerenityOS.
2022-07-08 12:14:40 +00:00
});
Ladybird: Add missing shortcuts Add the missing shortcuts from Ladybird SerenityOS to Ladybird QT
2023-06-24 01:36:19 +00:00
auto* dump_local_storage_action = new QAction("Dump Loc&al Storage", this);
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
dump_local_storage_action->setIcon(load_icon_from_uri("resource://icons/browser/local-storage.png"sv));
Ladybird: Port over part of the "Debug" menu from the SerenityOS browser This is pretty messy, but we have to start somewhere. Eventually we should find a way to share this code with SerenityOS.
2022-07-08 12:14:40 +00:00
debug_menu->addAction(dump_local_storage_action);
QObject::connect(dump_local_storage_action, &QAction::triggered, this, [this] {
debug_request("dump-local-storage");
});
debug_menu->addSeparator();
Ladybird/Everywhere: Ensure that Qt objects are created with parents This prevents memory leaks detected by both Valgrind and ASAN/LSAN. Valgrind is still suspicious of the leaked JS::VM from Web::Bindings::main_thread_vm() but there's other issues with leak checking all the GC'd objects. Co-Authored-By: Diego Iastrubni <diegoiast@gmail.com>
2022-10-01 18:46:24 +00:00
auto* show_line_box_borders_action = new QAction("Show Line Box Borders", this);
Ladybird: Port over part of the "Debug" menu from the SerenityOS browser This is pretty messy, but we have to start somewhere. Eventually we should find a way to share this code with SerenityOS.
2022-07-08 12:14:40 +00:00
show_line_box_borders_action->setCheckable(true);
debug_menu->addAction(show_line_box_borders_action);
QObject::connect(show_line_box_borders_action, &QAction::triggered, this, [this, show_line_box_borders_action] {
bool state = show_line_box_borders_action->isChecked();
debug_request("set-line-box-borders", state ? "on" : "off");
});
debug_menu->addSeparator();
Ladybird: Add missing shortcuts Add the missing shortcuts from Ladybird SerenityOS to Ladybird QT
2023-06-24 01:36:19 +00:00
auto* collect_garbage_action = new QAction("Collect &Garbage", this);
Ladybird: Add Ctrl+Shift+G shortcut to force a garbage collection
2022-10-16 13:35:44 +00:00
collect_garbage_action->setShortcut(QKeySequence(Qt::CTRL | Qt::SHIFT | Qt::Key_G));
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
collect_garbage_action->setIcon(load_icon_from_uri("resource://icons/16x16/trash-can.png"sv));
Ladybird: Port over part of the "Debug" menu from the SerenityOS browser This is pretty messy, but we have to start somewhere. Eventually we should find a way to share this code with SerenityOS.
2022-07-08 12:14:40 +00:00
debug_menu->addAction(collect_garbage_action);
QObject::connect(collect_garbage_action, &QAction::triggered, this, [this] {
debug_request("collect-garbage");
});
Ladybird, WebContent: Add option in debug menu to output GC graph dump
2023-08-17 13:43:50 +00:00
auto* dump_gc_graph_action = new QAction("Dump GC graph", this);
debug_menu->addAction(dump_gc_graph_action);
QObject::connect(dump_gc_graph_action, &QAction::triggered, this, [this] {
LibJS+LibWebView+WebContent+Ladybird: Output GC-graph into a file Instead of displaying a massive JSON in stdout, it's more practical to save the GC-graph to a file.
2023-12-12 12:25:06 +00:00
if (m_current_tab) {
auto gc_graph_path = m_current_tab->view().dump_gc_graph();
warnln("\033[33;1mDumped GC-graph into {}"
"\033[0m",
gc_graph_path);
}
Ladybird, WebContent: Add option in debug menu to output GC graph dump
2023-08-17 13:43:50 +00:00
});
Ladybird: Add missing shortcuts Add the missing shortcuts from Ladybird SerenityOS to Ladybird QT
2023-06-24 01:36:19 +00:00
auto* clear_cache_action = new QAction("Clear &Cache", this);
clear_cache_action->setShortcut(QKeySequence(Qt::CTRL | Qt::SHIFT | Qt::Key_C));
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
clear_cache_action->setIcon(load_icon_from_uri("resource://icons/browser/clear-cache.png"sv));
Ladybird: Port over part of the "Debug" menu from the SerenityOS browser This is pretty messy, but we have to start somewhere. Eventually we should find a way to share this code with SerenityOS.
2022-07-08 12:14:40 +00:00
debug_menu->addAction(clear_cache_action);
QObject::connect(clear_cache_action, &QAction::triggered, this, [this] {
debug_request("clear-cache");
});
Ladybird: Add missing shortcuts Add the missing shortcuts from Ladybird SerenityOS to Ladybird QT
2023-06-24 01:36:19 +00:00
auto* spoof_user_agent_menu = debug_menu->addMenu("Spoof &User Agent");
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
spoof_user_agent_menu->setIcon(load_icon_from_uri("resource://icons/16x16/spoof.png"sv));
Ladybird/BrowserWindow: Port user agent spoofing from Browser
2022-09-26 14:57:44 +00:00
auto* user_agent_group = new QActionGroup(this);
Ladybird/Qt: Replace the QString-from-AK helpers with a single method There's no need for 2 overloads for String and DeprecatedString, we can just use a StringView. This also avoids some cases of needlessly allocating a DeprecatedString from a StringView when calling this method.
2023-12-04 14:55:47 +00:00
auto add_user_agent = [this, &user_agent_group, &spoof_user_agent_menu](auto name, auto const& user_agent) {
auto* action = new QAction(qstring_from_ak_string(name), this);
Ladybird/BrowserWindow: Port user agent spoofing from Browser
2022-09-26 14:57:44 +00:00
action->setCheckable(true);
user_agent_group->addAction(action);
spoof_user_agent_menu->addAction(action);
QObject::connect(action, &QAction::triggered, this, [this, user_agent] {
debug_request("spoof-user-agent", user_agent);
debug_request("clear-cache"); // clear the cache to ensure requests are re-done with the new user agent
});
return action;
};
Ladybird/Qt: Replace the QString-from-AK helpers with a single method There's no need for 2 overloads for String and DeprecatedString, we can just use a StringView. This also avoids some cases of needlessly allocating a DeprecatedString from a StringView when calling this method.
2023-12-04 14:55:47 +00:00
auto* disable_spoofing = add_user_agent("Disabled"sv, Web::default_user_agent);
Ladybird/BrowserWindow: Port user agent spoofing from Browser
2022-09-26 14:57:44 +00:00
disable_spoofing->setChecked(true);
Browser+Ladybird: Let the list of user agent strings be shared
2023-09-11 13:49:57 +00:00
for (auto const& user_agent : WebView::user_agents)
Everywhere: Rename {Deprecated => Byte}String This commit un-deprecates DeprecatedString, and repurposes it as a byte string. As the null state has already been removed, there are no other particularly hairy blockers in repurposing this type as a byte string (what it _really_ is). This commit is auto-generated: $ xs=$(ack -l \bDeprecatedString\b\|deprecated_string AK Userland \ Meta Ports Ladybird Tests Kernel) $ perl -pie 's/\bDeprecatedString\b/ByteString/g; s/deprecated_string/byte_string/g' $xs $ clang-format --style=file -i \ $(git diff --name-only | grep \.cpp\|\.h) $ gn format $(git ls-files '*.gn' '*.gni')
2023-12-16 14:19:34 +00:00
add_user_agent(user_agent.key, user_agent.value.to_byte_string());
Ladybird/BrowserWindow: Port user agent spoofing from Browser
2022-09-26 14:57:44 +00:00
Ladybird: Prevent QAction leaking In some places in the code QAction instances are added to a parent directly on instantiation. In the case they are not, Valgrind reports them as leaking.
2023-07-19 16:07:50 +00:00
auto* custom_user_agent_action = new QAction("Custom...", this);
Ladybird/BrowserWindow: Port user agent spoofing from Browser
2022-09-26 14:57:44 +00:00
custom_user_agent_action->setCheckable(true);
user_agent_group->addAction(custom_user_agent_action);
spoof_user_agent_menu->addAction(custom_user_agent_action);
QObject::connect(custom_user_agent_action, &QAction::triggered, this, [this, disable_spoofing] {
auto user_agent = QInputDialog::getText(this, "Custom User Agent", "Enter User Agent:");
if (!user_agent.isEmpty()) {
Everywhere: Rename {Deprecated => Byte}String This commit un-deprecates DeprecatedString, and repurposes it as a byte string. As the null state has already been removed, there are no other particularly hairy blockers in repurposing this type as a byte string (what it _really_ is). This commit is auto-generated: $ xs=$(ack -l \bDeprecatedString\b\|deprecated_string AK Userland \ Meta Ports Ladybird Tests Kernel) $ perl -pie 's/\bDeprecatedString\b/ByteString/g; s/deprecated_string/byte_string/g' $xs $ clang-format --style=file -i \ $(git diff --name-only | grep \.cpp\|\.h) $ gn format $(git ls-files '*.gn' '*.gni')
2023-12-16 14:19:34 +00:00
debug_request("spoof-user-agent", ak_byte_string_from_qstring(user_agent));
Ladybird/BrowserWindow: Port user agent spoofing from Browser
2022-09-26 14:57:44 +00:00
debug_request("clear-cache"); // clear the cache to ensure requests are re-done with the new user agent
} else {
disable_spoofing->activate(QAction::Trigger);
}
});
Ladybird: Port over part of the "Debug" menu from the SerenityOS browser This is pretty messy, but we have to start somewhere. Eventually we should find a way to share this code with SerenityOS.
2022-07-08 12:14:40 +00:00
debug_menu->addSeparator();
Ladybird/Everywhere: Ensure that Qt objects are created with parents This prevents memory leaks detected by both Valgrind and ASAN/LSAN. Valgrind is still suspicious of the leaked JS::VM from Web::Bindings::main_thread_vm() but there's other issues with leak checking all the GC'd objects. Co-Authored-By: Diego Iastrubni <diegoiast@gmail.com>
2022-10-01 18:46:24 +00:00
auto* enable_scripting_action = new QAction("Enable Scripting", this);
Ladybird: Port over part of the "Debug" menu from the SerenityOS browser This is pretty messy, but we have to start somewhere. Eventually we should find a way to share this code with SerenityOS.
2022-07-08 12:14:40 +00:00
enable_scripting_action->setCheckable(true);
enable_scripting_action->setChecked(true);
debug_menu->addAction(enable_scripting_action);
QObject::connect(enable_scripting_action, &QAction::triggered, this, [this, enable_scripting_action] {
bool state = enable_scripting_action->isChecked();
debug_request("scripting", state ? "on" : "off");
});
Ladybird: Add block pop-ups checkbox to debug menu
2022-11-14 23:49:05 +00:00
auto* block_pop_ups_action = new QAction("Block Pop-ups", this);
block_pop_ups_action->setCheckable(true);
block_pop_ups_action->setChecked(true);
debug_menu->addAction(block_pop_ups_action);
QObject::connect(block_pop_ups_action, &QAction::triggered, this, [this, block_pop_ups_action] {
bool state = block_pop_ups_action->isChecked();
debug_request("block-pop-ups", state ? "on" : "off");
});
Ladybird/Everywhere: Ensure that Qt objects are created with parents This prevents memory leaks detected by both Valgrind and ASAN/LSAN. Valgrind is still suspicious of the leaked JS::VM from Web::Bindings::main_thread_vm() but there's other issues with leak checking all the GC'd objects. Co-Authored-By: Diego Iastrubni <diegoiast@gmail.com>
2022-10-01 18:46:24 +00:00
auto* enable_same_origin_policy_action = new QAction("Enable Same-Origin Policy", this);
Ladybird: Port over part of the "Debug" menu from the SerenityOS browser This is pretty messy, but we have to start somewhere. Eventually we should find a way to share this code with SerenityOS.
2022-07-08 12:14:40 +00:00
enable_same_origin_policy_action->setCheckable(true);
debug_menu->addAction(enable_same_origin_policy_action);
QObject::connect(enable_same_origin_policy_action, &QAction::triggered, this, [this, enable_same_origin_policy_action] {
bool state = enable_same_origin_policy_action->isChecked();
debug_request("same-origin-policy", state ? "on" : "off");
});
Ladybird+LibWeb: Add initial about:version internal page
2024-01-12 18:41:26 +00:00
QObject::connect(about_action, &QAction::triggered, this, [this] {
Ladybird/Qt: Rename new_tab to new_tab_from_url and make it take AK::URL Instead of having QString be the API for these load() calls, just pipe AK::URL throughout the UI.
2024-01-31 02:15:55 +00:00
new_tab_from_url("about:version"sv, Web::HTML::ActivateTab::Yes);
Ladybird+LibWeb: Add initial about:version internal page
2024-01-12 18:41:26 +00:00
});
Ladybird: Add URL and 'open in background' parameters to new_tab() This will avoid loading starting about:blank page in places when we know exactly what we want to load. The opening in background part might be useful for future things like file drops and right-click open in new tab.
2023-01-08 10:21:55 +00:00
QObject::connect(new_tab_action, &QAction::triggered, this, [this] {
Ladybird/Qt: Rename new_tab to new_tab_from_url and make it take AK::URL Instead of having QString be the API for these load() calls, just pipe AK::URL throughout the UI.
2024-01-31 02:15:55 +00:00
new_tab_from_url(ak_url_from_qstring(Settings::the()->new_tab_page()), Web::HTML::ActivateTab::Yes);
Ladybird: Add URL and 'open in background' parameters to new_tab() This will avoid loading starting about:blank page in places when we know exactly what we want to load. The opening in background part might be useful for future things like file drops and right-click open in new tab.
2023-01-08 10:21:55 +00:00
});
Ladybird: Add "Open File..." to menu
2023-05-25 21:47:12 +00:00
QObject::connect(open_file_action, &QAction::triggered, this, &BrowserWindow::open_file);
Ladybird: Add SettingsDialog stub
2022-07-14 04:08:30 +00:00
QObject::connect(settings_action, &QAction::triggered, this, [this] {
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
if (!m_settings_dialog) {
m_settings_dialog = new SettingsDialog(this);
}
m_settings_dialog->show();
m_settings_dialog->setFocus();
Ladybird: Add SettingsDialog stub
2022-07-14 04:08:30 +00:00
});
Ladybird: Rudimentary tabbed browsing support This patch removes the browser WebView from the window and places it inside a Tab object, all wrapped up in a QT tab control. So far you can create tabs, but can't close them.
2022-07-05 22:18:21 +00:00
QObject::connect(quit_action, &QAction::triggered, this, &QMainWindow::close);
QObject::connect(m_tabs_container, &QTabWidget::currentChanged, [this](int index) {
Ladybird: Fix title branding when switching tabs
2022-07-12 09:42:40 +00:00
setWindowTitle(QString("%1 - Ladybird").arg(m_tabs_container->tabText(index)));
Ladybird: Show current zoom level in view menu
2023-03-26 17:56:17 +00:00
set_current_tab(verify_cast<Tab>(m_tabs_container->widget(index)));
Ladybird: Rudimentary tabbed browsing support This patch removes the browser WebView from the window and places it inside a Tab object, all wrapped up in a QT tab control. So far you can create tabs, but can't close them.
2022-07-05 22:18:21 +00:00
});
Ladybird: Allow browser tabs to be closed This is a small patch which wires up the tab close button.
2022-07-06 13:36:49 +00:00
QObject::connect(m_tabs_container, &QTabWidget::tabCloseRequested, this, &BrowserWindow::close_tab);
Ladybird: Add Ctrl-W action to close current tab (#28)
2022-07-19 10:16:46 +00:00
QObject::connect(close_current_tab_action, &QAction::triggered, this, &BrowserWindow::close_current_tab);
Ladybird: Add a location bar and allow navigating to new pages :^)
2022-07-03 19:26:51 +00:00
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
m_inspect_dom_node_action = new QAction("&Inspect Element", this);
Ladybird: Move the page context menu from the BrowserWindow to the Tab This will allow us to show different context menus depending on what element is clicked, much like we do for Browser on Serenity.
2023-05-15 15:49:44 +00:00
connect(m_inspect_dom_node_action, &QAction::triggered, this, [this] {
Ladybird: Add common handy actions to context menu This commit adds the common actions you'd expect to the Ladybird context menu, arranged like so: ┌──────────────────────────────┐ │ Go Back Alt+Left │ │ Go Forward Alt+Right │ │ Reload Ctrl+R │ │ ──────────────────────────── │ │ Copy Ctrl+C │ │ Select All Ctrl+A │ │ ──────────────────────────── │ │ View Source Ctrl+U │ │ Inspect Element │ └──────────────────────────────┘
2023-05-13 12:07:12 +00:00
if (m_current_tab)
Ladybird: Move ownership of the JS console/inspector to the tab object This is to match Browser, where ownership of all "subwidgets" is placed on the tab as well. This further lets us align the web view callbacks to match Browser's OOPWV as well, which will later let us move them into the base LibWebView class.
2023-05-17 15:54:36 +00:00
m_current_tab->show_inspector_window(Tab::InspectorTarget::HoveredElement);
Ladybird: Add common handy actions to context menu This commit adds the common actions you'd expect to the Ladybird context menu, arranged like so: ┌──────────────────────────────┐ │ Go Back Alt+Left │ │ Go Forward Alt+Right │ │ Reload Ctrl+R │ │ ──────────────────────────── │ │ Copy Ctrl+C │ │ Select All Ctrl+A │ │ ──────────────────────────── │ │ View Source Ctrl+U │ │ Inspect Element │ └──────────────────────────────┘
2023-05-13 12:07:12 +00:00
});
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
m_go_back_action = new QAction("Go Back", this);
Ladybird: Add common handy actions to context menu This commit adds the common actions you'd expect to the Ladybird context menu, arranged like so: ┌──────────────────────────────┐ │ Go Back Alt+Left │ │ Go Forward Alt+Right │ │ Reload Ctrl+R │ │ ──────────────────────────── │ │ Copy Ctrl+C │ │ Select All Ctrl+A │ │ ──────────────────────────── │ │ View Source Ctrl+U │ │ Inspect Element │ └──────────────────────────────┘
2023-05-13 12:07:12 +00:00
connect(m_go_back_action, &QAction::triggered, this, [this] {
if (m_current_tab)
m_current_tab->back();
});
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
m_go_forward_action = new QAction("Go Forward", this);
Ladybird: Add common handy actions to context menu This commit adds the common actions you'd expect to the Ladybird context menu, arranged like so: ┌──────────────────────────────┐ │ Go Back Alt+Left │ │ Go Forward Alt+Right │ │ Reload Ctrl+R │ │ ──────────────────────────── │ │ Copy Ctrl+C │ │ Select All Ctrl+A │ │ ──────────────────────────── │ │ View Source Ctrl+U │ │ Inspect Element │ └──────────────────────────────┘
2023-05-13 12:07:12 +00:00
connect(m_go_forward_action, &QAction::triggered, this, [this] {
if (m_current_tab)
m_current_tab->forward();
});
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
m_reload_action = new QAction("&Reload", this);
Ladybird: Add common handy actions to context menu This commit adds the common actions you'd expect to the Ladybird context menu, arranged like so: ┌──────────────────────────────┐ │ Go Back Alt+Left │ │ Go Forward Alt+Right │ │ Reload Ctrl+R │ │ ──────────────────────────── │ │ Copy Ctrl+C │ │ Select All Ctrl+A │ │ ──────────────────────────── │ │ View Source Ctrl+U │ │ Inspect Element │ └──────────────────────────────┘
2023-05-13 12:07:12 +00:00
connect(m_reload_action, &QAction::triggered, this, [this] {
if (m_current_tab)
m_current_tab->reload();
});
Ladybird: Move the page context menu from the BrowserWindow to the Tab This will allow us to show different context menus depending on what element is clicked, much like we do for Browser on Serenity.
2023-05-15 15:49:44 +00:00
Ladybird: Add common handy actions to context menu This commit adds the common actions you'd expect to the Ladybird context menu, arranged like so: ┌──────────────────────────────┐ │ Go Back Alt+Left │ │ Go Forward Alt+Right │ │ Reload Ctrl+R │ │ ──────────────────────────── │ │ Copy Ctrl+C │ │ Select All Ctrl+A │ │ ──────────────────────────── │ │ View Source Ctrl+U │ │ Inspect Element │ └──────────────────────────────┘
2023-05-13 12:07:12 +00:00
m_go_back_action->setShortcuts(QKeySequence::keyBindings(QKeySequence::StandardKey::Back));
m_go_forward_action->setShortcuts(QKeySequence::keyBindings(QKeySequence::StandardKey::Forward));
m_reload_action->setShortcuts(QKeySequence::keyBindings(QKeySequence::StandardKey::Refresh));
m_go_back_action->setEnabled(false);
m_go_forward_action->setEnabled(false);
Ladybird: Do not enable the reload button if history is empty Not much of an issue currently, but will be once tabs are used to render plain HTML.
2023-08-28 19:54:36 +00:00
m_reload_action->setEnabled(false);
Ladybird: Add common handy actions to context menu This commit adds the common actions you'd expect to the Ladybird context menu, arranged like so: ┌──────────────────────────────┐ │ Go Back Alt+Left │ │ Go Forward Alt+Right │ │ Reload Ctrl+R │ │ ──────────────────────────── │ │ Copy Ctrl+C │ │ Select All Ctrl+A │ │ ──────────────────────────── │ │ View Source Ctrl+U │ │ Inspect Element │ └──────────────────────────────┘
2023-05-13 12:07:12 +00:00
Ladybird: Add keyboard shortcuts for jumping to a specific tab It's now possible to open a specific tab by using Ctrl/Command plus the number key corresponding to its position in the tab row.
2023-09-20 09:32:37 +00:00
for (int i = 0; i <= 7; ++i) {
new QShortcut(QKeySequence(Qt::CTRL | static_cast<Qt::Key>(Qt::Key_1 + i)), this, [this, i] {
if (m_tabs_container->count() <= 1)
return;
m_tabs_container->setCurrentIndex(min(i, m_tabs_container->count() - 1));
});
}
new QShortcut(QKeySequence(Qt::CTRL | Qt::Key_9), this, [this] {
if (m_tabs_container->count() <= 1)
return;
m_tabs_container->setCurrentIndex(m_tabs_container->count() - 1);
});
Ladybird/Qt: Sanitize user-provided URLs with LibWebView
2023-10-13 13:52:06 +00:00
for (size_t i = 0; i < initial_urls.size(); ++i) {
Ladybird/Qt: Rename new_tab to new_tab_from_url and make it take AK::URL Instead of having QString be the API for these load() calls, just pipe AK::URL throughout the UI.
2024-01-31 02:15:55 +00:00
new_tab_from_url(initial_urls[i], (i == 0) ? Web::HTML::ActivateTab::Yes : Web::HTML::ActivateTab::No);
Ladybird: Only load a single URL at launch When we launch Ladybird, we currently: 1. Create a BrowserWindow, whose constructor navigates to the configured new tab page URL. 2. Then navigate to either "about:blank" or whatever URL is provided via the command line. This patch removes step 2 and forwards the URL from the command line (if any) to BrowserWindow. BrowserWindow's constructor then either navigates to that URL or the new tab page URL.
2023-08-08 19:59:55 +00:00
}
Ladybird: Rudimentary tabbed browsing support This patch removes the browser WebView from the window and places it inside a Tab object, all wrapped up in a QT tab control. So far you can create tabs, but can't close them.
2022-07-05 22:18:21 +00:00
setCentralWidget(m_tabs_container);
Ladybird: Move the page context menu from the BrowserWindow to the Tab This will allow us to show different context menus depending on what element is clicked, much like we do for Browser on Serenity.
2023-05-15 15:49:44 +00:00
setContextMenuPolicy(Qt::PreventContextMenu);
Ladybird: Allow right clicking and inspecting elements This adds "Inspect Element" (currently the only entry) to the context menu for the page, which will do what you expect (most of the time), and bring up the Inspector with hovered element selected.
2023-05-08 20:15:35 +00:00
}
Ladybird: Show current zoom level in view menu
2023-03-26 17:56:17 +00:00
void BrowserWindow::set_current_tab(Tab* tab)
{
m_current_tab = tab;
Ladybird: Don't update the zoom menu text for null tabs This fixes an "Assertion `m_zoom_menu && m_current_tab' failed." error when closing a window.
2023-03-27 17:29:47 +00:00
if (tab)
Ladybird: Add reset zoom level button to toolbar This is a port of the Browser feature.
2023-03-28 23:25:42 +00:00
update_displayed_zoom_level();
Ladybird: Show current zoom level in view menu
2023-03-26 17:56:17 +00:00
}
Everywhere: Rename {Deprecated => Byte}String This commit un-deprecates DeprecatedString, and repurposes it as a byte string. As the null state has already been removed, there are no other particularly hairy blockers in repurposing this type as a byte string (what it _really_ is). This commit is auto-generated: $ xs=$(ack -l \bDeprecatedString\b\|deprecated_string AK Userland \ Meta Ports Ladybird Tests Kernel) $ perl -pie 's/\bDeprecatedString\b/ByteString/g; s/deprecated_string/byte_string/g' $xs $ clang-format --style=file -i \ $(git diff --name-only | grep \.cpp\|\.h) $ gn format $(git ls-files '*.gn' '*.gni')
2023-12-16 14:19:34 +00:00
void BrowserWindow::debug_request(ByteString const& request, ByteString const& argument)
Ladybird: Port over part of the "Debug" menu from the SerenityOS browser This is pretty messy, but we have to start somewhere. Eventually we should find a way to share this code with SerenityOS.
2022-07-08 12:14:40 +00:00
{
if (!m_current_tab)
return;
m_current_tab->debug_request(request, argument);
}
AK+LibURL: Move AK::URL into a new URL library This URL library ends up being a relatively fundamental base library of the system, as LibCore depends on LibURL. This change has two main benefits: * Moving AK back more towards being an agnostic library that can be used between the kernel and userspace. URL has never really fit that description - and is not used in the kernel. * URL _should_ depend on LibUnicode, as it needs punnycode support. However, it's not really possible to do this inside of AK as it can't depend on any external library. This change brings us a little closer to being able to do that, but unfortunately we aren't there quite yet, as the code generators depend on LibCore.
2024-03-18 03:22:27 +00:00
Tab& BrowserWindow::new_tab_from_url(URL::URL const& url, Web::HTML::ActivateTab activate_tab)
Ladybird: Allow creating new tabs with plain HTML This will allow us to internally create a new tab with HTML, to be used by the View Source command.
2023-08-28 20:14:34 +00:00
{
auto& tab = create_new_tab(activate_tab);
tab.navigate(url);
return tab;
}
Ladybird/Qt: Rename new_tab(StringView) to new_tab_from_content Having an overload of new_tab with StringView and QString that each do very different things is uncomfortable, to say the least.
2024-01-31 01:52:59 +00:00
Tab& BrowserWindow::new_tab_from_content(StringView html, Web::HTML::ActivateTab activate_tab)
Ladybird: Allow creating new tabs with plain HTML This will allow us to internally create a new tab with HTML, to be used by the View Source command.
2023-08-28 20:14:34 +00:00
{
auto& tab = create_new_tab(activate_tab);
Userland+Ladybird: Always specify url to be about:srcdoc in load_html() After moving to navigables, we started reusing the code that populates session history entries with the srcdoc attribute value from iframes in `Page::load_html()` for loading HTML. This change addresses a crash in `determine_the_origin` which occurred because this method expected the URL to be `about:srcdoc` if we also provided HTML content (previously, it was the URL passed along with the HTML content into `load_html()`).
2023-09-17 15:12:17 +00:00
tab.load_html(html);
Ladybird: Allow creating new tabs with plain HTML This will allow us to internally create a new tab with HTML, to be used by the View Source command.
2023-08-28 20:14:34 +00:00
return tab;
}
Ladybird: Add IPC call for creating a new child tab This will be used for choosing a navigable that requires opening a new tab or new window. Such as calls to window.open(), or specific WebDriver calls.
2024-01-31 03:05:00 +00:00
Tab& BrowserWindow::new_child_tab(Web::HTML::ActivateTab activate_tab, Tab& parent, Web::HTML::WebViewHints hints, Optional<u64> page_index)
{
return create_new_tab(activate_tab, parent, hints, page_index);
}
Tab& BrowserWindow::create_new_tab(Web::HTML::ActivateTab activate_tab, Tab& parent, Web::HTML::WebViewHints, Optional<u64> page_index)
{
if (!page_index.has_value())
return create_new_tab(activate_tab);
// FIXME: Respect hints for:
// popup: Create new window
// width, height: size of window
// screen_x, screen_y: positioning of window on the screen
auto* tab = new Tab(this, m_web_content_options, m_webdriver_content_ipc_path, parent.view().client(), page_index.value());
VERIFY(m_current_tab != nullptr);
m_tabs_container->addTab(tab, "New Tab");
if (activate_tab == Web::HTML::ActivateTab::Yes)
m_tabs_container->setCurrentWidget(tab);
initialize_tab(tab);
return *tab;
}
Ladybird: Allow creating new tabs with plain HTML This will allow us to internally create a new tab with HTML, to be used by the View Source command.
2023-08-28 20:14:34 +00:00
Tab& BrowserWindow::create_new_tab(Web::HTML::ActivateTab activate_tab)
Ladybird: Rudimentary tabbed browsing support This patch removes the browser WebView from the window and places it inside a Tab object, all wrapped up in a QT tab control. So far you can create tabs, but can't close them.
2022-07-05 22:18:21 +00:00
{
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
auto* tab = new Tab(this, m_web_content_options, m_webdriver_content_ipc_path);
Ladybird: Add a location bar and allow navigating to new pages :^)
2022-07-03 19:26:51 +00:00
Ladybird: Rudimentary tabbed browsing support This patch removes the browser WebView from the window and places it inside a Tab object, all wrapped up in a QT tab control. So far you can create tabs, but can't close them.
2022-07-05 22:18:21 +00:00
if (m_current_tab == nullptr) {
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
set_current_tab(tab);
Ladybird: Rudimentary tabbed browsing support This patch removes the browser WebView from the window and places it inside a Tab object, all wrapped up in a QT tab control. So far you can create tabs, but can't close them.
2022-07-05 22:18:21 +00:00
}
Ladybird: Add a location bar and allow navigating to new pages :^)
2022-07-03 19:26:51 +00:00
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
m_tabs_container->addTab(tab, "New Tab");
WebContent+Everywhere: Add an option to not activate new tabs over IPC WebDriver, for example, will want to create new tabs without activating them.
2023-03-20 22:39:20 +00:00
if (activate_tab == Web::HTML::ActivateTab::Yes)
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
m_tabs_container->setCurrentWidget(tab);
Ladybird: Add IPC call for creating a new child tab This will be used for choosing a navigable that requires opening a new tab or new window. Such as calls to window.open(), or specific WebDriver calls.
2024-01-31 03:05:00 +00:00
initialize_tab(tab);
return *tab;
}
void BrowserWindow::initialize_tab(Tab* tab)
{
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
QObject::connect(tab, &Tab::title_changed, this, &BrowserWindow::tab_title_changed);
QObject::connect(tab, &Tab::favicon_changed, this, &BrowserWindow::tab_favicon_changed);
Ladybird/Qt: Display an audio button on tabs that are playing audio When audio begins playing, add a button to the left of the favicon with a speaker icon to indicate which tab is playing audio. This button is currently disabled, but in the future may be used to mute the tab.
2024-03-28 15:16:10 +00:00
QObject::connect(tab, &Tab::audio_play_state_changed, this, &BrowserWindow::tab_audio_play_state_changed);
Ladybird: Hide TabBar if count <= 1
2022-07-12 09:41:11 +00:00
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
QObject::connect(&tab->view(), &WebContentView::urls_dropped, this, [this](auto& urls) {
Ladybird: Accept file drops
2023-01-07 16:40:04 +00:00
VERIFY(urls.size());
Ladybird/Qt: Rename new_tab to new_tab_from_url and make it take AK::URL Instead of having QString be the API for these load() calls, just pipe AK::URL throughout the UI.
2024-01-31 02:15:55 +00:00
m_current_tab->navigate(ak_url_from_qurl(urls[0]));
Ladybird: Accept file drops
2023-01-07 16:40:04 +00:00
for (qsizetype i = 1; i < urls.size(); ++i)
Ladybird/Qt: Rename new_tab to new_tab_from_url and make it take AK::URL Instead of having QString be the API for these load() calls, just pipe AK::URL throughout the UI.
2024-01-31 02:15:55 +00:00
new_tab_from_url(ak_url_from_qurl(urls[i]), Web::HTML::ActivateTab::No);
Ladybird: Accept file drops
2023-01-07 16:40:04 +00:00
});
Ladybird: Add IPC call for creating a new child tab This will be used for choosing a navigable that requires opening a new tab or new window. Such as calls to window.open(), or specific WebDriver calls.
2024-01-31 03:05:00 +00:00
tab->view().on_new_web_view = [this, tab](auto activate_tab, Web::HTML::WebViewHints hints, Optional<u64> page_index) {
auto& new_tab = new_child_tab(activate_tab, *tab, hints, page_index);
return new_tab.view().handle();
Ladybird: Implement `notify_request_open_new_tab`
2023-03-14 14:19:28 +00:00
};
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
tab->view().on_tab_open_request = [this](auto url, auto activate_tab) {
Ladybird/Qt: Rename new_tab to new_tab_from_url and make it take AK::URL Instead of having QString be the API for these load() calls, just pipe AK::URL throughout the UI.
2024-01-31 02:15:55 +00:00
auto& tab = new_tab_from_url(url, activate_tab);
Ladybird: Open target _blank links in new tab
2023-03-23 00:24:15 +00:00
return tab.view().handle();
};
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
tab->view().on_link_click = [this](auto url, auto target, unsigned modifiers) {
Ladybird: Open target _blank links in new tab
2023-03-23 00:24:15 +00:00
// TODO: maybe activate tabs according to some configuration, this is just normal current browser behavior
if (modifiers == Mod_Ctrl) {
m_current_tab->view().on_tab_open_request(url, Web::HTML::ActivateTab::No);
} else if (target == "_blank") {
m_current_tab->view().on_tab_open_request(url, Web::HTML::ActivateTab::Yes);
Ladybird: Add a context menu for video elements
2023-05-15 16:27:10 +00:00
} else {
m_current_tab->view().load(url);
Ladybird: Open target _blank links in new tab
2023-03-23 00:24:15 +00:00
}
};
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
tab->view().on_link_middle_click = [this](auto url, auto target, unsigned modifiers) {
Ladybird: Open target _blank links in new tab
2023-03-23 00:24:15 +00:00
m_current_tab->view().on_link_click(url, target, Mod_Ctrl);
(void)modifiers;
};
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
tab->view().on_get_all_cookies = [this](auto const& url) {
Ladybird/WebDriver: Implement the cookie endpoints for Ladybird
2022-11-14 22:23:35 +00:00
return m_cookie_jar.get_all_cookies(url);
};
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
tab->view().on_get_named_cookie = [this](auto const& url, auto const& name) {
Ladybird/WebDriver: Implement the cookie endpoints for Ladybird
2022-11-14 22:23:35 +00:00
return m_cookie_jar.get_named_cookie(url, name);
};
Ladybird+LibWeb+WebContent: Port the `did_request_cookie` IPC to String
2024-01-26 16:10:15 +00:00
tab->view().on_get_cookie = [this](auto& url, auto source) {
Ladybird: Hook up the CookieJar again after WebContent introduction
2022-10-11 08:53:28 +00:00
return m_cookie_jar.get_cookie(url, source);
};
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
tab->view().on_set_cookie = [this](auto& url, auto& cookie, auto source) {
Ladybird: Hook up the CookieJar again after WebContent introduction
2022-10-11 08:53:28 +00:00
m_cookie_jar.set_cookie(url, cookie, source);
};
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
tab->view().on_update_cookie = [this](auto const& cookie) {
Ladybird: Do not domain match on cookie updates This matches a corresponding change to Serenity's Browser.
2022-12-05 15:15:41 +00:00
m_cookie_jar.update_cookie(cookie);
Ladybird/WebDriver: Implement the cookie endpoints for Ladybird
2022-11-14 22:23:35 +00:00
};
Ladybird/Qt: Display a default favicon and title This ensures we consistently show a favicon and that we update the title to at least display the page URL when there isn't a <title> tag. We would otherwise continue displaying the previous page's title.
2024-03-28 15:11:02 +00:00
m_tabs_container->setTabIcon(m_tabs_container->indexOf(tab), tab->favicon());
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
tab->focus_location_editor();
Ladybird: Add a location bar and allow navigating to new pages :^)
2022-07-03 19:26:51 +00:00
}
WebContent+Everywhere: Add a WebContent IPC to activate a tab
2023-03-20 23:52:00 +00:00
void BrowserWindow::activate_tab(int index)
{
m_tabs_container->setCurrentIndex(index);
}
Ladybird: Allow browser tabs to be closed This is a small patch which wires up the tab close button.
2022-07-06 13:36:49 +00:00
void BrowserWindow::close_tab(int index)
{
auto* tab = m_tabs_container->widget(index);
m_tabs_container->removeTab(index);
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
tab->deleteLater();
Ladybird: Allow browser tabs to be closed This is a small patch which wires up the tab close button.
2022-07-06 13:36:49 +00:00
}
Ladybird: Add "Open File..." to menu
2023-05-25 21:47:12 +00:00
void BrowserWindow::open_file()
{
m_current_tab->open_file();
}
Ladybird: Add Ctrl-W action to close current tab (#28)
2022-07-19 10:16:46 +00:00
void BrowserWindow::close_current_tab()
{
Ladybird: Close the current tab even if we're closing the window Currently, if the JS console is open and tied to the last opened tab in the browser window, it will prevent the main process from exiting when the last tab is closed. This change explicitly closes that tab before closing the window (if it's the last tab), allowing Qt to delete the Tab object.
2023-08-08 22:42:18 +00:00
close_tab(m_tabs_container->currentIndex());
if (m_tabs_container->count() == 0)
Ladybird: Add Ctrl-W action to close current tab (#28)
2022-07-19 10:16:46 +00:00
close();
}
Ladybird: Rudimentary tabbed browsing support This patch removes the browser WebView from the window and places it inside a Tab object, all wrapped up in a QT tab control. So far you can create tabs, but can't close them.
2022-07-05 22:18:21 +00:00
int BrowserWindow::tab_index(Tab* tab)
Ladybird: Add a location bar and allow navigating to new pages :^)
2022-07-03 19:26:51 +00:00
{
Ladybird: Rudimentary tabbed browsing support This patch removes the browser WebView from the window and places it inside a Tab object, all wrapped up in a QT tab control. So far you can create tabs, but can't close them.
2022-07-05 22:18:21 +00:00
return m_tabs_container->indexOf(tab);
Ladybird: Add a location bar and allow navigating to new pages :^)
2022-07-03 19:26:51 +00:00
}
Ladybird: Show the web page title in the window titlebar :^)
2022-07-04 00:11:58 +00:00
Ladybird/Qt: Listen to DPI changes and update WebContentView accordingly
2023-12-13 18:10:05 +00:00
void BrowserWindow::device_pixel_ratio_changed(qreal dpi)
{
m_device_pixel_ratio = dpi;
for_each_tab([this](auto& tab) {
tab.view().set_device_pixel_ratio(m_device_pixel_ratio);
});
}
Ladybird: Rudimentary tabbed browsing support This patch removes the browser WebView from the window and places it inside a Tab object, all wrapped up in a QT tab control. So far you can create tabs, but can't close them.
2022-07-05 22:18:21 +00:00
void BrowserWindow::tab_title_changed(int index, QString const& title)
Ladybird: Show the web page title in the window titlebar :^)
2022-07-04 00:11:58 +00:00
{
Browser+Ladybird+LibWebView: Consolidate title handling in LibWebView Namely, let's have empty titles behave the same in both Browser and Ladybird (display the URL).
2023-06-07 20:37:30 +00:00
m_tabs_container->setTabText(index, title);
if (m_tabs_container->currentIndex() == index)
setWindowTitle(QString("%1 - Ladybird").arg(title));
Ladybird: Show the web page title in the window titlebar :^)
2022-07-04 00:11:58 +00:00
}
Ladybird: Add Favicon to the window
2022-07-05 04:53:11 +00:00
Ladybird: Pass QIcon by reference in `tab_favicon_changed`
2023-05-29 09:05:40 +00:00
void BrowserWindow::tab_favicon_changed(int index, QIcon const& icon)
Ladybird: Add Favicon to the window
2022-07-05 04:53:11 +00:00
{
Ladybird: Rudimentary tabbed browsing support This patch removes the browser WebView from the window and places it inside a Tab object, all wrapped up in a QT tab control. So far you can create tabs, but can't close them.
2022-07-05 22:18:21 +00:00
m_tabs_container->setTabIcon(index, icon);
Ladybird: Add Favicon to the window
2022-07-05 04:53:11 +00:00
}
Ladybird: Switch to next/previous tab with Ctrl+PageDown/PageUp
2022-09-12 07:22:43 +00:00
Ladybird/Qt: Display an audio button on tabs that are playing audio When audio begins playing, add a button to the left of the favicon with a speaker icon to indicate which tab is playing audio. This button is currently disabled, but in the future may be used to mute the tab.
2024-03-28 15:16:10 +00:00
void BrowserWindow::tab_audio_play_state_changed(int index, Web::HTML::AudioPlayState play_state)
{
switch (play_state) {
case Web::HTML::AudioPlayState::Paused:
Ladybird/Qt: Support muting an entire page We already display a speaker icon on tabs which are playing audio. This allows the user to click that icon to mute the tab, at which point the icon is replaced with a muted speaker icon. We would previously hide the icon when audio stopped playing. We now do this only if the tab isn't muted. If it is muted, the muted speaker icon remains on the tab so that the page isn't stuck in a muted state.
2024-03-30 13:48:33 +00:00
if (view().page_mute_state() == Web::HTML::MuteState::Unmuted)
m_tabs_container->tabBar()->setTabButton(index, QTabBar::LeftSide, nullptr);
Ladybird/Qt: Display an audio button on tabs that are playing audio When audio begins playing, add a button to the left of the favicon with a speaker icon to indicate which tab is playing audio. This button is currently disabled, but in the future may be used to mute the tab.
2024-03-28 15:16:10 +00:00
break;
case Web::HTML::AudioPlayState::Playing:
Ladybird/Qt: Support muting an entire page We already display a speaker icon on tabs which are playing audio. This allows the user to click that icon to mute the tab, at which point the icon is replaced with a muted speaker icon. We would previously hide the icon when audio stopped playing. We now do this only if the tab isn't muted. If it is muted, the muted speaker icon remains on the tab so that the page isn't stuck in a muted state.
2024-03-30 13:48:33 +00:00
auto* button = new QPushButton(icon_for_page_mute_state(), {});
Ladybird/Qt: Display an audio button on tabs that are playing audio When audio begins playing, add a button to the left of the favicon with a speaker icon to indicate which tab is playing audio. This button is currently disabled, but in the future may be used to mute the tab.
2024-03-28 15:16:10 +00:00
button->setFlat(true);
button->resize({ 20, 20 });
Ladybird/Qt: Support muting an entire page We already display a speaker icon on tabs which are playing audio. This allows the user to click that icon to mute the tab, at which point the icon is replaced with a muted speaker icon. We would previously hide the icon when audio stopped playing. We now do this only if the tab isn't muted. If it is muted, the muted speaker icon remains on the tab so that the page isn't stuck in a muted state.
2024-03-30 13:48:33 +00:00
connect(button, &QPushButton::clicked, this, [this, index]() {
view().toggle_page_mute_state();
switch (view().audio_play_state()) {
case Web::HTML::AudioPlayState::Paused:
m_tabs_container->tabBar()->setTabButton(index, QTabBar::LeftSide, nullptr);
break;
case Web::HTML::AudioPlayState::Playing:
auto* button = m_tabs_container->tabBar()->tabButton(index, QTabBar::LeftSide);
verify_cast<QPushButton>(button)->setIcon(icon_for_page_mute_state());
break;
}
});
Ladybird/Qt: Display an audio button on tabs that are playing audio When audio begins playing, add a button to the left of the favicon with a speaker icon to indicate which tab is playing audio. This button is currently disabled, but in the future may be used to mute the tab.
2024-03-28 15:16:10 +00:00
m_tabs_container->tabBar()->setTabButton(index, QTabBar::LeftSide, button);
break;
}
}
Ladybird/Qt: Support muting an entire page We already display a speaker icon on tabs which are playing audio. This allows the user to click that icon to mute the tab, at which point the icon is replaced with a muted speaker icon. We would previously hide the icon when audio stopped playing. We now do this only if the tab isn't muted. If it is muted, the muted speaker icon remains on the tab so that the page isn't stuck in a muted state.
2024-03-30 13:48:33 +00:00
QIcon BrowserWindow::icon_for_page_mute_state() const
{
switch (view().page_mute_state()) {
case Web::HTML::MuteState::Muted:
return style()->standardIcon(QStyle::SP_MediaVolumeMuted);
case Web::HTML::MuteState::Unmuted:
return style()->standardIcon(QStyle::SP_MediaVolume);
}
VERIFY_NOT_REACHED();
}
Ladybird: Switch to next/previous tab with Ctrl+PageDown/PageUp
2022-09-12 07:22:43 +00:00
void BrowserWindow::open_next_tab()
{
if (m_tabs_container->count() <= 1)
return;
auto next_index = m_tabs_container->currentIndex() + 1;
if (next_index >= m_tabs_container->count())
next_index = 0;
m_tabs_container->setCurrentIndex(next_index);
}
void BrowserWindow::open_previous_tab()
{
if (m_tabs_container->count() <= 1)
return;
auto next_index = m_tabs_container->currentIndex() - 1;
if (next_index < 0)
next_index = m_tabs_container->count() - 1;
m_tabs_container->setCurrentIndex(next_index);
}
Ladybird/BrowserWindow: Add UI for switching preferred CSS color scheme
2022-09-19 08:48:02 +00:00
void BrowserWindow::enable_auto_color_scheme()
{
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
for_each_tab([](auto& tab) {
tab.view().set_preferred_color_scheme(Web::CSS::PreferredColorScheme::Auto);
});
Ladybird/BrowserWindow: Add UI for switching preferred CSS color scheme
2022-09-19 08:48:02 +00:00
}
void BrowserWindow::enable_light_color_scheme()
{
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
for_each_tab([](auto& tab) {
tab.view().set_preferred_color_scheme(Web::CSS::PreferredColorScheme::Light);
});
Ladybird/BrowserWindow: Add UI for switching preferred CSS color scheme
2022-09-19 08:48:02 +00:00
}
void BrowserWindow::enable_dark_color_scheme()
{
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
for_each_tab([](auto& tab) {
tab.view().set_preferred_color_scheme(Web::CSS::PreferredColorScheme::Dark);
});
Ladybird/BrowserWindow: Add UI for switching preferred CSS color scheme
2022-09-19 08:48:02 +00:00
}
Ladybird: Implement zoom :^)
2023-01-12 14:39:53 +00:00
void BrowserWindow::zoom_in()
{
Ladybird: Show current zoom level in view menu
2023-03-26 17:56:17 +00:00
if (!m_current_tab)
return;
m_current_tab->view().zoom_in();
Ladybird: Add reset zoom level button to toolbar This is a port of the Browser feature.
2023-03-28 23:25:42 +00:00
update_displayed_zoom_level();
Ladybird: Implement zoom :^)
2023-01-12 14:39:53 +00:00
}
void BrowserWindow::zoom_out()
{
Ladybird: Show current zoom level in view menu
2023-03-26 17:56:17 +00:00
if (!m_current_tab)
return;
m_current_tab->view().zoom_out();
Ladybird: Add reset zoom level button to toolbar This is a port of the Browser feature.
2023-03-28 23:25:42 +00:00
update_displayed_zoom_level();
Ladybird: Implement zoom :^)
2023-01-12 14:39:53 +00:00
}
void BrowserWindow::reset_zoom()
{
Ladybird: Show current zoom level in view menu
2023-03-26 17:56:17 +00:00
if (!m_current_tab)
return;
m_current_tab->view().reset_zoom();
Ladybird: Add reset zoom level button to toolbar This is a port of the Browser feature.
2023-03-28 23:25:42 +00:00
update_displayed_zoom_level();
Ladybird: Implement zoom :^)
2023-01-12 14:39:53 +00:00
}
Ladybird: Add "Copy" and "Select All" actions to the Edit menu
2023-01-11 19:09:52 +00:00
Ladybird+Browser: Update zoom text on menu after clicking zoom button
2023-08-04 11:37:52 +00:00
void BrowserWindow::update_zoom_menu()
{
VERIFY(m_zoom_menu);
auto zoom_level_text = MUST(String::formatted("&Zoom ({}%)", round_to<int>(m_current_tab->view().zoom_level() * 100)));
m_zoom_menu->setTitle(qstring_from_ak_string(zoom_level_text));
}
Ladybird: Add "Copy" and "Select All" actions to the Edit menu
2023-01-11 19:09:52 +00:00
void BrowserWindow::select_all()
{
Ladybird: Implement the JavaScript console using a WebContentView This aligns the Ladybird console implementation with the Browser console a bit more, which uses OutOfProcessWebView for rendering console output. This allows us to style the console output to try and match the system theme. Using a WebContentView is simpler than trying to style the old QTextEdit widget, as the console output is HTML with built-in "-libweb-palette-*" colors. These will override any color we set on the QTextEdit widget.
2023-04-23 01:57:08 +00:00
if (!m_current_tab)
return;
Ladybird/Qt: Remove the standalone JavaScript console
2023-12-01 12:07:01 +00:00
m_current_tab->view().select_all();
Ladybird: Add "Copy" and "Select All" actions to the Edit menu
2023-01-11 19:09:52 +00:00
}
LibWeb+WebContent+Ladybird: Add ability to paste text from clipboard Text can be pasted by pressing Ctrl/Cmd+V or by using button in the context menu. For now only the Qt client is supported.
2024-03-22 10:56:49 +00:00
void BrowserWindow::paste()
{
if (!m_current_tab)
return;
auto* clipboard = QGuiApplication::clipboard();
m_current_tab->view().paste(ak_string_from_qstring(clipboard->text()));
}
Ladybird: Add reset zoom level button to toolbar This is a port of the Browser feature.
2023-03-28 23:25:42 +00:00
void BrowserWindow::update_displayed_zoom_level()
Ladybird: Show current zoom level in view menu
2023-03-26 17:56:17 +00:00
{
Ladybird+Browser: Update zoom text on menu after clicking zoom button
2023-08-04 11:37:52 +00:00
VERIFY(m_current_tab);
update_zoom_menu();
Ladybird: Add reset zoom level button to toolbar This is a port of the Browser feature.
2023-03-28 23:25:42 +00:00
m_current_tab->update_reset_zoom_button();
Ladybird: Show current zoom level in view menu
2023-03-26 17:56:17 +00:00
}
Ladybird: Add "Copy" and "Select All" actions to the Edit menu
2023-01-11 19:09:52 +00:00
void BrowserWindow::copy_selected_text()
{
Ladybird: Implement the JavaScript console using a WebContentView This aligns the Ladybird console implementation with the Browser console a bit more, which uses OutOfProcessWebView for rendering console output. This allows us to style the console output to try and match the system theme. Using a WebContentView is simpler than trying to style the old QTextEdit widget, as the console output is HTML with built-in "-libweb-palette-*" colors. These will override any color we set on the QTextEdit widget.
2023-04-23 01:57:08 +00:00
if (!m_current_tab)
return;
Ladybird/Qt: Remove the standalone JavaScript console
2023-12-01 12:07:01 +00:00
auto text = m_current_tab->view().selected_text();
Ladybird: Implement the JavaScript console using a WebContentView This aligns the Ladybird console implementation with the Browser console a bit more, which uses OutOfProcessWebView for rendering console output. This allows us to style the console output to try and match the system theme. Using a WebContentView is simpler than trying to style the old QTextEdit widget, as the console output is HTML with built-in "-libweb-palette-*" colors. These will override any color we set on the QTextEdit widget.
2023-04-23 01:57:08 +00:00
auto* clipboard = QGuiApplication::clipboard();
Ladybird/Qt: Replace the QString-from-AK helpers with a single method There's no need for 2 overloads for String and DeprecatedString, we can just use a StringView. This also avoids some cases of needlessly allocating a DeprecatedString from a StringView when calling this method.
2023-12-04 14:55:47 +00:00
clipboard->setText(qstring_from_ak_string(text));
Ladybird: Add "Copy" and "Select All" actions to the Edit menu
2023-01-11 19:09:52 +00:00
}
Ladybird: Close tab clicking wheel of the mouse
2023-02-05 02:26:20 +00:00
Ladybird/Qt: Properly listen for DPI changes on Wayland Some Wayland compositors have support of fractional-scale-v1 protocol. The protocol allows compositor to announce a preferred fractional scale on a per-wl_surface basis. Qt forwards these Wayland events to an application using a usual DevicePixelRatioChange event. However, in contrast to the other platforms, this DevicePixelRatioChange event is issued directly on widgets and not screens. Additionally, the exact fractional scale is stored in QWindow object and not the current screen. Note that in theory it is possible to obtain per-screen fractional scaling on Wayland by interpolating data provided by wl_output and xdg_output events but qtwayland does not do that. If fractional-scale-v1 is not available, qtwayland will still fire per-Widget DevicePixelRatioChange events, but, obviously, with the per-screen possibly larger ceiled scaling. This whole thing makes handling DPI changes on Wayland really simple. All we need to do is to intercept DevicePixelRatioChange events firing on QWindow objects and call the old device_pixel_ratio_changed handler with the window's devicePixelRatio(). The only caveat here is not forget to always set QWidget's parent before calling devicePixelRatio() on it.
2024-01-27 04:14:41 +00:00
bool BrowserWindow::event(QEvent* event)
{
#if QT_VERSION >= QT_VERSION_CHECK(6, 6, 0)
if (event->type() == QEvent::DevicePixelRatioChange) {
if (m_device_pixel_ratio != devicePixelRatio())
device_pixel_ratio_changed(devicePixelRatio());
}
#endif
return QMainWindow::event(event);
}
Ladybird: Send window size and position to WebContent process
2023-03-08 20:57:24 +00:00
void BrowserWindow::resizeEvent(QResizeEvent* event)
{
QWidget::resizeEvent(event);
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
for_each_tab([&](auto& tab) {
LibWeb: Refactor int types in WebContentServer to DevicePixels
2023-12-14 06:17:00 +00:00
tab.view().set_window_size({ frameSize().width() * m_device_pixel_ratio, frameSize().height() * m_device_pixel_ratio });
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
});
Ladybird: Send window size and position to WebContent process
2023-03-08 20:57:24 +00:00
}
void BrowserWindow::moveEvent(QMoveEvent* event)
{
QWidget::moveEvent(event);
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
for_each_tab([&](auto& tab) {
LibWeb: Refactor int types in WebContentServer to DevicePixels
2023-12-14 06:17:00 +00:00
tab.view().set_window_position({ event->pos().x() * m_device_pixel_ratio, event->pos().y() * m_device_pixel_ratio });
Ladybird/Qt: Do not "share" ownership of Qt objects When a QObject subclass (widgets, etc.) are provided a parent, then ownership of that object is passed to the parent. Similarly, objects added to a QLayout are owned by the layout. Thus, do not store these objects in an OwnPtr.
2023-12-04 14:39:22 +00:00
});
Ladybird: Send window size and position to WebContent process
2023-03-08 20:57:24 +00:00
}
Ladybird: Add initial support for Ctrl+Scroll to zoom in/out This commit adds basic functionality to zoom in/out using the Ctrl+Scroll shortcut.
2023-06-30 22:33:04 +00:00
void BrowserWindow::wheelEvent(QWheelEvent* event)
{
if ((event->modifiers() & Qt::ControlModifier) != 0) {
if (event->angleDelta().y() > 0)
zoom_in();
else if (event->angleDelta().y() < 0)
zoom_out();
}
}
Ladybird: Close tab clicking wheel of the mouse
2023-02-05 02:26:20 +00:00
bool BrowserWindow::eventFilter(QObject* obj, QEvent* event)
{
if (event->type() == QEvent::MouseButtonRelease) {
auto const* const mouse_event = static_cast<QMouseEvent*>(event);
if (mouse_event->button() == Qt::MouseButton::MiddleButton) {
if (obj == m_tabs_container) {
auto const tab_index = m_tabs_container->tabBar()->tabAt(mouse_event->pos());
close_tab(tab_index);
return true;
}
}
}
return QMainWindow::eventFilter(obj, event);
}
Ladybird: Move classes and types into the Ladybird namespace We were super inconsistent about this, with most "new" classes living in the Ladybird namespace, while "old" ones were in the global namespace, or even sitting in the Browser namespace.
2023-08-02 17:52:59 +00:00
Ladybird: Remember window position and size on close
2023-08-09 10:23:32 +00:00
void BrowserWindow::closeEvent(QCloseEvent* event)
{
Ladybird: Convert `Browser::Settings` to a singleton
2023-05-29 09:05:30 +00:00
Settings::the()->set_last_position(pos());
Settings::the()->set_last_size(size());
Settings::the()->set_is_maximized(isMaximized());
Ladybird: Remember window position and size on close
2023-08-09 10:23:32 +00:00
QMainWindow::closeEvent(event);
}
Ladybird: Move classes and types into the Ladybird namespace We were super inconsistent about this, with most "new" classes living in the Ladybird namespace, while "old" ones were in the global namespace, or even sitting in the Browser namespace.
2023-08-02 17:52:59 +00:00
}
Reference in a new issue Copy permalink