beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6
ladybird/Ladybird/CMakeLists.txt

300 lines
11 KiB
Text
Raw Normal View History

CMake: Make sure to install generated sources and header files We weren't installing a lot of generated sources for the top level Lagom build or for LibWeb, making it impossible to use LibWeb from a find_package. ...And also Kernel/API/KeyCode.h, which is included by no less than 8 different files in Userland/Libraries. We also weren't installing any Ladybird header files.
2023-08-08 04:14:22 +00:00
cmake_minimum_required(VERSION 3.23)
Ladybird/Meta: Convert to CMake build
2022-07-04 11:45:18 +00:00
project(ladybird
VERSION 0.0.1
LANGUAGES CXX
DESCRIPTION "Ladybird Web Browser"
)
Ladybird/CMake: Install resources and Lagom libraries alongside ladybird This setup should allow the package maintainers who are looking to distribute ladybird on their distributions to use CMake to install ladybird using cmake install rules rather than having to write their own
2022-09-16 10:08:24 +00:00
include(GNUInstallDirs)
AK+Lagom: Make it possible to build for iOS This commit makes it possible to build AK and most of Lagom for iOS, based on the work for the Ladybird build demoed on discord: https://discord.com/channels/830522505605283862/830525031720943627/1211987732646068314
2024-02-27 13:32:29 +00:00
if (ANDROID OR IOS)
Ladybird/Meta: Add Android build Build an Android APK file that, when configured properly in Qt Creator, can be used to deploy the browser to an Android device. The current build requires NDK 24, targets no less than Android API 30, and Qt Creator 6.4.0.
2022-07-11 07:14:53 +00:00
set(BUILD_SHARED_LIBS OFF)
endif()
CMake: Remove redundant configuration options from Ladybird CMakeLists These options are already specified in common_compile_options.cmake and lagom_install_options.cmake
2024-04-25 17:20:57 +00:00
# FIXME: The rpath steps from lagom_install_rules.cmake do not produce a working binary
# in the build directory on macOS.
# We need to copy the libs into the build directory bundle as the install rules do.
Ladybird/Meta: Convert to CMake build
2022-07-04 11:45:18 +00:00
set(CMAKE_SKIP_BUILD_RPATH FALSE)
set(CMAKE_BUILD_WITH_INSTALL_RPATH FALSE)
# See slide 100 of the following ppt :^)
# https://crascit.com/wp-content/uploads/2019/09/Deep-CMake-For-Library-Authors-Craig-Scott-CppCon-2019.pdf
if (NOT APPLE)
Ladybird/CMake: Install resources and Lagom libraries alongside ladybird This setup should allow the package maintainers who are looking to distribute ladybird on their distributions to use CMake to install ladybird using cmake install rules rather than having to write their own
2022-09-16 10:08:24 +00:00
set(CMAKE_INSTALL_RPATH $ORIGIN;$ORIGIN/../${CMAKE_INSTALL_LIBDIR})
Ladybird/Meta: Convert to CMake build
2022-07-04 11:45:18 +00:00
endif()
set(CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE)
Ladybird/CMake: Enable compile_commands.json by default This should help IDEs have an easier time indexing serenity files.
2022-10-04 00:30:29 +00:00
set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
Ladybird/CMake: Add options for enabling {A,M,UB}SAN This patch adds convenient flags for enabling ASAN, MSAN and UBSAN.
2022-10-19 19:12:29 +00:00
if (ENABLE_ADDRESS_SANITIZER)
add_compile_options(-fsanitize=address -fno-omit-frame-pointer)
add_link_options(-fsanitize=address)
endif()
if (ENABLE_MEMORY_SANITIZER)
add_compile_options(-fsanitize=memory -fsanitize-memory-track-origins -fno-omit-frame-pointer)
add_link_options(-fsanitize=memory -fsanitize-memory-track-origins)
endif()
if (ENABLE_UNDEFINED_SANITIZER)
add_compile_options(-fsanitize=undefined -fno-omit-frame-pointer)
CMake: Add `UNDEFINED_BEHAVIOR_IS_FATAL` configure option This is mainly intended for use on CI, as UBSan instrumentation results in a serious load and execution time penalty there. See the previous commit for more details. With this enabled, the size of LibWeb, built for x86-64 with Clang 17 as of 0b91d36a is reduced as follows: FILE SIZE VM SIZE -------------- -------------- +18% +2.99Mi [ = ] 0 .debug_info +14% +758Ki [ = ] 0 .debug_addr +2.6% +7.92Ki [ = ] 0 .debug_abbrev +129% +2.66Ki [ = ] 0 [Unmapped] -0.2% -208 -0.2% -208 .plt -0.2% -312 -0.2% -312 .rela.plt -0.1% -336 -0.1% -336 .dynsym -0.0% -647 -0.0% -513 [8 Others] -0.1% -1.14Ki -0.1% -1.14Ki .dynstr -20.1% -53.5Ki -20.1% -53.5Ki .eh_frame_hdr -7.2% -56.8Ki [ = ] 0 .debug_str_offsets -7.1% -156Ki [ = ] 0 .debug_str -15.0% -160Ki [ = ] 0 .symtab -63.6% -245Ki -63.6% -245Ki .relr.dyn -25.4% -357Ki -25.4% -357Ki .eh_frame -27.7% -1.09Mi [ = ] 0 .strtab -59.3% -10.0Mi [ = ] 0 .debug_rnglists -41.3% -11.0Mi [ = ] 0 .debug_line -70.0% -12.0Mi -70.0% -12.0Mi .rodata -65.2% -15.1Mi -65.2% -15.1Mi .data -53.0% -15.7Mi -53.0% -15.7Mi .text -41.7% -62.1Mi -57.7% -43.4Mi TOTAL
2023-08-12 13:39:22 +00:00
if (UNDEFINED_BEHAVIOR_IS_FATAL)
add_compile_options(-fno-sanitize-recover=undefined)
endif()
Meta: Disable -fsanitize=function on macOS with clang 17 or higher This seems to trip on calling file static functions through a function pointer directly. Still need to reduce and report upstream.
2023-12-19 22:41:57 +00:00
if (APPLE AND CMAKE_CXX_COMPILER_ID MATCHES "Clang$" AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL "17")
add_compile_options(-fno-sanitize=function)
endif()
Ladybird/CMake: Add options for enabling {A,M,UB}SAN This patch adds convenient flags for enabling ASAN, MSAN and UBSAN.
2022-10-19 19:12:29 +00:00
add_link_options(-fsanitize=undefined)
endif()
Meta+Ladybird: Add some extra definitions for Haiku
2023-08-27 18:53:47 +00:00
if (HAIKU)
# Haiku needs some extra compile definitions to make important stuff in its headers available.
add_compile_definitions(_DEFAULT_SOURCE)
add_compile_definitions(_GNU_SOURCE)
add_compile_definitions(__USE_GNU)
endif()
Ladybird/Meta: Convert to CMake build
2022-07-04 11:45:18 +00:00
# Lagom
Ladybird: Support building Ladybird as a non-top-level project The implementation assumes that Lagom is either the top level project, or included before Ladybird is.
2022-12-23 18:36:02 +00:00
set(LADYBIRD_CUSTOM_TARGET_SUFFIX "-ladybird")
CMake: Resolve FIXMEs related to CMake < 3.20 We already have required this version for quite a while for Lagom, Ladybird and Serenity. Now that we require it in all of our CMakeLists, let's scrub for better ways of writing things.
2024-04-25 17:30:44 +00:00
if (PROJECT_IS_TOP_LEVEL)
Ladybird: Support building Ladybird as a non-top-level project The implementation assumes that Lagom is either the top level project, or included before Ladybird is.
2022-12-23 18:36:02 +00:00
set(LADYBIRD_CUSTOM_TARGET_SUFFIX "")
endif()
Ladybird/Meta: Convert to CMake build
2022-07-04 11:45:18 +00:00
CMake: Resolve FIXMEs related to CMake < 3.20 We already have required this version for quite a while for Lagom, Ladybird and Serenity. Now that we require it in all of our CMakeLists, let's scrub for better ways of writing things.
2024-04-25 17:30:44 +00:00
if (PROJECT_IS_TOP_LEVEL)
Ladybird: Support building Ladybird as a non-top-level project The implementation assumes that Lagom is either the top level project, or included before Ladybird is.
2022-12-23 18:36:02 +00:00
get_filename_component(
SERENITY_SOURCE_DIR "${ladybird_SOURCE_DIR}/.."
ABSOLUTE
)
list(APPEND CMAKE_MODULE_PATH "${SERENITY_SOURCE_DIR}/Meta/CMake")
include(cmake/EnableLagom.cmake)
Ladybird: Fix the include of use_linker in CMakeLists.txt
2023-09-05 18:57:20 +00:00
include(use_linker)
Meta: Include RPATH rules at top level to share them with Ladybird When using Ladybird/ as CMake source directory, the RPATH rules were left at the default, which is almost never correct.
2023-08-14 01:49:21 +00:00
include(lagom_compile_options)
include(lagom_install_options)
Ladybird: Support building Ladybird as a non-top-level project The implementation assumes that Lagom is either the top level project, or included before Ladybird is.
2022-12-23 18:36:02 +00:00
else()
# FIXME: Use SERENITY_SOURCE_DIR in Lagom/CMakeLists.txt
set(SERENITY_SOURCE_DIR "${SERENITY_PROJECT_ROOT}")
endif()
Ladybird/Meta: Add Android build Build an Android APK file that, when configured properly in Qt Creator, can be used to deploy the browser to an Android device. The current build requires NDK 24, targets no less than Android API 30, and Qt Creator 6.4.0.
2022-07-11 07:14:53 +00:00
Ladybird: Define AK_DONT_REPLACE_STD via CMake rather than in every file
2023-04-24 11:16:37 +00:00
add_compile_options(-DAK_DONT_REPLACE_STD)
Ladybird/Meta: Convert to CMake build
2022-07-04 11:45:18 +00:00
add_compile_options(-Wno-expansion-to-defined)
Ladybird: Fix compilation on macOS/Clang - Silences the -Wuser-defined-literals warning which is triggered by our use of the `sv` suffix for StringView - Removes an unused captured `this` pointer [-Wunused-lambda-capture] - Changes a JSONArray.h include to JSONObject.h to get the definition for `JSONValue::serialize`. This is needed because template functions are not exported for dylibs on macOS. This is a hack; the JSON headers should be refactored so that each one includes the definition of the template functions it sees. -- Maybe we should build with -fvisibility-inlines-hidden on Linux to catch issues like this?
2022-07-13 19:33:22 +00:00
add_compile_options(-Wno-user-defined-literals)
Ladybird/Meta: Convert to CMake build
2022-07-04 11:45:18 +00:00
Ladybird+Meta: Make the AppKit chrome the default on macOS The Qt chrome is still available and may be enabled with CMake.
2023-10-24 14:35:33 +00:00
if (ANDROID OR APPLE)
serenity_option(ENABLE_QT OFF CACHE BOOL "Build ladybird application using Qt GUI")
else()
serenity_option(ENABLE_QT ON CACHE BOOL "Build ladybird application using Qt GUI")
endif()
Ladybird: Add new template Kotlin Android application without Qt This template app from Android Studio should hopefully be more fun to work on than the Qt wrapped application we were using before. :^) It currently builds the native code using gradle rules, and has a stub WebViewImplementationNative class that will wrap a c++ class of the same name that inhertis from WebView::ViewImplementation. Spawning helper processes and creating proper views in Kotlin is next on the list.
2023-09-02 15:30:21 +00:00
if (ANDROID AND ENABLE_QT)
message(STATUS "Disabling Qt for Android")
set(ENABLE_QT OFF CACHE BOOL "" FORCE)
endif()
Ladybird: Add configuration option to build without Qt This should open the door for adding more GUI chromes to the repository
2023-08-08 01:42:06 +00:00
if (ENABLE_QT)
set(CMAKE_AUTOMOC ON)
set(CMAKE_AUTORCC ON)
set(CMAKE_AUTOUIC ON)
Ladybird: Do not require Qt6 Multimedia if PulseAudio is available If PulseAudio is available, the Qt6 audio plugin will never be used. So let's remove it from the build. Note that on macOS, the Qt6 audio plugin will be used if the Qt chrome is enabled. Otherwise, Audio Unit will be used for the AppKit chrome.
2023-11-02 17:53:38 +00:00
find_package(Qt6 REQUIRED COMPONENTS Core Widgets Network)
Ladybird: Add configuration option to build without Qt This should open the door for adding more GUI chromes to the repository
2023-08-08 01:42:06 +00:00
endif()
Ladybird/Meta: Convert to CMake build
2022-07-04 11:45:18 +00:00
set(SOURCES
Ladybird: Abstract spawning helper processes into separate methods This will let us use the same path discovery methods for WebContent, SQLServer, and any other helper processes we need to launch.
2023-02-02 10:00:30 +00:00
HelperProcess.cpp
Ladybird/WebView: Move our PageClient to its own file And rename it to PageClientLadybird while we're at it, it's not "headless" by any means.
2022-09-19 09:06:23 +00:00
Utilities.cpp
Ladybird/Meta: Convert to CMake build
2022-07-04 11:45:18 +00:00
)
CMake: Make sure to install generated sources and header files We weren't installing a lot of generated sources for the top level Lagom build or for LibWeb, making it impossible to use LibWeb from a find_package. ...And also Kernel/API/KeyCode.h, which is included by no less than 8 different files in Userland/Libraries. We also weren't installing any Ladybird header files.
2023-08-08 04:14:22 +00:00
set(LADYBIRD_HEADERS
HelperProcess.h
Types.h
Utilities.h
)
Ladybird/Meta: Convert to CMake build
2022-07-04 11:45:18 +00:00
Ladybird: Add configuration option to build without Qt This should open the door for adding more GUI chromes to the repository
2023-08-08 01:42:06 +00:00
if (ENABLE_QT)
qt_add_executable(ladybird ${SOURCES})
target_sources(ladybird PRIVATE
Ladybird: Move QApplication class to its own file We'll attach some global data to it in an upcoming commit, so it needs to be accessible outside of main.cpp.
2024-04-12 21:15:09 +00:00
Qt/Application.cpp
Ladybird: Add autocomplete to `LocationEdit`
2023-05-31 01:44:16 +00:00
Qt/AutoComplete.cpp
Ladybird: Add configuration option to build without Qt This should open the door for adding more GUI chromes to the repository
2023-08-08 01:42:06 +00:00
Qt/BrowserWindow.cpp
Qt/EventLoopImplementationQt.cpp
Qt/EventLoopImplementationQtEventTarget.cpp
Ladybird/Qt: Add a find in page widget
2024-05-29 19:12:21 +00:00
Qt/FindInPageWidget.cpp
Ladybird: Load all icons uses Core::Resource URIs
2023-11-05 12:45:43 +00:00
Qt/Icon.cpp
Ladybird: Add configuration option to build without Qt This should open the door for adding more GUI chromes to the repository
2023-08-08 01:42:06 +00:00
Qt/InspectorWidget.cpp
Qt/LocationEdit.cpp
Qt/Settings.cpp
Qt/SettingsDialog.cpp
Qt/Tab.cpp
Ladybird/Qt: Add a hover effect to the audio play state button By default, a flat QPushButton does not have a hover effect. Add a small subclass to provide such an effect to make it clearer it is a button.
2024-04-03 01:24:17 +00:00
Qt/TabBar.cpp
Ladybird: Add a simple TaskManager window for tracking child processes This implementation uses a really basic WebView to update stats once a second. In the future it might make more sense to both move the details into LibWebView, and to create a native widget for each platform to remove the overhead of having an extra WebView.
2024-03-26 17:38:12 +00:00
Qt/TaskManagerWindow.cpp
Ladybird: Add configuration option to build without Qt This should open the door for adding more GUI chromes to the repository
2023-08-08 01:42:06 +00:00
Qt/TVGIconEngine.cpp
Qt/StringUtils.cpp
Qt/WebContentView.cpp
Qt/ladybird.qrc
Qt/main.cpp
)
target_link_libraries(ladybird PRIVATE Qt::Core Qt::Gui Qt::Network Qt::Widgets)
Ladybird: Implement an AppKit chrome for macOS :^) This adds an alternative Ladybird chrome for macOS using the AppKit framework. Just about everything needed for normal web browsing has been implemented. This includes: * Tabbed, scrollable navigation * History navigation (back, forward, reload) * Keyboard / mouse events * Favicons * Context menus * Cookies * Dialogs (alert, confirm, prompt) * WebDriver support This does not include debugging tools like the JavaScript console and inspector, nor theme support. The Qt chrome is still used by default. To use the AppKit chrome, set the ENABLE_QT CMake option to OFF.
2023-08-20 20:14:31 +00:00
elseif (APPLE)
add_executable(ladybird MACOSX_BUNDLE
${SOURCES}
AppKit/main.mm
AppKit/Application/Application.mm
Ladybird+headless-browser: Make RequestServer single instance on Lagom Co-Authored-By: Timothy Flynn <trflynn89@pm.me>
2024-04-15 23:39:48 +00:00
AppKit/Application/ApplicationBridge.cpp
Ladybird: Implement an AppKit chrome for macOS :^) This adds an alternative Ladybird chrome for macOS using the AppKit framework. Just about everything needed for normal web browsing has been implemented. This includes: * Tabbed, scrollable navigation * History navigation (back, forward, reload) * Keyboard / mouse events * Favicons * Context menus * Cookies * Dialogs (alert, confirm, prompt) * WebDriver support This does not include debugging tools like the JavaScript console and inspector, nor theme support. The Qt chrome is still used by default. To use the AppKit chrome, set the ENABLE_QT CMake option to OFF.
2023-08-20 20:14:31 +00:00
AppKit/Application/ApplicationDelegate.mm
AppKit/Application/EventLoopImplementation.mm
AppKit/UI/Event.mm
Ladybird: Implement a basic Inspector window for the AppKit chrome This commit includes only fetching the DOM tree from the WebContent process and displaying it in an NSOutlineView. The displayed tree includes some basic styling (e.g. colors).
2023-09-13 18:55:34 +00:00
AppKit/UI/Inspector.mm
AppKit/UI/InspectorController.mm
Ladybird: Implement an AppKit chrome for macOS :^) This adds an alternative Ladybird chrome for macOS using the AppKit framework. Just about everything needed for normal web browsing has been implemented. This includes: * Tabbed, scrollable navigation * History navigation (back, forward, reload) * Keyboard / mouse events * Favicons * Context menus * Cookies * Dialogs (alert, confirm, prompt) * WebDriver support This does not include debugging tools like the JavaScript console and inspector, nor theme support. The Qt chrome is still used by default. To use the AppKit chrome, set the ENABLE_QT CMake option to OFF.
2023-08-20 20:14:31 +00:00
AppKit/UI/LadybirdWebView.mm
AppKit/UI/LadybirdWebViewBridge.cpp
Ladybird: Inform WebContent whether the AppKit chrome is in dark mode
2023-08-27 03:12:30 +00:00
AppKit/UI/Palette.mm
Ladybird: Implement an AppKit chrome for macOS :^) This adds an alternative Ladybird chrome for macOS using the AppKit framework. Just about everything needed for normal web browsing has been implemented. This includes: * Tabbed, scrollable navigation * History navigation (back, forward, reload) * Keyboard / mouse events * Favicons * Context menus * Cookies * Dialogs (alert, confirm, prompt) * WebDriver support This does not include debugging tools like the JavaScript console and inspector, nor theme support. The Qt chrome is still used by default. To use the AppKit chrome, set the ENABLE_QT CMake option to OFF.
2023-08-20 20:14:31 +00:00
AppKit/UI/Tab.mm
AppKit/UI/TabController.mm
Ladybird/AppKit: Implement a simple TaskManager window Unlike the Inspector window, this is owned by the ApplicationDelegate as there should be only a single task manager for the entire application.
2024-04-10 02:35:20 +00:00
AppKit/UI/TaskManager.mm
AppKit/UI/TaskManagerController.mm
Ladybird: Implement an AppKit chrome for macOS :^) This adds an alternative Ladybird chrome for macOS using the AppKit framework. Just about everything needed for normal web browsing has been implemented. This includes: * Tabbed, scrollable navigation * History navigation (back, forward, reload) * Keyboard / mouse events * Favicons * Context menus * Cookies * Dialogs (alert, confirm, prompt) * WebDriver support This does not include debugging tools like the JavaScript console and inspector, nor theme support. The Qt chrome is still used by default. To use the AppKit chrome, set the ENABLE_QT CMake option to OFF.
2023-08-20 20:14:31 +00:00
AppKit/Utilities/Conversions.mm
)
target_include_directories(ladybird PRIVATE AppKit)
Ladybird/AppKit: Implement <input type=file> file type filtering
2024-03-15 02:45:28 +00:00
target_link_libraries(ladybird PRIVATE "-framework Cocoa -framework UniformTypeIdentifiers" LibUnicode)
Ladybird: Implement an AppKit chrome for macOS :^) This adds an alternative Ladybird chrome for macOS using the AppKit framework. Just about everything needed for normal web browsing has been implemented. This includes: * Tabbed, scrollable navigation * History navigation (back, forward, reload) * Keyboard / mouse events * Favicons * Context menus * Cookies * Dialogs (alert, confirm, prompt) * WebDriver support This does not include debugging tools like the JavaScript console and inspector, nor theme support. The Qt chrome is still used by default. To use the AppKit chrome, set the ENABLE_QT CMake option to OFF.
2023-08-20 20:14:31 +00:00
target_compile_options(ladybird PRIVATE
-fobjc-arc
-Wno-deprecated-anon-enum-enum-conversion # Required for CGImageCreate
)
Ladybird: Add new template Kotlin Android application without Qt This template app from Android Studio should hopefully be more fun to work on than the Qt wrapped application we were using before. :^) It currently builds the native code using gradle rules, and has a stub WebViewImplementationNative class that will wrap a c++ class of the same name that inhertis from WebView::ViewImplementation. Spawning helper processes and creating proper views in Kotlin is next on the list.
2023-09-02 15:30:21 +00:00
elseif(ANDROID)
add_library(ladybird SHARED
${SOURCES}
Android/src/main/cpp/LadybirdActivity.cpp
Android/src/main/cpp/WebViewImplementationNative.cpp
Ladybird/Android: Move JNI functions into their own files This should be easier to work on, and keeps the layers of the native code nice and clean cut.
2023-09-15 18:35:20 +00:00
Android/src/main/cpp/WebViewImplementationNativeJNI.cpp
Ladybird/Android: Add EventLoopImplementation for ALooper Timers run in their own thread, to take advantage of existing Java Executor features. By hooking into ALooper, we can spin the main Activity's UI thread event loop without causing a fuss, or spinning the CPU by just polling our event loop constantly.
2023-09-09 04:12:42 +00:00
Android/src/main/cpp/ALooperEventLoopImplementation.cpp
Android/src/main/cpp/TimerExecutorService.cpp
Ladybird/Android: Add EditText for URL bar and attach to native WebView
2023-09-24 05:05:15 +00:00
Android/src/main/cpp/JNIHelpers.cpp
Ladybird: Add new template Kotlin Android application without Qt This template app from Android Studio should hopefully be more fun to work on than the Qt wrapped application we were using before. :^) It currently builds the native code using gradle rules, and has a stub WebViewImplementationNative class that will wrap a c++ class of the same name that inhertis from WebView::ViewImplementation. Spawning helper processes and creating proper views in Kotlin is next on the list.
2023-09-02 15:30:21 +00:00
)
Ladybird/Android: Move JNI functions into their own files This should be easier to work on, and keeps the layers of the native code nice and clean cut.
2023-09-15 18:35:20 +00:00
target_link_libraries(ladybird PRIVATE LibArchive jnigraphics android)
Ladybird: Add configuration option to build without Qt This should open the door for adding more GUI chromes to the repository
2023-08-08 01:42:06 +00:00
else()
# TODO: Check for other GUI frameworks here when we move them in-tree
# For now, we can export a static library of common files for chromes to link to
add_library(ladybird STATIC ${SOURCES})
endif()
Ladybird: Implement an AppKit chrome for macOS :^) This adds an alternative Ladybird chrome for macOS using the AppKit framework. Just about everything needed for normal web browsing has been implemented. This includes: * Tabbed, scrollable navigation * History navigation (back, forward, reload) * Keyboard / mouse events * Favicons * Context menus * Cookies * Dialogs (alert, confirm, prompt) * WebDriver support This does not include debugging tools like the JavaScript console and inspector, nor theme support. The Qt chrome is still used by default. To use the AppKit chrome, set the ENABLE_QT CMake option to OFF.
2023-08-20 20:14:31 +00:00
Ladybird+LibWebView: Add mechanism to get Mach task port for helpers On macOS, it's not trivial to get a Mach task port for your children. This implementation registers the chrome process as a well-known service with launchd based on its pid, and lets each child process send over a reference to its mach_task_self() back to the chrome. We'll need this Mach task port right to get process statistics.
2024-04-04 20:10:08 +00:00
if (APPLE)
target_sources(ladybird PRIVATE MachPortServer.cpp)
target_link_libraries(ladybird PRIVATE LibThreading)
endif()
CMake: Make sure to install generated sources and header files We weren't installing a lot of generated sources for the top level Lagom build or for LibWeb, making it impossible to use LibWeb from a find_package. ...And also Kernel/API/KeyCode.h, which is included by no less than 8 different files in Userland/Libraries. We also weren't installing any Ladybird header files.
2023-08-08 04:14:22 +00:00
target_sources(ladybird PUBLIC FILE_SET ladybird TYPE HEADERS
BASE_DIRS ${SERENITY_SOURCE_DIR}
FILES ${LADYBIRD_HEADERS}
)
Ladybird+LibWebView: Move SQLServer launcher to Ladybird It previously resided in LibWebView to hide the details of launching a singleton process. That functionality now lives in LibCore. By moving this to Ladybird, we will be able to register the process with the task manager.
2024-04-22 16:31:29 +00:00
target_link_libraries(ladybird PRIVATE AK LibCore LibFileSystem LibGfx LibImageDecoderClient LibIPC LibJS LibMain LibSQL LibWeb LibWebView LibProtocol LibURL)
Ladybird/Meta: Convert to CMake build
2022-07-04 11:45:18 +00:00
Ladybird: Render web content in a separate process :^) This patch brings over the WebContent process over from SerenityOS to Ladybird, along with a new WebContentView widget that renders web content in a separate process. There's a lot of jank and FIXME material here, notably I had to re-add manually pumped Core::EventLoop instances on both sides, in order to get the IPC protocol running. This introduces a lot of latency and we should work towards replacing those loops with improved abstractions. The WebContent process is built separately here (not part of Lagom) and we provide our own main.cpp for it. Like everything, this can be better architected, it's just a starting point. :^)
2022-10-05 13:23:41 +00:00
target_include_directories(ladybird PRIVATE ${CMAKE_CURRENT_BINARY_DIR})
Ladybird: Add `Userland` to the list of include directories This now matches the Lagom-based Ladybird build and the SerenityOS build.
2023-06-09 20:37:21 +00:00
target_include_directories(ladybird PRIVATE ${SERENITY_SOURCE_DIR}/Userland/)
Ladybird: Use Browser's CookieJar.{cpp,h} There are no custom changes for Ladybird in the current copies of those files, so we just need to ensure to keep Ladybird up to date for any changes made upstream. This fixes a build issue introduced by https://github.com/SerenityOS/serenity/pull/15736.
2022-10-22 21:35:55 +00:00
target_include_directories(ladybird PRIVATE ${SERENITY_SOURCE_DIR}/Userland/Applications/)
Ladybird: Render web content in a separate process :^) This patch brings over the WebContent process over from SerenityOS to Ladybird, along with a new WebContentView widget that renders web content in a separate process. There's a lot of jank and FIXME material here, notably I had to re-add manually pumped Core::EventLoop instances on both sides, in order to get the IPC protocol running. This introduces a lot of latency and we should work towards replacing those loops with improved abstractions. The WebContent process is built separately here (not part of Lagom) and we provide our own main.cpp for it. Like everything, this can be better architected, it's just a starting point. :^)
2022-10-05 13:23:41 +00:00
target_include_directories(ladybird PRIVATE ${SERENITY_SOURCE_DIR}/Userland/Services/)
Ladybird: Move helper processes to CMAKE_INSTALL_LIBEXECDIR It aligns better with the Filesystem Heirarchy Standard[1] to put our program-specific helper programs that are not intended to be executed by the user of the application in $prefix/libexec or in whatever the packager sets as the CMake equivalent. Namely, on Debian systems this should be /usr/lib/Ladybird or similar. [1] https://refspecs.linuxfoundation.org/FHS_3.0/fhs-3.0.html#usrlibexec
2024-02-24 00:02:17 +00:00
function(set_helper_process_properties)
set(targets ${ARGV})
Ladybird: Always place helper processes in bundle directory on macOS Don't put them in bin/ and then copy them to the bundle dir later, as this means that they only get updated in the bundle directory if the Ladybird binary itself needs updated. Which is not a fun workflow if you are working on WPT and want to hack on the WebDriver binary.
2024-02-21 23:16:15 +00:00
if (APPLE)
# Store helper processes in the same bundle directory as the main application
Ladybird: Move helper processes to CMAKE_INSTALL_LIBEXECDIR It aligns better with the Filesystem Heirarchy Standard[1] to put our program-specific helper programs that are not intended to be executed by the user of the application in $prefix/libexec or in whatever the packager sets as the CMake equivalent. Namely, on Debian systems this should be /usr/lib/Ladybird or similar. [1] https://refspecs.linuxfoundation.org/FHS_3.0/fhs-3.0.html#usrlibexec
2024-02-24 00:02:17 +00:00
set_target_properties(${targets} PROPERTIES RUNTIME_OUTPUT_DIRECTORY "$<TARGET_FILE_DIR:ladybird>")
else()
Meta: Handle output directories for multi-config CMake generators For Ninja Multi-Config, Xcode and Visual Studio, the way we set up our output directories would result in exectuables that can't run from the build directory. Add the same sauce that we added to Jakt to insert ``$<CONFIG>`` where appropriate.
2024-02-25 05:01:17 +00:00
set_target_properties(${targets} PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/${IN_BUILD_PREFIX}${CMAKE_INSTALL_LIBEXECDIR}")
Ladybird: Move helper processes to CMAKE_INSTALL_LIBEXECDIR It aligns better with the Filesystem Heirarchy Standard[1] to put our program-specific helper programs that are not intended to be executed by the user of the application in $prefix/libexec or in whatever the packager sets as the CMake equivalent. Namely, on Debian systems this should be /usr/lib/Ladybird or similar. [1] https://refspecs.linuxfoundation.org/FHS_3.0/fhs-3.0.html#usrlibexec
2024-02-24 00:02:17 +00:00
if (NOT CMAKE_INSTALL_LIBEXECDIR STREQUAL "libexec")
set_source_files_properties(Utilities.cpp PROPERTIES COMPILE_DEFINITIONS LADYBIRD_LIBEXECDIR="${CMAKE_INSTALL_LIBEXECDIR}")
set_source_files_properties(Utilities.cpp TARGET_DIRECTORY ${targets} PROPERTIES COMPILE_DEFINITIONS LADYBIRD_LIBEXECDIR="${CMAKE_INSTALL_LIBEXECDIR}")
endif()
Ladybird: Always place helper processes in bundle directory on macOS Don't put them in bin/ and then copy them to the bundle dir later, as this means that they only get updated in the bundle directory if the Ladybird binary itself needs updated. Which is not a fun workflow if you are working on WPT and want to hack on the WebDriver binary.
2024-02-21 23:16:15 +00:00
endif()
endfunction()
Ladybird: Move Qt-specific classes and functions to a Qt subdirectory This will help a lot with developing chromes for different UI frameworks where we can see which helper classes and processes are really using Qt vs just using it to get at helper data. As a bonus, remove Qt dependency from WebDriver.
2023-08-05 16:42:26 +00:00
add_executable(headless-browser
headless-browser: Re-implement headless-browser using an OOPWV headless-browser currently uses its own PageClient to load web pages in-process. Due to this, it also needs to set up a whole bunch of other objects needed to run LibWeb, e.g. image decoders, request servers, etc. This changes headless-browser to instead implement a WebView to launch WebContent out-of-process. This implementation is almost entirely empty, but can be filled in as-needed. For example, we may want to print JavaScript console messages.
2023-03-12 16:38:15 +00:00
${SERENITY_SOURCE_DIR}/Userland/Utilities/headless-browser.cpp
HelperProcess.cpp
Utilities.cpp)
target_include_directories(headless-browser PRIVATE ${CMAKE_CURRENT_BINARY_DIR})
Ladybird: Include Userland/ in for Applications that use LibWeb After ea682207d099654dd0c5d1ed399e2060c4de1533, we need Userland/ included directly in these application executables. This only impacts the build with Ladybird/CMakeLists.txt as the top level CMakeLists, as the Lagom/ directory includes Userland/ globally.
2024-03-07 00:10:16 +00:00
target_include_directories(headless-browser PRIVATE ${SERENITY_SOURCE_DIR}/Userland/)
Ladybird+LibWebView: Move SQLServer launcher to Ladybird It previously resided in LibWebView to hide the details of launching a singleton process. That functionality now lives in LibCore. By moving this to Ladybird, we will be able to register the process with the task manager.
2024-04-22 16:31:29 +00:00
target_link_libraries(headless-browser PRIVATE AK LibCore LibWeb LibWebView LibWebSocket LibCrypto LibFileSystem LibGemini LibHTTP LibImageDecoderClient LibJS LibGfx LibMain LibSQL LibTLS LibIPC LibDiff LibProtocol LibURL)
headless-browser: Re-implement headless-browser using an OOPWV headless-browser currently uses its own PageClient to load web pages in-process. Due to this, it also needs to set up a whole bunch of other objects needed to run LibWeb, e.g. image decoders, request servers, etc. This changes headless-browser to instead implement a WebView to launch WebContent out-of-process. This implementation is almost entirely empty, but can be filled in as-needed. For example, we may want to print JavaScript console messages.
2023-03-12 16:38:15 +00:00
Ladybird/Meta: Add Android build Build an Android APK file that, when configured properly in Qt Creator, can be used to deploy the browser to an Android device. The current build requires NDK 24, targets no less than Android API 30, and Qt Creator 6.4.0.
2022-07-11 07:14:53 +00:00
if (ANDROID)
include(cmake/AndroidExtras.cmake)
endif()
Ladybird: Support building Ladybird as a non-top-level project The implementation assumes that Lagom is either the top level project, or included before Ladybird is.
2022-12-23 18:36:02 +00:00
add_custom_target(run${LADYBIRD_CUSTOM_TARGET_SUFFIX}
Meta: Support running ladybird with arguments from serenity.sh You may now, for example, run: ./Meta/serenity.sh run lagom ladybird https://serenityos.org
2023-01-26 11:51:48 +00:00
COMMAND "${CMAKE_COMMAND}" -E env "SERENITY_SOURCE_DIR=${SERENITY_SOURCE_DIR}" "$<TARGET_FILE:ladybird>" $ENV{LAGOM_ARGS}
Ladybird/Meta: Convert to CMake build
2022-07-04 11:45:18 +00:00
USES_TERMINAL
Meta: Support running ladybird with arguments from serenity.sh You may now, for example, run: ./Meta/serenity.sh run lagom ladybird https://serenityos.org
2023-01-26 11:51:48 +00:00
VERBATIM
Ladybird/Meta: Convert to CMake build
2022-07-04 11:45:18 +00:00
)
Ladybird: Support building Ladybird as a non-top-level project The implementation assumes that Lagom is either the top level project, or included before Ladybird is.
2022-12-23 18:36:02 +00:00
add_custom_target(debug${LADYBIRD_CUSTOM_TARGET_SUFFIX}
Ladybird/CMake: Launch gdb with follow fork mode to debug WebContent
2022-10-19 19:13:53 +00:00
COMMAND "${CMAKE_COMMAND}" -E env "SERENITY_SOURCE_DIR=${SERENITY_SOURCE_DIR}" gdb -ex "set follow-fork-mode child" "$<TARGET_FILE:ladybird>"
Ladybird/Meta: Convert to CMake build
2022-07-04 11:45:18 +00:00
USES_TERMINAL
)
Ladybird: Decode images out of process This patch brings a service to handle image decompression. With it comes security enhancement due to the process boundary. Indeed, consequences of a potential attack is reduced as only the decoder will crash without perturbing the WebContent process. It also allows us to display pages containing images that we claim to support but still make us crash, like for not-finished-yet decoders. As an example, we can now load https://jpegxl.info/jxl-art.html without crashing the WebContent process.
2023-09-08 10:30:50 +00:00
add_subdirectory(ImageDecoder)
add_subdirectory(RequestServer)
Ladybird: Implement SQLServer for Ladybird :^) This adds a SQLServer binary for Ladybird to make use of Serenity's SQL implementation. This has to use the same IPC socket handling that was used to make WebContent and WebDriver work out-of-process. Unlike Serenity, Ladybird creates a new SQLServer instance for each Ladybird instance. In the future, we should try to make sure there is only one SQLServer instance at a time, and allow multiple Ladybird instances to communicate with it.
2022-12-05 18:09:42 +00:00
add_subdirectory(SQLServer)
Ladybird: Ensure that installed ladybird can launch WebContent process Always call platform_init after there's a QApplication, because in the installed configuration that's how we find the resources. Try QCoreApplication::applicationDirPath() after looking in ./WebContent for the WebContent process. In an installed configuration, ladybird and WebContent will both be in $PREFIX/bin. Add install rules for WebContent and its linked libraries, for if they ever differ from ladybird's.
2022-10-07 23:08:29 +00:00
add_subdirectory(WebContent)
Ladybird: Implement WebDriver for Ladybird :^) This adds a WebDriver binary for Ladybird to make use of Serenity's WebDriver implementation. This has to use the same IPC socket handling that was used to make WebContent work out-of-process. Besides that, we are able to reuse almost everything from Serenity.
2022-11-14 17:09:14 +00:00
add_subdirectory(WebDriver)
LibWeb+WebWorker: Move worker execution into a new WebWorker process We now create a WorkerAgent for the parent context, which is currently only a Window. Note that Workers can have Workers per the spec. The WorkerAgent spawns a WebWorker process to hold the actual script execution of the Worker. This is modeled with the DedicatedWorkerHost object in the WebWorker process. A start_dedicated_worker IPC method in the WebWorker IPC creates the WorkerHost object. Future different worker types may use different IPC messages to create their WorkerHost instance. This implementation cannot yet postMessage between the parent and the child processes. Co-Authored-By: Andreas Kling <kling@serenityos.org>
2023-11-08 18:47:41 +00:00
add_subdirectory(WebWorker)
Ladybird: Always place helper processes in bundle directory on macOS Don't put them in bin/ and then copy them to the bundle dir later, as this means that they only get updated in the bundle directory if the Ladybird binary itself needs updated. Which is not a fun workflow if you are working on WPT and want to hack on the WebDriver binary.
2024-02-21 23:16:15 +00:00
Meta: Do not place headless-browser and WebDriver in libexec These are standalone applications meant to be run by the user directly, as opposed to other libexec processes which are programmatically forked by the browser. To do this, we simply remove these processes from the `ladybird_helper_processes` list. We must also explicitly list the dependencies for these processes.
2024-03-16 18:52:20 +00:00
set(ladybird_helper_processes ImageDecoder RequestServer SQLServer WebContent WebWorker)
Ladybird: Always place helper processes in bundle directory on macOS Don't put them in bin/ and then copy them to the bundle dir later, as this means that they only get updated in the bundle directory if the Ladybird binary itself needs updated. Which is not a fun workflow if you are working on WPT and want to hack on the WebDriver binary.
2024-02-21 23:16:15 +00:00
add_dependencies(ladybird ${ladybird_helper_processes})
Meta: Do not place headless-browser and WebDriver in libexec These are standalone applications meant to be run by the user directly, as opposed to other libexec processes which are programmatically forked by the browser. To do this, we simply remove these processes from the `ladybird_helper_processes` list. We must also explicitly list the dependencies for these processes.
2024-03-16 18:52:20 +00:00
add_dependencies(headless-browser ${ladybird_helper_processes})
add_dependencies(WebDriver ladybird headless-browser)
Ladybird: Improve Xcode generator experience and copy helpers to bundle We had a mismatch in the GUI Identifier property, causing warnings in Xcode. It was also missing the Product Identifier Xcode property on ladybird itself, causing another warning. Copy all our helper processes to the ladybird.app bundle directory so that they can be found by ``open ladybird.app`` and the Xcode debugger. For the future, we should look in ../Resources for resources on macOS. Copying resources to that directory requires more CMake-fu.
2023-03-26 15:53:32 +00:00
Ladybird: Support non-Qt chromes on macOS Non-Qt chromes will want to use the same Info.plist and bundle info as the Qt chrome. This patch puts the CMake setup for the bundle into a function that non-Qt chromes may call in their CMakeLists.txt. The Qt chrome calls it automatically.
2023-08-14 19:08:14 +00:00
function(create_ladybird_bundle target_name)
set_target_properties(${target_name} PROPERTIES
Ladybird: Fix capitalization in AppKit menu bar
2023-09-03 14:16:49 +00:00
OUTPUT_NAME "Ladybird"
Ladybird: Support non-Qt chromes on macOS Non-Qt chromes will want to use the same Info.plist and bundle info as the Qt chrome. This patch puts the CMake setup for the bundle into a function that non-Qt chromes may call in their CMakeLists.txt. The Qt chrome calls it automatically.
2023-08-14 19:08:14 +00:00
MACOSX_BUNDLE_GUI_IDENTIFIER org.SerenityOS.Ladybird
MACOSX_BUNDLE_BUNDLE_VERSION ${PROJECT_VERSION}
MACOSX_BUNDLE_SHORT_VERSION_STRING ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}
MACOSX_BUNDLE_INFO_PLIST "${SERENITY_SOURCE_DIR}/Ladybird/Info.plist"
MACOSX_BUNDLE TRUE
WIN32_EXECUTABLE TRUE
XCODE_ATTRIBUTE_PRODUCT_BUNDLE_IDENTIFIER org.SerenityOS.Ladybird
Ladybird: Improve Xcode generator experience and copy helpers to bundle We had a mismatch in the GUI Identifier property, causing warnings in Xcode. It was also missing the Product Identifier Xcode property on ladybird itself, causing another warning. Copy all our helper processes to the ladybird.app bundle directory so that they can be found by ``open ladybird.app`` and the Xcode debugger. For the future, we should look in ../Resources for resources on macOS. Copying resources to that directory requires more CMake-fu.
2023-03-26 15:53:32 +00:00
)
Ladybird: Support non-Qt chromes on macOS Non-Qt chromes will want to use the same Info.plist and bundle info as the Qt chrome. This patch puts the CMake setup for the bundle into a function that non-Qt chromes may call in their CMakeLists.txt. The Qt chrome calls it automatically.
2023-08-14 19:08:14 +00:00
if (APPLE)
set(bundle_dir "$<TARGET_BUNDLE_DIR:${target_name}>")
add_custom_command(TARGET ${target_name} POST_BUILD
Ladybird: Copy resources into the build directory This will let us remove the dependence on SERENITY_SOURCE_DIR
2024-02-22 01:11:45 +00:00
COMMAND "${CMAKE_COMMAND}" -E make_directory "${bundle_dir}/Contents/Resources"
Ladybird: Support non-Qt chromes on macOS Non-Qt chromes will want to use the same Info.plist and bundle info as the Qt chrome. This patch puts the CMake setup for the bundle into a function that non-Qt chromes may call in their CMakeLists.txt. The Qt chrome calls it automatically.
2023-08-14 19:08:14 +00:00
COMMAND "iconutil" --convert icns "${SERENITY_SOURCE_DIR}/Ladybird/Icons/macos/app_icon.iconset" --output "${bundle_dir}/Contents/Resources/app_icon.icns"
)
endif()
endfunction()
Ladybird: Implement an AppKit chrome for macOS :^) This adds an alternative Ladybird chrome for macOS using the AppKit framework. Just about everything needed for normal web browsing has been implemented. This includes: * Tabbed, scrollable navigation * History navigation (back, forward, reload) * Keyboard / mouse events * Favicons * Context menus * Cookies * Dialogs (alert, confirm, prompt) * WebDriver support This does not include debugging tools like the JavaScript console and inspector, nor theme support. The Qt chrome is still used by default. To use the AppKit chrome, set the ENABLE_QT CMake option to OFF.
2023-08-20 20:14:31 +00:00
create_ladybird_bundle(ladybird)
Ladybird: Move helper processes to CMAKE_INSTALL_LIBEXECDIR It aligns better with the Filesystem Heirarchy Standard[1] to put our program-specific helper programs that are not intended to be executed by the user of the application in $prefix/libexec or in whatever the packager sets as the CMake equivalent. Namely, on Debian systems this should be /usr/lib/Ladybird or similar. [1] https://refspecs.linuxfoundation.org/FHS_3.0/fhs-3.0.html#usrlibexec
2024-02-24 00:02:17 +00:00
set_helper_process_properties(${ladybird_helper_processes})
Meta: Do not place headless-browser and WebDriver in libexec These are standalone applications meant to be run by the user directly, as opposed to other libexec processes which are programmatically forked by the browser. To do this, we simply remove these processes from the `ladybird_helper_processes` list. We must also explicitly list the dependencies for these processes.
2024-03-16 18:52:20 +00:00
if (APPLE)
set_helper_process_properties(headless-browser WebDriver)
endif()
Ladybird: Ensure that installed ladybird can launch WebContent process Always call platform_init after there's a QApplication, because in the installed configuration that's how we find the resources. Try QCoreApplication::applicationDirPath() after looking in ./WebContent for the WebContent process. In an installed configuration, ladybird and WebContent will both be in $PREFIX/bin. Add install rules for WebContent and its linked libraries, for if they ever differ from ladybird's.
2022-10-07 23:08:29 +00:00
Ladybird: Copy resources into the build directory This will let us remove the dependence on SERENITY_SOURCE_DIR
2024-02-22 01:11:45 +00:00
include(cmake/ResourceFiles.cmake)
Meta: Handle output directories for multi-config CMake generators For Ninja Multi-Config, Xcode and Visual Studio, the way we set up our output directories would result in exectuables that can't run from the build directory. Add the same sauce that we added to Jakt to insert ``$<CONFIG>`` where appropriate.
2024-02-25 05:01:17 +00:00
set(resource_base_dir "${CMAKE_BINARY_DIR}/${IN_BUILD_PREFIX}${CMAKE_INSTALL_DATADIR}/Lagom")
Ladybird: Copy resources into the build directory This will let us remove the dependence on SERENITY_SOURCE_DIR
2024-02-22 01:11:45 +00:00
if (APPLE)
set(resource_base_dir "$<TARGET_BUNDLE_DIR:ladybird>/Contents/Resources")
endif()
copy_resources_to_build(${resource_base_dir} ladybird)
Ladybird/CMake: Install resources and Lagom libraries alongside ladybird This setup should allow the package maintainers who are looking to distribute ladybird on their distributions to use CMake to install ladybird using cmake install rules rather than having to write their own
2022-09-16 10:08:24 +00:00
if(NOT CMAKE_SKIP_INSTALL_RULES)
include(cmake/InstallRules.cmake)
endif()
Ladybird+CI: Move layout_test.sh test runner from CI yml into CMake We should be able to run this locally, as long as ENABLE_LAGOM_LADYBIRD is true, or if building ladybird from the ladybird source directory. This removes a special case from the Lagom CI yml file.
2023-03-10 17:45:50 +00:00
include(CTest)
if (BUILD_TESTING)
add_test(
Ladybird: Run all layout & text tests in the same process Instead of starting a new headless-browser for every layout & text test, headless-browser now gets a mode where it runs all the tests in a single process. This is massively faster on my machine, taking a full LibWeb test run from 14 seconds to less than 1 second. Hopefully it will be a similarly awesome improvement on CI where it has been soaking up more and more time lately. :^)
2023-05-27 17:46:17 +00:00
NAME LibWeb
Ladybird: Copy resources into the build directory This will let us remove the dependence on SERENITY_SOURCE_DIR
2024-02-22 01:11:45 +00:00
COMMAND $<TARGET_FILE:headless-browser> --resources "${resource_base_dir}" --run-tests ${SERENITY_SOURCE_DIR}/Tests/LibWeb --dump-failed-ref-tests
Ladybird+CI: Move layout_test.sh test runner from CI yml into CMake We should be able to run this locally, as long as ENABLE_LAGOM_LADYBIRD is true, or if building ladybird from the ladybird source directory. This removes a special case from the Lagom CI yml file.
2023-03-10 17:45:50 +00:00
)
Ladybird+Meta: Add ctest to run WPT in the Integration configuration By running ctest -C Integration -R WPT, you can run WPT. Adding just -C Integration will run all other tests *and* the WPT test. Also add support for ./Meta/serenity.sh test lagom WPT to serenity.sh
2023-08-19 19:46:26 +00:00
add_test(
NAME WPT
CONFIGURATIONS Integration
COMMAND ${CMAKE_CURRENT_SOURCE_DIR}/../Tests/LibWeb/WPT/run.sh
)
set_tests_properties(LibWeb WPT PROPERTIES
DEPENDS ladybird
ENVIRONMENT QT_QPA_PLATFORM=offscreen
ENVIRONMENT "SERENITY_SOURCE_DIR=${SERENITY_SOURCE_DIR}"
)
Ladybird+CI: Move layout_test.sh test runner from CI yml into CMake We should be able to run this locally, as long as ENABLE_LAGOM_LADYBIRD is true, or if building ladybird from the ladybird source directory. This removes a special case from the Lagom CI yml file.
2023-03-10 17:45:50 +00:00
endif()
Reference in a new issue Copy permalink