beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 00:50:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7
ladybird/Ladybird/CMakeLists.txt

170 lines
6.6 KiB
Text
Raw Normal View History

Meta: Copy resources to the app bundle during create_ladybird_bundle() For some reason, moving the UI-specific CMake to its own files prevents resource files from being copied to the Resource directory in the macOS application. I'm not sure what the difference here is, but doing this step during create_ladybird_bundle() works.
2024-06-05 19:04:21 +00:00
include(cmake/ResourceFiles.cmake)
Ladybird/Meta: Convert to CMake build
2022-07-04 11:45:18 +00:00
CMake: Move ladybird target creation to UI-specific CMakeLists
2024-06-04 20:00:26 +00:00
set(LADYBIRD_SOURCES
${CMAKE_CURRENT_SOURCE_DIR}/HelperProcess.cpp
${CMAKE_CURRENT_SOURCE_DIR}/Utilities.cpp
Ladybird/Meta: Convert to CMake build
2022-07-04 11:45:18 +00:00
)
CMake: Make sure to install generated sources and header files We weren't installing a lot of generated sources for the top level Lagom build or for LibWeb, making it impossible to use LibWeb from a find_package. ...And also Kernel/API/KeyCode.h, which is included by no less than 8 different files in Userland/Libraries. We also weren't installing any Ladybird header files.
2023-08-08 04:14:22 +00:00
set(LADYBIRD_HEADERS
HelperProcess.h
Types.h
Utilities.h
)
Ladybird/Meta: Convert to CMake build
2022-07-04 11:45:18 +00:00
CMake: Move ladybird target creation to UI-specific CMakeLists
2024-06-04 20:00:26 +00:00
function(create_ladybird_bundle target_name)
set_target_properties(${target_name} PROPERTIES
OUTPUT_NAME "Ladybird"
Ladybird: Switch macOS plist information to use ladybird.org
2024-07-20 14:42:26 +00:00
MACOSX_BUNDLE_GUI_IDENTIFIER org.ladybird.Ladybird
CMake: Move ladybird target creation to UI-specific CMakeLists
2024-06-04 20:00:26 +00:00
MACOSX_BUNDLE_BUNDLE_VERSION ${PROJECT_VERSION}
MACOSX_BUNDLE_SHORT_VERSION_STRING ${PROJECT_VERSION_MAJOR}.${PROJECT_VERSION_MINOR}
MACOSX_BUNDLE_INFO_PLIST "${LADYBIRD_SOURCE_DIR}/Ladybird/Info.plist"
MACOSX_BUNDLE TRUE
WIN32_EXECUTABLE TRUE
Ladybird: Switch macOS plist information to use ladybird.org
2024-07-20 14:42:26 +00:00
XCODE_ATTRIBUTE_PRODUCT_BUNDLE_IDENTIFIER org.ladybird.Ladybird
Ladybird: Add configuration option to build without Qt This should open the door for adding more GUI chromes to the repository
2023-08-08 01:42:06 +00:00
)
CMake: Move ladybird target creation to UI-specific CMakeLists
2024-06-04 20:00:26 +00:00
if (APPLE)
set(bundle_dir "$<TARGET_BUNDLE_DIR:${target_name}>")
add_custom_command(TARGET ${target_name} POST_BUILD
COMMAND "${CMAKE_COMMAND}" -E make_directory "${bundle_dir}/Contents/Resources"
COMMAND "iconutil" --convert icns "${LADYBIRD_SOURCE_DIR}/Ladybird/Icons/macos/app_icon.iconset" --output "${bundle_dir}/Contents/Resources/app_icon.icns"
)
# Note: This symlink is removed in the install commands
# This makes the bundle in the build directory *NOT* relocatable
add_custom_command(TARGET ${target_name} POST_BUILD
COMMAND "${CMAKE_COMMAND}" -E create_symlink "${CMAKE_LIBRARY_OUTPUT_DIRECTORY}" "${bundle_dir}/Contents/lib"
)
CMake: Add a command for codesigning with the get-task-allow entitlement This allows developers on macOS to open Ladybird.app in Instruments. Add some documentation for how to use the command as well. It is enabled automatically when CMAKE_BUILD_TYPE is not Release or RelWithDebInfo.
2024-06-30 02:06:23 +00:00
if (NOT CMAKE_BUILD_TYPE MATCHES "Release|RelWithDebInfo")
add_custom_command(TARGET ${target_name} POST_BUILD
COMMAND codesign -s - -v -f --entitlements "${LADYBIRD_SOURCE_DIR}/Meta/debug.plist" "${bundle_dir}"
)
else()
add_custom_target(apply-debug-entitlements
COMMAND codesign -s - -v -f --entitlements "${LADYBIRD_SOURCE_DIR}/Meta/debug.plist" "${bundle_dir}"
USES_TERMINAL
)
endif()
CMake: Move ladybird target creation to UI-specific CMakeLists
2024-06-04 20:00:26 +00:00
endif()
Meta: Copy resources to the app bundle during create_ladybird_bundle() For some reason, moving the UI-specific CMake to its own files prevents resource files from being copied to the Resource directory in the macOS application. I'm not sure what the difference here is, but doing this step during create_ladybird_bundle() works.
2024-06-05 19:04:21 +00:00
if (APPLE)
set(resource_base_dir "$<TARGET_BUNDLE_DIR:${target_name}>/Contents/Resources")
else()
set(resource_base_dir "${CMAKE_BINARY_DIR}/${IN_BUILD_PREFIX}${CMAKE_INSTALL_DATADIR}/Lagom")
endif()
copy_resources_to_build(${resource_base_dir} ${target_name})
CMake: Move ladybird target creation to UI-specific CMakeLists
2024-06-04 20:00:26 +00:00
endfunction()
# Select UI Framework
if (ENABLE_QT)
add_subdirectory(Qt)
Ladybird: Implement an AppKit chrome for macOS :^) This adds an alternative Ladybird chrome for macOS using the AppKit framework. Just about everything needed for normal web browsing has been implemented. This includes: * Tabbed, scrollable navigation * History navigation (back, forward, reload) * Keyboard / mouse events * Favicons * Context menus * Cookies * Dialogs (alert, confirm, prompt) * WebDriver support This does not include debugging tools like the JavaScript console and inspector, nor theme support. The Qt chrome is still used by default. To use the AppKit chrome, set the ENABLE_QT CMake option to OFF.
2023-08-20 20:14:31 +00:00
elseif (APPLE)
CMake: Move ladybird target creation to UI-specific CMakeLists
2024-06-04 20:00:26 +00:00
add_subdirectory(AppKit)
Ladybird: Add new template Kotlin Android application without Qt This template app from Android Studio should hopefully be more fun to work on than the Qt wrapped application we were using before. :^) It currently builds the native code using gradle rules, and has a stub WebViewImplementationNative class that will wrap a c++ class of the same name that inhertis from WebView::ViewImplementation. Spawning helper processes and creating proper views in Kotlin is next on the list.
2023-09-02 15:30:21 +00:00
elseif(ANDROID)
CMake: Move ladybird target creation to UI-specific CMakeLists
2024-06-04 20:00:26 +00:00
add_subdirectory(Android)
Ladybird: Add configuration option to build without Qt This should open the door for adding more GUI chromes to the repository
2023-08-08 01:42:06 +00:00
else()
# TODO: Check for other GUI frameworks here when we move them in-tree
# For now, we can export a static library of common files for chromes to link to
CMake: Move ladybird target creation to UI-specific CMakeLists
2024-06-04 20:00:26 +00:00
add_library(ladybird STATIC ${LADYBIRD_SOURCES})
endif()
if (NOT TARGET ladybird)
message(FATAL_ERROR "UI Framework selection must declare a ladybird target")
Ladybird: Add configuration option to build without Qt This should open the door for adding more GUI chromes to the repository
2023-08-08 01:42:06 +00:00
endif()
Ladybird: Implement an AppKit chrome for macOS :^) This adds an alternative Ladybird chrome for macOS using the AppKit framework. Just about everything needed for normal web browsing has been implemented. This includes: * Tabbed, scrollable navigation * History navigation (back, forward, reload) * Keyboard / mouse events * Favicons * Context menus * Cookies * Dialogs (alert, confirm, prompt) * WebDriver support This does not include debugging tools like the JavaScript console and inspector, nor theme support. The Qt chrome is still used by default. To use the AppKit chrome, set the ENABLE_QT CMake option to OFF.
2023-08-20 20:14:31 +00:00
Ladybird+LibWebView: Add mechanism to get Mach task port for helpers On macOS, it's not trivial to get a Mach task port for your children. This implementation registers the chrome process as a well-known service with launchd based on its pid, and lets each child process send over a reference to its mach_task_self() back to the chrome. We'll need this Mach task port right to get process statistics.
2024-04-04 20:10:08 +00:00
if (APPLE)
target_sources(ladybird PRIVATE MachPortServer.cpp)
target_link_libraries(ladybird PRIVATE LibThreading)
endif()
CMake: Make sure to install generated sources and header files We weren't installing a lot of generated sources for the top level Lagom build or for LibWeb, making it impossible to use LibWeb from a find_package. ...And also Kernel/API/KeyCode.h, which is included by no less than 8 different files in Userland/Libraries. We also weren't installing any Ladybird header files.
2023-08-08 04:14:22 +00:00
target_sources(ladybird PUBLIC FILE_SET ladybird TYPE HEADERS
Everywhere: Replace SERENITY_SOURCE_DIR with LADYBIRD_SOURCE_DIR In order to have checkouts of both SerenityOS and Ladybird, we need to use a different environment variable for Ladybird.
2024-06-03 12:40:19 +00:00
BASE_DIRS ${LADYBIRD_SOURCE_DIR}
CMake: Make sure to install generated sources and header files We weren't installing a lot of generated sources for the top level Lagom build or for LibWeb, making it impossible to use LibWeb from a find_package. ...And also Kernel/API/KeyCode.h, which is included by no less than 8 different files in Userland/Libraries. We also weren't installing any Ladybird header files.
2023-08-08 04:14:22 +00:00
FILES ${LADYBIRD_HEADERS}
)
Everywhere: Remove LibSQL, SQLServer, and the sql REPL :^) It is now entirely unused and replaced by sqlite3.
2024-06-04 20:40:48 +00:00
target_link_libraries(ladybird PRIVATE AK LibCore LibFileSystem LibGfx LibImageDecoderClient LibIPC LibJS LibMain LibWeb LibWebView LibProtocol LibURL)
Ladybird/Meta: Convert to CMake build
2022-07-04 11:45:18 +00:00
Ladybird: Render web content in a separate process :^) This patch brings over the WebContent process over from SerenityOS to Ladybird, along with a new WebContentView widget that renders web content in a separate process. There's a lot of jank and FIXME material here, notably I had to re-add manually pumped Core::EventLoop instances on both sides, in order to get the IPC protocol running. This introduces a lot of latency and we should work towards replacing those loops with improved abstractions. The WebContent process is built separately here (not part of Lagom) and we provide our own main.cpp for it. Like everything, this can be better architected, it's just a starting point. :^)
2022-10-05 13:23:41 +00:00
target_include_directories(ladybird PRIVATE ${CMAKE_CURRENT_BINARY_DIR})
Everywhere: Replace SERENITY_SOURCE_DIR with LADYBIRD_SOURCE_DIR In order to have checkouts of both SerenityOS and Ladybird, we need to use a different environment variable for Ladybird.
2024-06-03 12:40:19 +00:00
target_include_directories(ladybird PRIVATE ${LADYBIRD_SOURCE_DIR}/Userland/)
target_include_directories(ladybird PRIVATE ${LADYBIRD_SOURCE_DIR}/Userland/Services/)
Ladybird: Render web content in a separate process :^) This patch brings over the WebContent process over from SerenityOS to Ladybird, along with a new WebContentView widget that renders web content in a separate process. There's a lot of jank and FIXME material here, notably I had to re-add manually pumped Core::EventLoop instances on both sides, in order to get the IPC protocol running. This introduces a lot of latency and we should work towards replacing those loops with improved abstractions. The WebContent process is built separately here (not part of Lagom) and we provide our own main.cpp for it. Like everything, this can be better architected, it's just a starting point. :^)
2022-10-05 13:23:41 +00:00
Ladybird: Move helper processes to CMAKE_INSTALL_LIBEXECDIR It aligns better with the Filesystem Heirarchy Standard[1] to put our program-specific helper programs that are not intended to be executed by the user of the application in $prefix/libexec or in whatever the packager sets as the CMake equivalent. Namely, on Debian systems this should be /usr/lib/Ladybird or similar. [1] https://refspecs.linuxfoundation.org/FHS_3.0/fhs-3.0.html#usrlibexec
2024-02-24 00:02:17 +00:00
function(set_helper_process_properties)
set(targets ${ARGV})
Ladybird: Always place helper processes in bundle directory on macOS Don't put them in bin/ and then copy them to the bundle dir later, as this means that they only get updated in the bundle directory if the Ladybird binary itself needs updated. Which is not a fun workflow if you are working on WPT and want to hack on the WebDriver binary.
2024-02-21 23:16:15 +00:00
if (APPLE)
# Store helper processes in the same bundle directory as the main application
Ladybird: Move helper processes to CMAKE_INSTALL_LIBEXECDIR It aligns better with the Filesystem Heirarchy Standard[1] to put our program-specific helper programs that are not intended to be executed by the user of the application in $prefix/libexec or in whatever the packager sets as the CMake equivalent. Namely, on Debian systems this should be /usr/lib/Ladybird or similar. [1] https://refspecs.linuxfoundation.org/FHS_3.0/fhs-3.0.html#usrlibexec
2024-02-24 00:02:17 +00:00
set_target_properties(${targets} PROPERTIES RUNTIME_OUTPUT_DIRECTORY "$<TARGET_FILE_DIR:ladybird>")
else()
Meta: Handle output directories for multi-config CMake generators For Ninja Multi-Config, Xcode and Visual Studio, the way we set up our output directories would result in exectuables that can't run from the build directory. Add the same sauce that we added to Jakt to insert ``$<CONFIG>`` where appropriate.
2024-02-25 05:01:17 +00:00
set_target_properties(${targets} PROPERTIES RUNTIME_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/${IN_BUILD_PREFIX}${CMAKE_INSTALL_LIBEXECDIR}")
Ladybird: Move helper processes to CMAKE_INSTALL_LIBEXECDIR It aligns better with the Filesystem Heirarchy Standard[1] to put our program-specific helper programs that are not intended to be executed by the user of the application in $prefix/libexec or in whatever the packager sets as the CMake equivalent. Namely, on Debian systems this should be /usr/lib/Ladybird or similar. [1] https://refspecs.linuxfoundation.org/FHS_3.0/fhs-3.0.html#usrlibexec
2024-02-24 00:02:17 +00:00
if (NOT CMAKE_INSTALL_LIBEXECDIR STREQUAL "libexec")
set_source_files_properties(Utilities.cpp PROPERTIES COMPILE_DEFINITIONS LADYBIRD_LIBEXECDIR="${CMAKE_INSTALL_LIBEXECDIR}")
CMake: Move ladybird target creation to UI-specific CMakeLists
2024-06-04 20:00:26 +00:00
set_source_files_properties(Utilities.cpp TARGET_DIRECTORY ladybird PROPERTIES COMPILE_DEFINITIONS LADYBIRD_LIBEXECDIR="${CMAKE_INSTALL_LIBEXECDIR}")
Ladybird: Move helper processes to CMAKE_INSTALL_LIBEXECDIR It aligns better with the Filesystem Heirarchy Standard[1] to put our program-specific helper programs that are not intended to be executed by the user of the application in $prefix/libexec or in whatever the packager sets as the CMake equivalent. Namely, on Debian systems this should be /usr/lib/Ladybird or similar. [1] https://refspecs.linuxfoundation.org/FHS_3.0/fhs-3.0.html#usrlibexec
2024-02-24 00:02:17 +00:00
set_source_files_properties(Utilities.cpp TARGET_DIRECTORY ${targets} PROPERTIES COMPILE_DEFINITIONS LADYBIRD_LIBEXECDIR="${CMAKE_INSTALL_LIBEXECDIR}")
endif()
Ladybird: Always place helper processes in bundle directory on macOS Don't put them in bin/ and then copy them to the bundle dir later, as this means that they only get updated in the bundle directory if the Ladybird binary itself needs updated. Which is not a fun workflow if you are working on WPT and want to hack on the WebDriver binary.
2024-02-21 23:16:15 +00:00
endif()
endfunction()
Ladybird: Move Qt-specific classes and functions to a Qt subdirectory This will help a lot with developing chromes for different UI frameworks where we can see which helper classes and processes are really using Qt vs just using it to get at helper data. As a bonus, remove Qt dependency from WebDriver.
2023-08-05 16:42:26 +00:00
add_executable(headless-browser
Everywhere: Replace SERENITY_SOURCE_DIR with LADYBIRD_SOURCE_DIR In order to have checkouts of both SerenityOS and Ladybird, we need to use a different environment variable for Ladybird.
2024-06-03 12:40:19 +00:00
${LADYBIRD_SOURCE_DIR}/Userland/Utilities/headless-browser.cpp
CMake: Move ladybird target creation to UI-specific CMakeLists
2024-06-04 20:00:26 +00:00
${LADYBIRD_SOURCES})
headless-browser: Re-implement headless-browser using an OOPWV headless-browser currently uses its own PageClient to load web pages in-process. Due to this, it also needs to set up a whole bunch of other objects needed to run LibWeb, e.g. image decoders, request servers, etc. This changes headless-browser to instead implement a WebView to launch WebContent out-of-process. This implementation is almost entirely empty, but can be filled in as-needed. For example, we may want to print JavaScript console messages.
2023-03-12 16:38:15 +00:00
target_include_directories(headless-browser PRIVATE ${CMAKE_CURRENT_BINARY_DIR})
Everywhere: Replace SERENITY_SOURCE_DIR with LADYBIRD_SOURCE_DIR In order to have checkouts of both SerenityOS and Ladybird, we need to use a different environment variable for Ladybird.
2024-06-03 12:40:19 +00:00
target_include_directories(headless-browser PRIVATE ${LADYBIRD_SOURCE_DIR}/Userland/)
Everywhere: Remove LibSQL, SQLServer, and the sql REPL :^) It is now entirely unused and replaced by sqlite3.
2024-06-04 20:40:48 +00:00
target_link_libraries(headless-browser PRIVATE AK LibCore LibWeb LibWebView LibWebSocket LibCrypto LibFileSystem LibHTTP LibImageDecoderClient LibJS LibGfx LibMain LibTLS LibIPC LibDiff LibProtocol LibURL)
headless-browser: Re-implement headless-browser using an OOPWV headless-browser currently uses its own PageClient to load web pages in-process. Due to this, it also needs to set up a whole bunch of other objects needed to run LibWeb, e.g. image decoders, request servers, etc. This changes headless-browser to instead implement a WebView to launch WebContent out-of-process. This implementation is almost entirely empty, but can be filled in as-needed. For example, we may want to print JavaScript console messages.
2023-03-12 16:38:15 +00:00
Meta: Uncouple ladybird.sh run from a specific CMake configuration
2024-06-04 23:07:04 +00:00
add_custom_target(run
Everywhere: Replace SERENITY_SOURCE_DIR with LADYBIRD_SOURCE_DIR In order to have checkouts of both SerenityOS and Ladybird, we need to use a different environment variable for Ladybird.
2024-06-03 12:40:19 +00:00
COMMAND "${CMAKE_COMMAND}" -E env "LADYBIRD_SOURCE_DIR=${LADYBIRD_SOURCE_DIR}" "$<TARGET_FILE:ladybird>" $ENV{LAGOM_ARGS}
Ladybird/Meta: Convert to CMake build
2022-07-04 11:45:18 +00:00
USES_TERMINAL
Meta: Support running ladybird with arguments from serenity.sh You may now, for example, run: ./Meta/serenity.sh run lagom ladybird https://serenityos.org
2023-01-26 11:51:48 +00:00
VERBATIM
Ladybird/Meta: Convert to CMake build
2022-07-04 11:45:18 +00:00
)
Meta+CMake: Use lldb on macOS for debugging
2024-06-30 02:05:33 +00:00
if (APPLE)
add_custom_target(debug-ladybird
COMMAND "${CMAKE_COMMAND}" -E env "LADYBIRD_SOURCE_DIR=${LADYBIRD_SOURCE_DIR}" lldb "$<TARGET_BUNDLE_DIR:ladybird>"
USES_TERMINAL
)
else()
add_custom_target(debug-ladybird
COMMAND "${CMAKE_COMMAND}" -E env "LADYBIRD_SOURCE_DIR=${LADYBIRD_SOURCE_DIR}" gdb "$<TARGET_FILE:ladybird>"
USES_TERMINAL
)
endif()
Ladybird/Meta: Convert to CMake build
2022-07-04 11:45:18 +00:00
Ladybird: Decode images out of process This patch brings a service to handle image decompression. With it comes security enhancement due to the process boundary. Indeed, consequences of a potential attack is reduced as only the decoder will crash without perturbing the WebContent process. It also allows us to display pages containing images that we claim to support but still make us crash, like for not-finished-yet decoders. As an example, we can now load https://jpegxl.info/jxl-art.html without crashing the WebContent process.
2023-09-08 10:30:50 +00:00
add_subdirectory(ImageDecoder)
add_subdirectory(RequestServer)
Ladybird: Ensure that installed ladybird can launch WebContent process Always call platform_init after there's a QApplication, because in the installed configuration that's how we find the resources. Try QCoreApplication::applicationDirPath() after looking in ./WebContent for the WebContent process. In an installed configuration, ladybird and WebContent will both be in $PREFIX/bin. Add install rules for WebContent and its linked libraries, for if they ever differ from ladybird's.
2022-10-07 23:08:29 +00:00
add_subdirectory(WebContent)
Ladybird: Implement WebDriver for Ladybird :^) This adds a WebDriver binary for Ladybird to make use of Serenity's WebDriver implementation. This has to use the same IPC socket handling that was used to make WebContent work out-of-process. Besides that, we are able to reuse almost everything from Serenity.
2022-11-14 17:09:14 +00:00
add_subdirectory(WebDriver)
LibWeb+WebWorker: Move worker execution into a new WebWorker process We now create a WorkerAgent for the parent context, which is currently only a Window. Note that Workers can have Workers per the spec. The WorkerAgent spawns a WebWorker process to hold the actual script execution of the Worker. This is modeled with the DedicatedWorkerHost object in the WebWorker process. A start_dedicated_worker IPC method in the WebWorker IPC creates the WorkerHost object. Future different worker types may use different IPC messages to create their WorkerHost instance. This implementation cannot yet postMessage between the parent and the child processes. Co-Authored-By: Andreas Kling <kling@serenityos.org>
2023-11-08 18:47:41 +00:00
add_subdirectory(WebWorker)
Ladybird: Always place helper processes in bundle directory on macOS Don't put them in bin/ and then copy them to the bundle dir later, as this means that they only get updated in the bundle directory if the Ladybird binary itself needs updated. Which is not a fun workflow if you are working on WPT and want to hack on the WebDriver binary.
2024-02-21 23:16:15 +00:00
Everywhere: Remove LibSQL, SQLServer, and the sql REPL :^) It is now entirely unused and replaced by sqlite3.
2024-06-04 20:40:48 +00:00
set(ladybird_helper_processes ImageDecoder RequestServer WebContent WebWorker)
Meta: Do not place headless-browser and WebDriver in libexec These are standalone applications meant to be run by the user directly, as opposed to other libexec processes which are programmatically forked by the browser. To do this, we simply remove these processes from the `ladybird_helper_processes` list. We must also explicitly list the dependencies for these processes.
2024-03-16 18:52:20 +00:00
Ladybird: Always place helper processes in bundle directory on macOS Don't put them in bin/ and then copy them to the bundle dir later, as this means that they only get updated in the bundle directory if the Ladybird binary itself needs updated. Which is not a fun workflow if you are working on WPT and want to hack on the WebDriver binary.
2024-02-21 23:16:15 +00:00
add_dependencies(ladybird ${ladybird_helper_processes})
Meta: Do not place headless-browser and WebDriver in libexec These are standalone applications meant to be run by the user directly, as opposed to other libexec processes which are programmatically forked by the browser. To do this, we simply remove these processes from the `ladybird_helper_processes` list. We must also explicitly list the dependencies for these processes.
2024-03-16 18:52:20 +00:00
add_dependencies(headless-browser ${ladybird_helper_processes})
add_dependencies(WebDriver ladybird headless-browser)
Ladybird: Improve Xcode generator experience and copy helpers to bundle We had a mismatch in the GUI Identifier property, causing warnings in Xcode. It was also missing the Product Identifier Xcode property on ladybird itself, causing another warning. Copy all our helper processes to the ladybird.app bundle directory so that they can be found by ``open ladybird.app`` and the Xcode debugger. For the future, we should look in ../Resources for resources on macOS. Copying resources to that directory requires more CMake-fu.
2023-03-26 15:53:32 +00:00
Ladybird: Move helper processes to CMAKE_INSTALL_LIBEXECDIR It aligns better with the Filesystem Heirarchy Standard[1] to put our program-specific helper programs that are not intended to be executed by the user of the application in $prefix/libexec or in whatever the packager sets as the CMake equivalent. Namely, on Debian systems this should be /usr/lib/Ladybird or similar. [1] https://refspecs.linuxfoundation.org/FHS_3.0/fhs-3.0.html#usrlibexec
2024-02-24 00:02:17 +00:00
set_helper_process_properties(${ladybird_helper_processes})
Meta: Do not place headless-browser and WebDriver in libexec These are standalone applications meant to be run by the user directly, as opposed to other libexec processes which are programmatically forked by the browser. To do this, we simply remove these processes from the `ladybird_helper_processes` list. We must also explicitly list the dependencies for these processes.
2024-03-16 18:52:20 +00:00
if (APPLE)
set_helper_process_properties(headless-browser WebDriver)
endif()
Ladybird: Ensure that installed ladybird can launch WebContent process Always call platform_init after there's a QApplication, because in the installed configuration that's how we find the resources. Try QCoreApplication::applicationDirPath() after looking in ./WebContent for the WebContent process. In an installed configuration, ladybird and WebContent will both be in $PREFIX/bin. Add install rules for WebContent and its linked libraries, for if they ever differ from ladybird's.
2022-10-07 23:08:29 +00:00
Ladybird/CMake: Install resources and Lagom libraries alongside ladybird This setup should allow the package maintainers who are looking to distribute ladybird on their distributions to use CMake to install ladybird using cmake install rules rather than having to write their own
2022-09-16 10:08:24 +00:00
if(NOT CMAKE_SKIP_INSTALL_RULES)
include(cmake/InstallRules.cmake)
endif()
Ladybird+CI: Move layout_test.sh test runner from CI yml into CMake We should be able to run this locally, as long as ENABLE_LAGOM_LADYBIRD is true, or if building ladybird from the ladybird source directory. This removes a special case from the Lagom CI yml file.
2023-03-10 17:45:50 +00:00
if (BUILD_TESTING)
add_test(
Ladybird: Run all layout & text tests in the same process Instead of starting a new headless-browser for every layout & text test, headless-browser now gets a mode where it runs all the tests in a single process. This is massively faster on my machine, taking a full LibWeb test run from 14 seconds to less than 1 second. Hopefully it will be a similarly awesome improvement on CI where it has been soaking up more and more time lately. :^)
2023-05-27 17:46:17 +00:00
NAME LibWeb
Meta: Do not pass an empty --resources flag to headless-browser The ${resource_base_dir} no longer exists in this context. Thus LibWeb tests were no longer actually running.
2024-06-06 11:20:48 +00:00
COMMAND $<TARGET_FILE:headless-browser> --run-tests ${LADYBIRD_SOURCE_DIR}/Tests/LibWeb --dump-failed-ref-tests
Ladybird+CI: Move layout_test.sh test runner from CI yml into CMake We should be able to run this locally, as long as ENABLE_LAGOM_LADYBIRD is true, or if building ladybird from the ladybird source directory. This removes a special case from the Lagom CI yml file.
2023-03-10 17:45:50 +00:00
)
Ladybird+Meta: Add ctest to run WPT in the Integration configuration By running ctest -C Integration -R WPT, you can run WPT. Adding just -C Integration will run all other tests *and* the WPT test. Also add support for ./Meta/serenity.sh test lagom WPT to serenity.sh
2023-08-19 19:46:26 +00:00
add_test(
NAME WPT
CONFIGURATIONS Integration
Meta: Add new top-level CMakeLists
2024-06-03 19:24:20 +00:00
COMMAND ${CMAKE_CURRENT_SOURCE_DIR}/../Tests/LibWeb/WPT/run.sh --webdriver-binary=$<TARGET_FILE:WebDriver>
Ladybird+Meta: Add ctest to run WPT in the Integration configuration By running ctest -C Integration -R WPT, you can run WPT. Adding just -C Integration will run all other tests *and* the WPT test. Also add support for ./Meta/serenity.sh test lagom WPT to serenity.sh
2023-08-19 19:46:26 +00:00
)
set_tests_properties(LibWeb WPT PROPERTIES
DEPENDS ladybird
ENVIRONMENT QT_QPA_PLATFORM=offscreen
Everywhere: Replace SERENITY_SOURCE_DIR with LADYBIRD_SOURCE_DIR In order to have checkouts of both SerenityOS and Ladybird, we need to use a different environment variable for Ladybird.
2024-06-03 12:40:19 +00:00
ENVIRONMENT "LADYBIRD_SOURCE_DIR=${LADYBIRD_SOURCE_DIR}"
Ladybird+Meta: Add ctest to run WPT in the Integration configuration By running ctest -C Integration -R WPT, you can run WPT. Adding just -C Integration will run all other tests *and* the WPT test. Also add support for ./Meta/serenity.sh test lagom WPT to serenity.sh
2023-08-19 19:46:26 +00:00
)
Ladybird+CI: Move layout_test.sh test runner from CI yml into CMake We should be able to run this locally, as long as ENABLE_LAGOM_LADYBIRD is true, or if building ladybird from the ladybird source directory. This removes a special case from the Lagom CI yml file.
2023-03-10 17:45:50 +00:00
endif()
Reference in a new issue Copy permalink