ladybird/AK/Demangle.h

/*
 * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
 *
 * SPDX-License-Identifier: BSD-2-Clause
 */

#pragma once

#include <AK/String.h>
#include <AK/StringView.h>
#include <cxxabi.h>

namespace AK {

inline String demangle(const StringView& name)
{
    int status = 0;
    auto* demangled_name = abi::__cxa_demangle(name.to_string().characters(), nullptr, nullptr, &status);
    auto string = String(status == 0 ? demangled_name : name);
    if (status == 0)
        kfree(demangled_name);
    return string;
}

}

using AK::demangle;
Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header. 2020-01-18 08:38:21 +00:00			`/*`
			`* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>`
			`*`
Everything: Move to SPDX license identifiers in all files. SPDX License Identifiers are a more compact / standardized way of representing file license information. See: https://spdx.dev/resources/use/#identifiers This was done with the `ambr` search and replace tool. ambr --no-parent-ignore --key-from-file --rep-from-file key.txt rep.txt * 2021-04-22 08:24:48 +00:00			`* SPDX-License-Identifier: BSD-2-Clause`
Meta: Add license header to source files As suggested by Joshua, this commit adds the 2-clause BSD license as a comment block to the top of every source file. For the first pass, I've just added myself for simplicity. I encourage everyone to add themselves as copyright holders of any file they've added or modified in some significant way. If I've added myself in error somewhere, feel free to replace it with the appropriate copyright holder instead. Going forward, all new source files should include a license header. 2020-01-18 08:38:21 +00:00			`*/`

Kernel: Demangle kernel C++ symbols correctly again I broke this while implementing module linking. Also move the actual demangling work to AK, in AK::demangle(const char*) 2019-11-29 13:55:07 +00:00			`#pragma once`

			`#include <AK/String.h>`
AK: Reduce header dependency graph of String.h String.h no longer pulls in StringView.h. We do this by moving a bunch of String functions out-of-line. 2020-03-23 12:45:10 +00:00			`#include <AK/StringView.h>`
AK: Remove unused ifdef for BUILDING_SERENITY_TOOLCHAIN The only use of this define was removed in commit 5f724b6ca1aae3a5a8c7189069649e8a9347cca2, over a year ago. The define was there to prevent the LibC build we built before libstdc++ from complaining about missing libgcc symbols. However, as noted in that commit, we never actually needed to build LibC at all. 2021-09-19 22:17:31 +00:00			`#include <cxxabi.h>`
Kernel: Demangle kernel C++ symbols correctly again I broke this while implementing module linking. Also move the actual demangling work to AK, in AK::demangle(const char*) 2019-11-29 13:55:07 +00:00
			`namespace AK {`

Kernel+LibELF: Don't blindly trust ELF symbol offsets in symbolication It was possible to craft a custom ELF executable that when symbolicated would cause the kernel to read from user-controlled addresses anywhere in memory. You could then fetch this memory via /proc/PID/stack We fix this by making ELFImage hand out StringView rather than raw const char* for symbol names. In case a symbol offset is outside the ELF image, you get a null StringView. :^) Test: Kernel/elf-symbolication-kernel-read-exploit.cpp 2020-01-16 21:04:44 +00:00			`inline String demangle(const StringView& name)`
Kernel: Demangle kernel C++ symbols correctly again I broke this while implementing module linking. Also move the actual demangling work to AK, in AK::demangle(const char*) 2019-11-29 13:55:07 +00:00			`{`
			`int status = 0;`
Misc: Replace "String(string_view)" with "string_view.to_string()" StringView::to_string() was added in 917ccb1 but not actually used anywhere yet. 2020-05-06 17:18:24 +00:00			`auto* demangled_name = abi::__cxa_demangle(name.to_string().characters(), nullptr, nullptr, &status);`
Kernel: Demangle kernel C++ symbols correctly again I broke this while implementing module linking. Also move the actual demangling work to AK, in AK::demangle(const char*) 2019-11-29 13:55:07 +00:00			`auto string = String(status == 0 ? demangled_name : name);`
			`if (status == 0)`
			`kfree(demangled_name);`
			`return string;`
			`}`

			`}`

			`using AK::demangle;`